aaron.ballman added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7702 + def err_lambda_used_before_capture: Error< + "captured variable %0 cannot appear before the end of the lambda's parameter list">; def note_lambda_variable_capture_fixit : Note< ---------------- aaron.ballman wrote: > It looks like this comment may have been missed. ================ Comment at: clang/lib/Parse/ParseExprCXX.cpp:1259 Actions.PushLambdaScope(); + Actions.ActOnLambdaIntroducer(Intro, getCurScope()); ---------------- aaron.ballman wrote: > This call surprises me here -- I would expect to see this called from > `ParseLambdaIntroducer()` so that anyone who parses a lambda introducer gets > the action. I'd still like to hear why this is being called here instead of when parsing the lambda introducer itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
