[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/solaris-ld.c:20 // CHECK-LD-SPARC32-SAME: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD-SPARC32-SAME: "-zignore" +// CHECK-LD-SPARC32-SAME: "-lato

[PATCH] D119326: [clang] [MinGW] Default to DWARF 4

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119326/new/ https://reviews.llvm.org/D119326 _

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364 _

[PATCH] D119326: [clang] [MinGW] Default to DWARF 4

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf64b2d2858: [clang] [MinGW] Default to DWARF 4 (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119326/new/ https://reviews.llvm.org/

[clang] 6cf64b2 - [clang] [MinGW] Default to DWARF 4

Author: Martin Storsjö Date: 2022-02-10T10:59:05+02:00 New Revision: 6cf64b2d2858dc93c3ec93438bdaca2807847e9b URL: https://github.com/llvm/llvm-project/commit/6cf64b2d2858dc93c3ec93438bdaca2807847e9b DIFF: https://github.com/llvm/llvm-project/commit/6cf64b2d2858dc93c3ec93438bdaca2807847e9b.diff

[clang] c70b935 - [AArch64] ACLE feature macro for Armv8.8-A MOPS

Author: tyb0807 Date: 2022-02-10T09:08:35Z New Revision: c70b9350890152fdcc5e65201c8f8146e977658a URL: https://github.com/llvm/llvm-project/commit/c70b9350890152fdcc5e65201c8f8146e977658a DIFF: https://github.com/llvm/llvm-project/commit/c70b9350890152fdcc5e65201c8f8146e977658a.diff LOG: [AArc

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc70b93508901: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 8d37043 - [OpenCL] Refactor cl_ext_float_atomics declarations; NFC

Author: Sven van Haastregt Date: 2022-02-10T09:43:32Z New Revision: 8d37043520f57e63e032c9d0ba4cba8701a3cd35 URL: https://github.com/llvm/llvm-project/commit/8d37043520f57e63e032c9d0ba4cba8701a3cd35 DIFF: https://github.com/llvm/llvm-project/commit/8d37043520f57e63e032c9d0ba4cba8701a3cd35.diff

[clang] 4efde1e - [clang-format] Move FormatToken::opensBlockOrBlockTypeList to source file. NFC.

Author: Marek Kurdej Date: 2022-02-10T10:51:03+01:00 New Revision: 4efde1e554cce3f017b3d1ce700bd1860eed2ccd URL: https://github.com/llvm/llvm-project/commit/4efde1e554cce3f017b3d1ce700bd1860eed2ccd DIFF: https://github.com/llvm/llvm-project/commit/4efde1e554cce3f017b3d1ce700bd1860eed2ccd.diff

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 407425. lichray added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnostic

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 407427. lichray added a comment. - Retarget Clang 15 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D119419: [clang-format] Do not remove required spaces when aligning tokens.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/44292. Fixes https://github.co

[PATCH] D119419: [clang-format] Do not remove required spaces when aligning tokens.

curdeius added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:334-337 + if (Changes[i].NewlinesBefore == 0) +Changes[i].Spaces = +std::max(Changes[i].Spaces, + static_cast(Changes[i].Tok->SpacesRequiredBefore)); --

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 ___ cfe

[PATCH] D119419: [clang-format] Do not remove required spaces when aligning tokens.

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/WhitespaceManager.cpp:407 +// We should not remove required spaces unless we break the line before. +assert(Changes[i].NewlinesBefo

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

svenvh created this revision. svenvh added reviewers: Anastasia, haonanya. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the atomic overloads for the `global` and `local` addr

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

cor3ntin added a subscriber: erichkeane. cor3ntin added a comment. This looks like the right fix to me but I would prefer @aaron.ballman or @erichkeane to have the final say. Comment at: clang/lib/Sema/SemaExpr.cpp:16731 /*IsImmediateInvocation*/ true); - ExprEvalConte

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/lib/Basic/Builtins.cpp:79 + bool OclBlocksUnsupported = + (LangOpts.getOpenCLCompatibleVersion() < 200 || !LangOpts.Blocks) && + (BuiltinInfo.Langs & OCL_BLOCKS); svenvh wrote: > azabaznov wrote: > > T

[PATCH] D119419: [clang-format] Do not remove required spaces when aligning tokens.

curdeius updated this revision to Diff 407442. curdeius marked 3 inline comments as done. curdeius added a comment. Address review comments. Add a fixme note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119419/new/ https://reviews.llvm.org/D11941

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 407444. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/ppc_wrappers/bmi2

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Ah, I see. Please can you also remove the `CmdArgs` parameter from `arm::getARMTargetFeatures` when you commit this? This would be useful, along with a comment at the top of `getTargetFeature

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro marked an inline comment as done. ro added inline comments. Comment at: clang/test/Driver/solaris-ld.c:20 // CHECK-LD-SPARC32-SAME: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD-SPARC32-SAME: "-zignore" +// CHECK-LD-SPARC32-SAME: "-latomic" MaskRay wrote: > If they ar

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

Izaron updated this revision to Diff 407449. Izaron added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119375/new/ https://reviews.llvm.org/D119375 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/cxx2a-consteval.c

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

Izaron marked an inline comment as done. Izaron added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:16731 /*IsImmediateInvocation*/ true); - ExprEvalContexts.back().ImmediateInvocationCandidates.emplace_back(Res, 0); + /// Value-dependent constant expression a

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 407455. ro marked an inline comment as done. ro added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 Files: clang/lib/Driver/ToolChains/Common

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/test/Driver/solaris-ld.c:46 // CHECK-LD-SPARC64-SAME: "-L[[SYSROOT]]/usr/lib/sparcv9" +// CHECK-LD-SPARC64-NOT: "-zignore" +// CHECK-LD-SPARC64-NOT: "-latomic" ro wrote: > MaskRay wrote: > > Such NOT patterns are usu

[clang] a6afa9e - [Driver] Use libatomic for 32-bit SPARC atomics support

Author: Rainer Orth Date: 2022-02-10T12:40:32+01:00 New Revision: a6afa9e6b0d9a08ecc878e62343a2af80ff30435 URL: https://github.com/llvm/llvm-project/commit/a6afa9e6b0d9a08ecc878e62343a2af80ff30435 DIFF: https://github.com/llvm/llvm-project/commit/a6afa9e6b0d9a08ecc878e62343a2af80ff30435.diff L

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6afa9e6b0d9: [Driver] Use libatomic for 32-bit SPARC atomics support (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1151 foreach addrspace = [GlobalAS, LocalAS, GenericAS] in { -let Extension = !cast("FuncExtFloatAtomicsFp16" # addrspace # "LoadStore") in { - defm : BuiltinAtomicExplicit<"atomic_store",

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 407464. lichray added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Pre

[PATCH] D119319: [AArch64] Emit TBAA metadata for SVE load/store intrinsics

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. I cannot say I fully understand all the connotations of this change but my gut feeling is that if failures occur it's likely the input program is malformed. Either way, we're

[PATCH] D119426: [C++20] [Modules] Check if modulemap exists to avoid crash in implicit used C++ module

ZezhengLi created this revision. ZezhengLi added reviewers: ChuanqiXu, rsmith, urnathan. ZezhengLi added a project: clang. ZezhengLi requested review of this revision. Herald added a subscriber: cfe-commits. An impilt used of module without prebuild path may cause crash. For example: // ./dir1

[PATCH] D119426: [C++20] [Modules] Check if modulemap exists to avoid crash in implicit used C++ module

ZezhengLi updated this revision to Diff 407466. ZezhengLi added a comment. Add endline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119426/new/ https://reviews.llvm.org/D119426 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/implicit-module-with-missing-path.cpp Index:

[PATCH] D119405: [Clang][Sema] Use C++ standard terminology in clang diagnostics.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for the patch! I don't think this is an improvement; the diagnostic text goes from being correct in C but odd in C++ to being correct in C++ but odd in C (the

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

aykevl added a comment. @mehdi_amini thanks for explaining! D119342 moves slightly closer to removing SizeLevel from the pass pipeline setup. --- In other news, I found a workaround that can be used to avoid the size increase due to LoopRotate (until D119342

[PATCH] D119405: [Clang][Sema] Use C++ standard terminology in clang diagnostics.

junaire added a comment. In D119405#3310695 , @aaron.ballman wrote: > Thank you for the patch! > > I don't think this is an improvement; the diagnostic text goes from being > correct in C but odd in C++ to being correct in C++ but odd in C (the two > s

[PATCH] D110485: Support [[no_unique_address]] for all targets.

aaron.ballman added a comment. In D110485#3308878 , @mstorsjo wrote: > In D110485#3308854 , @mstorsjo > wrote: > >> To pick up the thread here again, `[[no_unique_address]]` is done and >> settled in MSVC, with

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks This might interfere with https://reviews.llvm.org/D119420 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https:/

[clang] 815446c - [clang][NFC] Standard substitution checking cleanup

Author: Nathan Sidwell Date: 2022-02-10T04:44:48-08:00 New Revision: 815446cd3e164b8be010864648d4104ad178b129 URL: https://github.com/llvm/llvm-project/commit/815446cd3e164b8be010864648d4104ad178b129 DIFF: https://github.com/llvm/llvm-project/commit/815446cd3e164b8be010864648d4104ad178b129.diff

[PATCH] D119333: [clang][NFC] Standard substitution checking cleanup

This revision was automatically updated to reflect the committed changes. urnathan marked an inline comment as done. Closed by commit rG815446cd3e16: [clang][NFC] Standard substitution checking cleanup (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

svenvh added a comment. In D119398#3310746 , @Anastasia wrote: > This might interfere with https://reviews.llvm.org/D119420 Yes it will conflict. Atomic doubles are not guarded properly for other builtins (outside of the `cl_ext_float_atomics` extensio

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 407482. achieveartificialintelligence marked 2 inline comments as done. achieveartificialintelligence added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! The rename can be made on commit. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:84 +#if (__OPENCL_CPP_VERSION__ == 100 || __OPENCL_C_VERSION__ =

[PATCH] D119405: [Clang][Sema] Use C++ standard terminology in clang diagnostics.

aaron.ballman added a comment. In D119405#3310711 , @junaire wrote: > In D119405#3310695 , @aaron.ballman > wrote: > >> Thank you for the patch! >> >> I don't think this is an improvement; the diagnostic text goe

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD,

[clang-tools-extra] d038fae - [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

Author: Greg Miller Date: 2022-02-10T13:31:07Z New Revision: d038faea4608f8f39602fb557666281c49de5722 URL: https://github.com/llvm/llvm-project/commit/d038faea4608f8f39602fb557666281c49de5722 DIFF: https://github.com/llvm/llvm-project/commit/d038faea4608f8f39602fb557666281c49de5722.diff LOG: [

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGd038faea4608: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef (authored by devjgm, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

ldionne updated this revision to Diff 407500. ldionne marked 3 inline comments as done. ldionne added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119351/new/ https://reviews.llvm.org/D119351 Files: README.md

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

ldionne added inline comments. Comment at: README.md:71 + mlir, openmp, polly, or pstl. ``LLVM_ENABLE_RUNTIMES`` can include any of + libcxx, libcxxabi, libunwind, or compiler-rt. tianshilei1992 wrote: > FWIW, OpenMP can be put into either of

[clang] ce07de2 - [clang][tests] Add test for C++ DR2406

Author: Timm Bäder Date: 2022-02-10T14:52:30+01:00 New Revision: ce07de234b77dc6cc263cdf4081eace5761d6b5a URL: https://github.com/llvm/llvm-project/commit/ce07de234b77dc6cc263cdf4081eace5761d6b5a DIFF: https://github.com/llvm/llvm-project/commit/ce07de234b77dc6cc263cdf4081eace5761d6b5a.diff LO

[clang] ef2c827 - [clang] Add test for C++ DR2390

Author: Timm Bäder Date: 2022-02-10T14:52:30+01:00 New Revision: ef2c8274dfa216078436c6acfe0274a43a737242 URL: https://github.com/llvm/llvm-project/commit/ef2c8274dfa216078436c6acfe0274a43a737242 DIFF: https://github.com/llvm/llvm-project/commit/ef2c8274dfa216078436c6acfe0274a43a737242.diff LO

[PATCH] D119224: [clang][tests] Add a testcase for C++ DR2406

This revision was automatically updated to reflect the committed changes. Closed by commit rGce07de234b77: [clang][tests] Add test for C++ DR2406 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119224/new/ https://reviews.llvm.o

[PATCH] D119230: [clang] Add test for C++ DR2390

This revision was automatically updated to reflect the committed changes. Closed by commit rGef2c8274dfa2: [clang] Add test for C++ DR2390 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119230/new/ https://reviews.llvm.org/D119

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2396 +def ext_decltype_auto_expr : ExtWarn< + "ISO C++23 DIS does not allow functional-style cast to 'decltype(auto)'">, + InGroup>; Is there a reason this one sho

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

haonanya updated this revision to Diff 407506. haonanya added a comment. Remove the .td changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 Files: clang/lib/Headers/opencl-c.h Index: clang/lib/He

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit, but otherwise I'm happy with this. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:616 +namespace value_dependent { + A quick comment on

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

svenvh accepted this revision. svenvh added a comment. Thanks, LGTM! I'll try to followup with the .td changes soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 __

[PATCH] D119162: [Pseudo] Token/TokenStream, PP directive parser.

sammccall updated this revision to Diff 407512. sammccall added a comment. Add unit tests. Clarify finalization is about the mutability of the *sequence*. Add assertions. Include cooking & cleaning of tokens. (In our prototype this was after PP but I don't think that makes much sense). Drop fields

[PATCH] D113622: [analyzer] support ignoring use-after-free checking with reference_counted attribute

aaron.ballman added a comment. In D113622#3193319 , @chrisdangelo wrote: > Hi @aaron.ballman, > > It's nice to meet you, virtually. Nice to meet you as well, and I'm very sorry that this review took so long for me to get to. It fell off my radar for a

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

Quuxplusone added inline comments. Comment at: bolt/docs/OptimizingClang.md:228-236 $ CPATH=${TOPLEV}/stage1/install/bin/ -$ cmake -G Ninja ${TOPLEV}/llvm-project/llvm -DLLVM_TARGETS_TO_BUILD=X86 \ +$ cmake -G Ninja -S ${TOPLEV}/llvm-project/llvm -B ${TOPLEV}/stage2-prof-gen \ +

[PATCH] D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Sorry about the delay in getting this reviewed, but it generally LGTM. Can you also add a release note about the fix? (I'm accepting the review and you can feel free to land with

[clang-tools-extra] bd6c697 - clangd: Set a diagnostic on a code action resulting from a tweak

Author: Christian Kandeler Date: 2022-02-10T15:58:12+01:00 New Revision: bd6c6974f5ea1626a6bb1b6adea59616d70ff3a8 URL: https://github.com/llvm/llvm-project/commit/bd6c6974f5ea1626a6bb1b6adea59616d70ff3a8 DIFF: https://github.com/llvm/llvm-project/commit/bd6c6974f5ea1626a6bb1b6adea59616d70ff3a8.

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd6c6974f5ea: clangd: Set a diagnostic on a code action resulting from a tweak (authored by ckandeler, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman accepted this revision. aaron.ballman added a comment. Thanks, this LGTM as well! I don't think the precommit CI pipeline failures are related from what I can tell. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___

[PATCH] D119440: [OpenMP][NFC] update status for 5.1 'nothing' directive to 'worked on'

dreachem created this revision. dreachem added reviewers: cchen, jdoerfert, koops. Herald added subscribers: guansong, yaxunl. dreachem requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://

[PATCH] D119440: [OpenMP][NFC] update status for 5.1 'nothing' directive to 'worked on'

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02a05097e700: [OpenMP][NFC] update status for 5.1 'nothing' direct

[clang] 02a0509 - [OpenMP][NFC] update status for 5.1 'nothing' directive to 'worked on'

Author: dreachem Date: 2022-02-10T09:22:44-06:00 New Revision: 02a05097e7003bedafeac0decb5f914429b35523 URL: https://github.com/llvm/llvm-project/commit/02a05097e7003bedafeac0decb5f914429b35523 DIFF: https://github.com/llvm/llvm-project/commit/02a05097e7003bedafeac0decb5f914429b35523.diff LOG:

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

tejohnson added a comment. In D72404#3310704 , @aykevl wrote: > @mehdi_amini thanks for explaining! D119342 > moves slightly closer to removing > SizeLevel from the pass pipeline setup. I left a comment on D119342

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. From my look, this seems to fix the problem, and covers the case that Richard brought up, and I have no comments, so I think I'm happy with it. Please give Richard/Aaron ~24 hrs to ta

[PATCH] D119446: [clang-cl] Accept the "legacy'"-target flag spelling

hans created this revision. hans added a reviewer: thakis. Herald added a subscriber: dang. hans requested review of this revision. Herald added a project: clang. we already accept "--target=". No reason to not accept "-target" too (that's the one I typically use for some reason). Repository:

[PATCH] D119446: [clang-cl] Accept the "legacy'"-target flag spelling

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119446/new/ https://reviews.llvm.org/D119446 ___

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

jloser added a comment. Would love to see this cherry-picked into the llvm 14 release branch if possible! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___ cfe

[PATCH] D119447: [clang][dataflow] Include terminator statements in buildStmtToBasicBlockMap

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This will be necessary later when we add support for evaluating logic expressions s

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

Izaron updated this revision to Diff 407564. Izaron added a comment. Add test comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119375/new/ https://reviews.llvm.org/D119375 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/cxx2a-const

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:432 if (EnableTrapOptimization && TrapOpt) { +bool IsVReg = +(MI.getNumOperands() && MI.getOperand(0).isReg()) amyk wrote: > Might be good to pull out `MI

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 added inline comments. Comment at: clang/test/CodeGen/alloc-align-attr.c:14 // CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64 // CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64 [[CASTED_ALIGN]]) ] // CHECK-NEXT:[[TMP1:%.

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407571. ychen added a comment. - Remove `CmdArgs` from `arm::getARMTargetFeatures` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/

[clang] 8baa076 - [clang-cl] Accept the "legacy" -target flag spelling

Author: Hans Wennborg Date: 2022-02-10T18:27:30+01:00 New Revision: 8baa076dffa381baa1f190356b4be5b0cc3bf13e URL: https://github.com/llvm/llvm-project/commit/8baa076dffa381baa1f190356b4be5b0cc3bf13e DIFF: https://github.com/llvm/llvm-project/commit/8baa076dffa381baa1f190356b4be5b0cc3bf13e.diff

[PATCH] D119446: [clang-cl] Accept the "legacy'"-target flag spelling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8baa076dffa3: [clang-cl] Accept the "legacy" -target flag spelling (authored by hans). Changed prior to commit: https://reviews.llvm.org/D119446?v

[clang] 71d7c8d - [clangd] Crash in __memcmp_avx2_movbe

Author: Ivan Murashko Date: 2022-02-10T09:40:44-08:00 New Revision: 71d7c8d870db3b2da1fe1b3f54be77163c55dcd2 URL: https://github.com/llvm/llvm-project/commit/71d7c8d870db3b2da1fe1b3f54be77163c55dcd2 DIFF: https://github.com/llvm/llvm-project/commit/71d7c8d870db3b2da1fe1b3f54be77163c55dcd2.diff

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d7c8d870db: [clangd] Crash in __memcmp_avx2_movbe (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.ll

[PATCH] D119061: [Clang] noinline call site attribute

aeubanks added inline comments. Comment at: clang/test/Sema/attr-noinline.cpp:14 +} + +[[clang::noinline]] static int i = bar(); // expected-error {{'noinline' attribute only applies to functions and statements}} xbolva00 wrote: > aaron.ballman wrote: > > xbolva

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 abandoned this revision. krzysz00 added a comment. Worked around elsewhere, more permanent fix pending, abandoning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119257/new/ https://reviews.llvm.org/D119257

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

avogelsgesang added a comment. Can we add this tweak as the default "fix-it" action for > Class '...' does not declare any constructor to initialize its non-modifiable > me on structs like struct X { int& a; } ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 6c7e6fc - [clang-format] Do not remove required spaces when aligning tokens.

Author: Marek Kurdej Date: 2022-02-10T19:15:27+01:00 New Revision: 6c7e6fc7b6654b7ecd364f352f8ffd6dfecbf77b URL: https://github.com/llvm/llvm-project/commit/6c7e6fc7b6654b7ecd364f352f8ffd6dfecbf77b DIFF: https://github.com/llvm/llvm-project/commit/6c7e6fc7b6654b7ecd364f352f8ffd6dfecbf77b.diff

[PATCH] D119419: [clang-format] Do not remove required spaces when aligning tokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c7e6fc7b665: [clang-format] Do not remove required spaces when aligning tokens. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119419

[clang] b96106a - [AArch64][ARM] add -Wunaligned-access only for clang

Author: Yuanfang Chen Date: 2022-02-10T10:26:30-08:00 New Revision: b96106af3f557da833b5e3b9ef9194c23ecd1596 URL: https://github.com/llvm/llvm-project/commit/b96106af3f557da833b5e3b9ef9194c23ecd1596 DIFF: https://github.com/llvm/llvm-project/commit/b96106af3f557da833b5e3b9ef9194c23ecd1596.diff

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb96106af3f55: [AArch64][ARM] add -Wunaligned-access only for clang (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] bd3a1de - [clang-cl] Support the /JMC flag

Author: Yuanfang Chen Date: 2022-02-10T10:26:30-08:00 New Revision: bd3a1de683f80d174ea9c97000db3ec3276bc022 URL: https://github.com/llvm/llvm-project/commit/bd3a1de683f80d174ea9c97000db3ec3276bc022 DIFF: https://github.com/llvm/llvm-project/commit/bd3a1de683f80d174ea9c97000db3ec3276bc022.diff

[PATCH] D118428: [clang-cl] Support the /JMC flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rGbd3a1de683f8: [clang-cl] Support the /JMC flag (authored by ychen). Changed prior to commit: https://revie

[PATCH] D119461: [compiler-rt] Fix endianness in get_sock_peer_name test

mgorny created this revision. mgorny added reviewers: tamird, vitalybuka. Herald added a subscriber: dberris. mgorny requested review of this revision. Fix passing the port and IP address with the wrong endianness in get_sock_peer_name() that causes the connect() to fail inside without an outgoing

[PATCH] D119462: resolve the bugtype typo inside emitAdditionOverflowbug function

phyBrackets created this revision. Herald added a subscriber: martong. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119462 Files: clang/lib/StaticAnalyzer/Ch

[PATCH] D119461: [compiler-rt] Fix endianness in get_sock_peer_name test

mgorny added a comment. @vitalybuka, I suspect this might also fix the test on Android but I don't have an environment to test it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119461/new/ https://reviews.llvm.org/D119461 ___ cfe-commits mai

[PATCH] D119461: [compiler-rt] Fix endianness in get_sock_peer_name test

mgorny added a comment. Thanks for the prompt review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119461/new/ https://reviews.llvm.org/D119461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D119461: [compiler-rt] Fix endianness in get_sock_peer_name test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc65fb0cdf262: [compiler-rt] Fix endianness in get_sock_peer_name test (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscr

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

sammccall added a subscriber: akyrtzi. sammccall added a comment. Thanks @akyrtzi @egorzhdan I was going to suggest that I think someone at Apple should probably look at changes here first. The goal here is to ensure that any tokens in the code that reference a decl have some AST node (which ca

[clang-tools-extra] 100ec80 - [clang-tidy] Add early exit for defaulted FunctionDecls

Author: Kirill Bobyrev Date: 2022-02-10T20:29:26+01:00 New Revision: 100ec80ab5a6a01071771b67fc2141640d0984da URL: https://github.com/llvm/llvm-project/commit/100ec80ab5a6a01071771b67fc2141640d0984da DIFF: https://github.com/llvm/llvm-project/commit/100ec80ab5a6a01071771b67fc2141640d0984da.diff

[PATCH] D119462: resolve the bugtype typo inside emitAdditionOverflowbug function in CStringChecker.cpp.

phyBrackets updated this revision to Diff 407623. phyBrackets added a comment. Use the git blame Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119462/new/ https://reviews.llvm.org/D119462 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.c

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

rsmith accepted this revision. rsmith added a comment. LGTM. Please also add something like this as a unit test: In D99134#2643441 , @rsmith wrote: > template int x = [](auto){ return T(); }.operator()(T()); > int y = x; Repository: rG LLVM Githu

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! You might want to check out how hover behaves and add a test there. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:948 Code = R"cpp

  1   2   >