paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.
I cannot say I fully understand all the connotations of this change but my gut
feeling is that if failures occur it's likely the input program is malformed.
Either way, we're early in the LLVM 15 development cycle so have plenty of time
to react if necessary.
================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:888
if (isAllActivePredicate(Pred)) {
- Builder.CreateStore(VecOp, VecPtr);
+ auto *Store = Builder.CreateStore(VecOp, VecPtr);
+ Store->copyMetadata(II);
----------------
If I'm nit picking you use `auto` here but then choose the explicit return type
(i.e. `CallInst`) for the MaskedStore local. Is there a reason for this or just
muscle memory?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119319/new/
https://reviews.llvm.org/D119319
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
