Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM! The rename can be made on commit. ================ Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:84 +#if (__OPENCL_CPP_VERSION__ == 100 || __OPENCL_C_VERSION__ == 200) +#define __opencl_c_atomic_order_seq_cst 1 ---------------- Anastasia wrote: > Why do we need to set those for `__OPENCL_CPP_VERSION__ == 100` since those > atomics are for OpenCL 2.0 onwards? Sorry C++ for OpenCL is aligned with OpenCL 2, so this check makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119420/new/ https://reviews.llvm.org/D119420 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
