erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
1 nit, but otherwise I'm happy with this. ================ Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:616 +namespace value_dependent { + ---------------- A quick comment on this test as to why it has no diagnostics would be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119375/new/ https://reviews.llvm.org/D119375 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits