[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud updated this revision to Diff 384352. crayroud marked an inline comment as done. crayroud added a comment. Reorder the options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud marked an inline comment as done. crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14275 + verifyFormat("A::A() : a (1) {}", SomeSpace2); + verifyFormat("void f() __attribute__ ((asdf));", SomeSpace2); + verifyFormat("*(&a + 1);\n" ---

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. Note that (as the examples demonstrate) clang self-verifies and checks among other things that ifuncs that it emits point to definitions; this happens in `CodeGenModule::checkAliases()`. I haven't read the cpu_specific/cpu_dispatch-related code in CodeGenModule yet,

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

tschuett added a comment. The original `ptrauth.h` has the same comment style. Would doxygen style be an improvement? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112941/new/ https://reviews.llvm.org/D112941 _

[PATCH] D95168: [clang-format] Add InsertBraces option

owenpan added a comment. In D95168#3102511 , @MyDeveloperDay wrote: > Then this is definitely why we want to think about these now and NOT leave > them to a separate review after the Insert case is committed. We can just leave a placeholder for the Remo

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. > I already had an implementation of RemoveBraces for the LLVM style (minus > some exceptions). Why not share the implementation in a review then we can combine them here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. In D105169#3104262 , @eugenis wrote: > You are absolutely right. X86 variant uses an "=a" constraint (rax register), > others pin the output variable to a specific register with __asm__ > declaration. It appears we've missed it i

[PATCH] D95168: [clang-format] Add InsertBraces option

owenpan added a comment. In D95168#3102550 , @MyDeveloperDay wrote: > This is a demo of what I mean {https://reviews.llvm.org/D113000} you can see > its pretty aggressive, I could kind of imagine people wanting a little more > control > > Sometimes this

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. > I'm in favor of a struct of enums: > > AutomaticBraces: > AfterIf: OnlyIfElse > AfterElse: Remove #this is obviously only to remove, if the else body is > a single line > AfterWhile: ... > > And we can gradually add new enumerators to handle the d

[clang] 3d32218 - [VE] Change to omitting the frame pointer on leaf functions

Author: Kazushi (Jam) Marukawa Date: 2021-11-03T17:45:18+09:00 New Revision: 3d32218d1af29a86389357b75af31af36dec051a URL: https://github.com/llvm/llvm-project/commit/3d32218d1af29a86389357b75af31af36dec051a DIFF: https://github.com/llvm/llvm-project/commit/3d32218d1af29a86389357b75af31af36dec0

[PATCH] D113087: [VE] Change to omitting the frame pointer on leaf functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d32218d1af2: [VE] Change to omitting the frame pointer on leaf functions (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. > In my experience, the simplest thing to do is to remove all optional braces > as allowed by the language syntax. When you want to add exceptions for > matching if-else braces, avoiding dangling-else warnings, etc, things get > much more complicated very quickly

[PATCH] D95168: [clang-format] Add InsertBraces option

owenpan added a comment. In D95168#3105340 , @MyDeveloperDay wrote: >> I already had an implementation of RemoveBraces for the LLVM style (minus >> some exceptions). > > Why not share the implementation in a review then we can combine them here. I want

[clang] a8083d4 - [X86][clang] Disable long double type for -mno-x87 option

Author: Andrew Savonichev Date: 2021-11-03T12:08:39+03:00 New Revision: a8083d42b1c346e21623a1d36d1f0cadd7801d83 URL: https://github.com/llvm/llvm-project/commit/a8083d42b1c346e21623a1d36d1f0cadd7801d83 DIFF: https://github.com/llvm/llvm-project/commit/a8083d42b1c346e21623a1d36d1f0cadd7801d83.d

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8083d42b1c3: [X86][clang] Disable long double type for -mno-x87 option (authored by asavonic). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1732 + if (!State) +return false; +} martong wrote: > steakhal wrote: > > I'd love to see a coverage report of the tests you add with this patch.

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. qiucf marked 3 inline comments as done. Closed by commit rG741aeda97d63: [PowerPC] Implement longdouble pack/unpack builtins (authored by qiucf). Changed prior to comm

[clang] 741aeda - [PowerPC] Implement longdouble pack/unpack builtins

Author: Qiu Chaofan Date: 2021-11-03T17:57:25+08:00 New Revision: 741aeda97d6327edd9905b21a5308fcee21bbefd URL: https://github.com/llvm/llvm-project/commit/741aeda97d6327edd9905b21a5308fcee21bbefd DIFF: https://github.com/llvm/llvm-project/commit/741aeda97d6327edd9905b21a5308fcee21bbefd.diff L

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384381. serge-sans-paille added a comment. Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/mi

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff updated this revision to Diff 384386. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103395/new/ https://reviews.llvm.org/D103395 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/consta

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/BraceInserter.cpp:105 + FormatToken *getNext(int &Line, FormatToken *current) { +if (Line == 0 && current == nullptr) { + return Lines[0]->First; HazardyKnusperkeks wrote: > Remove the {

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff added a comment. Thank you for feedback! In D103395#3096177 , @tambre wrote: > This breaks the following code: > > struct sub > { > char data; > }; > > struct main > { > constexpr main() > { > member

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added a comment. In D99#3104804 , @yonghong-song wrote: > @aaron.ballman I checked the source. Looks like we can easily get TypeLoc > from TypeSourceInfo, but not from TypeSourceInfo to TypeLoc. But We need > TypeLoc so we can get att

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

tambre added a comment. In D103395#3105668 , @sepavloff wrote: > Strange, I see that it cannot be compiled neither by gcc nor by clang: > https://godbolt.org/z/1dY9Gs6zM. Do I miss something? Sorry, should've been more specific. Try in C++20 mode: http

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan created this revision. Herald added subscribers: pengfei, hiraditya. skan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Constraint `*m` should be used when the address of a variable is passed as a value. And the con

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan updated this revision to Diff 384401. skan added a comment. clang-format the diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113096/new/ https://reviews.llvm.org/D113096 Files: clang/test/CodeGen/X86/ms_fmul.c clang/test/CodeGen/ms-inl

[clang] 1427742 - [Sema][NFC] Improve test coverage for builtin operators.

Author: Clement Courbet Date: 2021-11-03T13:32:48+01:00 New Revision: 1427742750ed1fcd2ead639c4ec5178fc34c9257 URL: https://github.com/llvm/llvm-project/commit/1427742750ed1fcd2ead639c4ec5178fc34c9257 DIFF: https://github.com/llvm/llvm-project/commit/1427742750ed1fcd2ead639c4ec5178fc34c9257.dif

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 384407. ckandeler added a comment. Limited the matching to Qt headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. >> For framework builds, the directory would be "Headers", which also seems >> safe. > > I agree extensionless headers in frameworks seem fine to show. > We already know which includepath entries are frameworks, so we can just use > that info directly (see line 9674)

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a type out of a module

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7784-7785 "because namespace %1 does not enclose namespace %2">; +def err_invalid_declarator_in_export : Error<"cannot export %0 here " + "because it had be declared in %1.">; d

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3104479 , @ibookstein wrote: > Hmm. When I try to compile an object file where the resolver is a > declaration, both clang-13, clang-14, and gcc-9.3 complain that the ifunc > must point to a defined function: >

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn abandoned this revision. fhahn added a comment. The vector builtin support took a different direction, see D111529 and following Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108832/new/ https://reviews.ll

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. I presume you lack the permissions to push this to the main repo yourself. Would you like me to do that for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 __

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. This seems not right. Now we disable too many debug cases for object mode even for 32bit target. Maybe we should test clang (built with `--default-target-triple=powerpc64-ibm-aix`) after our backend support 64-bit object mode(`-filetype=obj`) Repository: rG LLVM Gi

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. To 'unbreak' us for now, I've committed the suggested change to remove the definition check here: 09233412edae388a7bfa349cf792dba5aced057f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall added a comment. In D112996#3105783 , @ckandeler wrote: >>> For framework builds, the directory would be "Headers", which also seems >>> safe. >> >> I agree extensionless headers in frameworks seem fine to show. >> We already know which include

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

aaron.ballman added a comment. One thing that surprises me is that the test changes are in Sema but the code changes are in CodeGen. I see that this test actually emits LLVM IR. Should it be moved (as an NFC change)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:320 // linear structure. static const llvm::GlobalValue *getAliasedGlobal(const llvm::GlobalValue *GV) { + const llvm::Constant *C; Can you explain a bit better how this change h

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao added a comment. Herald added a subscriber: asavonic. Sorry for the late reply. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:903-905 Optional InferAddressSpacesImpl::updateAddressSpace( -const Value &V, const ValueToAddrSpaceMapTy &InferredAddrSpace)

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield updated this revision to Diff 384431. mbenfield added a comment. Ignore specifiers with *. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111833/new/ https://reviews.llvm.org/D111833 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[clang] b2cbdf6 - Update ast-dump-decl.mm test to work on 32 bit windows

Author: Erich Keane Date: 2021-11-03T07:42:06-07:00 New Revision: b2cbdf6c134a0aaa30f877b1e6fe42b9e16391e7 URL: https://github.com/llvm/llvm-project/commit/b2cbdf6c134a0aaa30f877b1e6fe42b9e16391e7 DIFF: https://github.com/llvm/llvm-project/commit/b2cbdf6c134a0aaa30f877b1e6fe42b9e16391e7.diff L

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added a comment. In D112916#3102767 , @serge-sans-paille wrote: > @tonic / @tstellar as members of the LLVM fundation board, can you tell us if > it's okay to ship the `confusables.txt` file from > https://www.unicode.org/Public/secur

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 384433. hliao added a comment. Move the updating action into `updateAddrSpace` and return a boolean true if it's really updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org

[clang] 45b84a5 - [Sema][NFC] Improve test coverage for builtin binary operators.

Author: Clement Courbet Date: 2021-11-03T15:51:35+01:00 New Revision: 45b84a547efe8991b28883c73efa2de798dc2c30 URL: https://github.com/llvm/llvm-project/commit/45b84a547efe8991b28883c73efa2de798dc2c30 DIFF: https://github.com/llvm/llvm-project/commit/45b84a547efe8991b28883c73efa2de798dc2c30.dif

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:131 +; CHECK: # %bb.0: +; CHECK-NEXT:tdi 3, 3, 32767 +; CHECK-NEXT:blr amyk wrote: > amyk wrote: > > nemanjai wrote: > > > Can we add `-pp

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:240 + Optional getPredicatedAddrSpace(const Value &V, Value *Opnd) const; + The pass is already using UninitializedAddressSpace as a sentinal value; just use that inst

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 384451. mbenfield added a comment. Renamed to diagnose_as_builtin (since two people suggested that name). Let me know if a name mentioning fortify is preferred. Validation in handleDiagnoseAsBuiltinAttr: - first argument is a builtin function - number of a

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

ldionne added a comment. This broke libc++'s CI: https://buildkite.com/llvm-project/libcxx-ci/builds/6374#7569da95-c852-44f9-8b69-947245cf0b65 When you make a change to Clang AND the libc++ tests at the same time, you have to account for the fact that we support older versions of Clang. For exa

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

pengfei added a comment. How about the GV is function pointer? I believe @xiangzhangllvm has lots of experience on it :) Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect inteld

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added a comment. In D112453#3103515 , @rsmith wrote: > I think this change is being made in an imperfect place, though. Instead of > putting a special case in here, how would we feel about making > `Type::isOverloadableType()` smarter, to return

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? tagging some more people who seemed like possible reviewers. I realized my original list of candidates might have mostly been inactive people. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews

[PATCH] D113115: Add diagnostic groups for attribute extensions

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, jyknight, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. Some users have a need to control attribute extension diagnostics independent of other extension diagnostics.

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

ldionne added a comment. Trying to fix this in https://reviews.llvm.org/D113112. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111477/new/ https://reviews.llvm.org/D111477 ___ cfe-commits mailing list cf

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384465. kstoimenov added a comment. Moved module instumentation back ahead of function instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: cl

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384467. kstoimenov added a comment. Moved empty check to the top of the function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/Backen

[PATCH] D113115: Add diagnostic groups for attribute extensions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I like the approach, and a pretty trivial implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113115/new/ https://reviews.llvm

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The AST structural equivalence check did not differentiate between a struct

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz created this revision. adamcz added a reviewer: kadircet. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this commit, on code like: struct S { ... }; S arr[1000]; while checking if arr is constexpr, clang wou

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added a comment. Hey Kadir. This is my naive approach at solving that large memory usage issue you reported. It works, although I wish this was more generic. I'm not an expert on this piece of code, so I tried to keep things similar to how they worked previously. Let me know what you thi

[PATCH] D113115: Add diagnostic groups for attribute extensions

aaron.ballman added a comment. In D113115#3106360 , @erichkeane wrote: > I like the approach, and a pretty trivial implementation. Thanks for the review! I'm going to hold off on landing for a little bit in case @rsmith has opinions because he had othe

[PATCH] D111669: No longer crash when a consteval function returns a structure

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111669/new/ https://reviews.llvm.org/D111669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 updated this revision to Diff 384484. jansvoboda11 added a comment. Avoid copying data between submodules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files: clang/include/clang/Lex/Head

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112616/new/ https://reviews.llvm.org/D112616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108643/new/ https://reviews.llvm.org/D108643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 384485. ckandeler added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp Index: clang/l

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! can we the tests again though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 ___

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:9619 +const bool ExtensionlessHeaders = IsSystem || isQt +|| Dir.endswith(".framework/Headers"); std::error_code EC; I'm just noticing that this is often a symlink i

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. In D112996#3106459 , @sammccall wrote: > can we the tests again though? Sorry, I don't understand what you mean by that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 added a comment. In D112915#3104873 , @vsapsai wrote: > There can be other reasons to keep `IncludeMap` out of `SubmoduleState` but > I'm not sure the local submodule visibility is the right reason. I might be > reading the code incorrectly

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384488. kstoimenov marked 3 inline comments as done. kstoimenov added a comment. Moved module after function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files

[PATCH] D111669: No longer crash when a consteval function returns a structure

erichkeane accepted this revision. erichkeane added a comment. Looks to accomplish this exactly the way that @rjmccall suggested! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111669/new/ https://reviews.llvm.org/D111669 ___ cfe-commits mail

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

dblaikie added a comment. In D111477#3106171 , @ldionne wrote: > This broke libc++'s CI: > https://buildkite.com/llvm-project/libcxx-ci/builds/6374#7569da95-c852-44f9-8b69-947245cf0b65 > > When you make a change to Clang AND the libc++ tests at the same

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3190-3191 + } + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back("+read-tp-hard"); +} ardb wrote: > nickdesaulniers wrote: > > Isn't this redundan

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

tra added a comment. LGTM in general, modulo remaining nits. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:196 void inferAddressSpaces(ArrayRef Postorder, - ValueToAddrSpaceMapTy *InferredAddrSpace) const; + V

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384515. kstoimenov added a comment. After rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Tr

[clang] 76ea87b - [ASan] Process functions in Asan module pass

Author: Kirill Stoimenov Date: 2021-11-03T17:51:01Z New Revision: 76ea87b94e5cba335d691e4e18e3464ad45c8b52 URL: https://github.com/llvm/llvm-project/commit/76ea87b94e5cba335d691e4e18e3464ad45c8b52 DIFF: https://github.com/llvm/llvm-project/commit/76ea87b94e5cba335d691e4e18e3464ad45c8b52.diff L

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76ea87b94e5c: [ASan] Process functions in Asan module pass (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384521. Jake-Egan added a comment. Updated patch to XFAIL only on 64-bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/anonymous-fie

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

kstoimenov created this revision. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 76ea87b94e5cba335d691e4e18e3464ad45c8b52

[clang] b314532 - Revert "[ASan] Process functions in Asan module pass"

Author: Kirill Stoimenov Date: 2021-11-03T18:01:01Z New Revision: b3145323b549eea95b3b088cb2064bf0bf81cfe6 URL: https://github.com/llvm/llvm-project/commit/b3145323b549eea95b3b088cb2064bf0bf81cfe6 DIFF: https://github.com/llvm/llvm-project/commit/b3145323b549eea95b3b088cb2064bf0bf81cfe6.diff L

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3145323b549: Revert "[ASan] Process functions in Asan module pass" (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D112732: [ASan] Process functions in Asan module pass

rupprecht added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn)); --

[PATCH] D112732: [ASan] Process functions in Asan module pass

rupprecht added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn)); --

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn)); -

[PATCH] D113131: [ASan] Process functions in Asan module pass.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Re-land of D112732

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 384535. hliao added a comment. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll llvm/include/llvm/Ana

[clang] 3131714 - [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

Author: Vitaly Buka Date: 2021-11-03T11:32:14-07:00 New Revision: 3131714f8daca338492a7d5b189e4d63131bc808 URL: https://github.com/llvm/llvm-project/commit/3131714f8daca338492a7d5b189e4d63131bc808 DIFF: https://github.com/llvm/llvm-project/commit/3131714f8daca338492a7d5b189e4d63131bc808.diff L

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

This revision was automatically updated to reflect the committed changes. Closed by commit rG3131714f8dac: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

nikic added a comment. I'd still like an answer to: In D112041#3073464 , @nikic wrote: > Is it actually necessary to thread this through AssumptionCache, given how > InferAddressSpaces is the only place that looks at these assumes? I'd prefer not to in

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka updated this revision to Diff 384539. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/lib/Passes/PassBuilder

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao added a comment. In D112041#3106936 , @nikic wrote: > I'd still like an answer to: > > In D112041#3073464 , @nikic wrote: > >> Is it actually necessary to thread this through AssumptionCache, given how >> I

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384544. kstoimenov added a comment. After merging D113072 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/Co

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

noajshu updated this revision to Diff 384545. noajshu added a comment. Improve error handling in Caching support library. Most of the functions now return Expected<>, except for the non-trivial destructor of CacheStream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:170 // D and Zfh imply F. bool hasVInstructionsAnyF() const { return HasStdExtV && hasStdExtF(); } unsigned getMaxInterleaveFactor() const { This needs to be the same

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added a subscriber: abrachet. mcgrathr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fuchsia already supports the more compact relocation format. Make it the defaul

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

jdoerfert updated this revision to Diff 384554. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Include the clang changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113126/new/ https://reviews.ll

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:225 +def HasStdExtVIntegerEEW32 +: Predicate<"Subtarget->hasStdExtV() || SubTarget->hasStdExtZve32x()">, + AssemblerPredicate< StdExtV depends on Zve64d which depends on Featu

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:224 + +def HasStdExtVIntegerEEW32 +: Predicate<"Subtarget->hasStdExtV() || SubTarget->hasStdExtZve32x()">, Can we add the AssemblerPredicate to HasVInstructions and use that? Or we

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. nice, thank you for improving this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113080/new/ https://reviews.llvm.org/D113080 __

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ddpagan added a comment. Thanks for reviewing the code, Aaron. Comment at: clang/lib/Serialization/ASTWriter.cpp:5018 Record.AddStmt(A->getAllocator()); +Record.AddStmt(A->getAlignment()); Record.AddSourceRange(A->getRange()); aaron.ba

  1   2   >