[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

[Christian Kandeler via Phabricator via cfe-commits]

ckandeler updated this revision to Diff 384407.
ckandeler added a comment.

Limited the matching to Qt headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112996/new/

https://reviews.llvm.org/D112996

Files:
  clang/lib/Sema/SemaCodeComplete.cpp


Index: clang/lib/Sema/SemaCodeComplete.cpp
===================================================================
--- clang/lib/Sema/SemaCodeComplete.cpp
+++ clang/lib/Sema/SemaCodeComplete.cpp
@@ -9615,6 +9615,7 @@
       }
     }
 
+    const StringRef &Dirname = llvm::sys::path::filename(Dir);
     std::error_code EC;
     unsigned Count = 0;
     for (auto It = FS.dir_begin(Dir, EC);
@@ -9648,7 +9649,9 @@
           if (!(Filename.endswith_insensitive(".h") ||
                 Filename.endswith_insensitive(".hh") ||
                 Filename.endswith_insensitive(".hpp") ||
-                Filename.endswith_insensitive(".inc")))
+                Filename.endswith_insensitive(".inc") ||
+                Dirname == "Headers" ||
+                Dirname.startswith("Qt") || Dirname == "ActiveQt"))
             break;
         }
         AddCompletion(Filename, /*IsDirectory=*/false);



Index: clang/lib/Sema/SemaCodeComplete.cpp
===================================================================
--- clang/lib/Sema/SemaCodeComplete.cpp
+++ clang/lib/Sema/SemaCodeComplete.cpp
@@ -9615,6 +9615,7 @@
       }
     }
 
+    const StringRef &Dirname = llvm::sys::path::filename(Dir);
     std::error_code EC;
     unsigned Count = 0;
     for (auto It = FS.dir_begin(Dir, EC);
@@ -9648,7 +9649,9 @@
           if (!(Filename.endswith_insensitive(".h") ||
                 Filename.endswith_insensitive(".hh") ||
                 Filename.endswith_insensitive(".hpp") ||
-                Filename.endswith_insensitive(".inc")))
+                Filename.endswith_insensitive(".inc") ||
+                Dirname == "Headers" ||
+                Dirname.startswith("Qt") || Dirname == "ActiveQt"))
             break;
         }
         AddCompletion(Filename, /*IsDirectory=*/false);

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits