arsenm added inline comments.
================ Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:240 + Optional<unsigned> getPredicatedAddrSpace(const Value &V, Value *Opnd) const; + ---------------- The pass is already using UninitializedAddressSpace as a sentinal value; just use that instead of Optional<unsigned>? ================ Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:958 + << " deduce operand AS from the predicate addrspace " + << AS.getValue() << '\n'); + OperandAS = AS.getValue(); ---------------- *AS instead of getValue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
