[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

rsmith added a comment. There might be some tooling out there that cares about `CXXConstructExpr`s that might be elided due to NRVO being marked as elidable. But it's probably OK to lose that marking if nothing in-tree is relying on it, and use `isElidable` only for copy elision from rvalues an

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov added a comment. I can have a look on what is happening with that test case. At best if we figure out what is wrong, we could add some FIXMEs and circle back to it after we make this whole thing work again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372845. mizvekov added a comment. Add a couple more test cases where we don't perform copy-elision on a returned prvalue in pre-C++17 modes, and the corresponding FIXMEs in the source code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372846. mizvekov added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h clang/lib/CodeGen/CGExprC

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372849. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h clang/lib/CodeGen/CGExprCXX.

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

beanz created this revision. beanz added reviewers: rsmith, harlanhaskins, bkramer. beanz requested review of this revision. Herald added a project: clang. This patch replaces reliance on `goto failure` pattern with `llvm::scope_exit`. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372852. mizvekov added a comment. add another FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h clang/lib/C

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Any feedback? I think this patch is good enough to be accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list

[PATCH] D108567: Implement #pragma clang final extension

beanz added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3968-3984 +Final Macros + + +Clang supports the pragma ``#pragma clang final``, which can be used to +mark macros as final, meaning they cannot be undef'd or re-defined. For example: + +.. cod

[PATCH] D109635: [OpenMP] Support construct trait set for Clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 __

[PATCH] D108567: Implement #pragma clang final extension

beanz updated this revision to Diff 372862. beanz added a comment. Updates based on feedback from @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108567/new/ https://reviews.llvm.org/D108567 Files: clang/docs/LanguageExtensions.rst

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 372863. achieveartificialintelligence added a comment. support zfinx-1.0-rc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Targ

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki marked an inline comment as done. linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"f

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 372866. achieveartificialintelligence added a comment. Updating D93298 : [RISCV] add the MC layer support of Zfinx extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. If nobody objects, I would commit this change, as it would be useful in the forthcoming return of `llvm.isnan`. Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804 __

[clang] 1f1c71a - [X86][InlineAsm] Use mem size information (*word ptr) for "global variable + registers" memory expression in inline asm.

Author: Xiang1 Zhang Date: 2021-09-15T16:11:14+08:00 New Revision: 1f1c71aeacc1c4eab385c074714508b6e7121f73 URL: https://github.com/llvm/llvm-project/commit/1f1c71aeacc1c4eab385c074714508b6e7121f73 DIFF: https://github.com/llvm/llvm-project/commit/1f1c71aeacc1c4eab385c074714508b6e7121f73.diff

[PATCH] D109739: [X86][InlineAsm][Bugfix] Use mem size information (*word ptr) for "global variable + registers" memory expression in inline asm.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f1c71aeacc1: [X86][InlineAsm] Use mem size information (*word ptr) for "global variable +… (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

mgorny created this revision. mgorny added reviewers: tstellar, cryptoad. Herald added a subscriber: dberris. mgorny requested review of this revision. 9ee64c374605683ae80b9641d5312a72c2a67336 has started using COMPILER_RT_HAS

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

LuoYuanke added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3421 +if (T0->isHalfTy()) + T1 = getFPTypeAtOffset(IRType, IROffset + 4, TD); +// If we can't get a second FP type, return a simple half or float. Not quite understanding w

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-abi.c:153 +struct float2 { + struct {} s; + float a; Add a test case for "{ struct {}; half; struct {}; half;}? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. In D109362#3000284 , @anirudhp wrote: > In D109362#2999688 , @uweigand > wrote: > >> Looking at the common code parts, it seems the behavior of MM_GOFF is >> actually identical to MM_EL

[clang] 3b9470a - [OpenCL] Supports optional image types in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-15T10:03:47+01:00 New Revision: 3b9470a6c46d0ecdb586a5a1e9223ea0c832337c URL: https://github.com/llvm/llvm-project/commit/3b9470a6c46d0ecdb586a5a1e9223ea0c832337c DIFF: https://github.com/llvm/llvm-project/commit/3b9470a6c46d0ecdb586a5a1e9223ea0c832337c.dif

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Topotuna marked an inline comment as done. Closed by commit rG3b9470a6c46d: [OpenCL] Supports optional image types in C++ for OpenCL 2021 (authored by Topotuna). Chang

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei updated this revision to Diff 372664. pengfei marked 2 inline comments as done. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files: clang/l

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea updated this revision to Diff 372674. labrinea added a comment. Changes in this revision: - Replaced the backend option that enables the mitigation with a subtarget feature so that it works with LTO (@lenary thanks for the offline hint) - Enabled the subtarget feature on the affected CP

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 372573. gandhi21299 added a comment. - converted the HIP test into a CUDA test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files: clang/lib/Driver/ToolChain

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 372551. gandhi21299 added a comment. - added the include header for HIP runtime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files: clang/lib/Driver/ToolChai

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall added a comment. This is mostly LG with nits, but I think the code-completion handler is wrong, and the tests as written won't build on windows. In D109506#2992201 , @sammccall wrote: > Oops, forgot one thing: you probably want to instrument t

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea updated this revision to Diff 372677. labrinea added a comment. Changes in this revision: - added `-verify-machineinstrs` to the tests - that yield two bugs that I had to address: *** Bad machine code: Explicit operand marked as def *** - function:func - basic block: %bb.0 ent

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. Should we still bump `INSTR_PROF_RAW_VERSION ` so that we are able to distinguish profraw files produced by clang13 and the ones produced by clang14 ? Right now, both produce `LLVM raw profile data, version 7` Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM, but the most recent way of implementing this (using target features) was something I suggested to Alexandros based on @ostannard's feedback about LTO. I think it is cleaner, and this pat

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#3001056 , @ye-luo wrote: > 1. modf works now. > > 2. if I modify the complile.sh > > clang++ -fopenmp -fopenmp-targets=nvptx64 -c classA.cpp > rm -f libmylib.a > ar qc libmylib.a classA.o > ranlib libmylib.a >

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

JonChesterfield added a comment. In D105191#3001508 , @saiislam wrote: > PS: We (mulit-company OpenMP-dev meetings) have been tracking this feature > for a while and we would very much like it to be picked for llvm-13. I think llvm-13 is on -final now s

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. > Okay. Sorry if I came down on you personally, I know what it's like to be in > the middle on things like this Thank you, I very much appreciate that. > I'm not sure if there's a way to get LLVM to treat loaded values as only > having N valid bits. > > Do you have

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ created this revision. mubashar_ added a reviewer: MarkMurrayARM. Herald added subscribers: hiraditya, kristof.beyls. mubashar_ requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch enables support for Corte

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372696. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I guess this will prevent member functions in classes being treated as K&R functions right? if thats the case them this LGTM Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:27 +// THINLTO-OLDPM-NOT: PGOIndirectCallPromotion +// THINLTO-OLDPM: Unroll loops +// THINLTO-OLDPM-NOT: Unroll loops When printing out passes wit

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3-4 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. As I did the downstream work for this, I'm happy with it to go in in this form. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10982

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen requested changes to this revision. dmgreen added a comment. This revision now requires changes to proceed. > As I did the downstream work for this, I'm happy with it to go in in this > form. This doesn't seem.. wise. Please make sure the reviews you do are at a sufficient quality, and

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 372698. mubashar_ added a comment. Updated release notes to solve a merge conflict. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst clang/test/Driver/aarch64-cpus.c

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM added a comment. In D109825#3001622 , @dmgreen wrote: >> As I did the downstream work for this, I'm happy with it to go in in this >> form. > > This doesn't seem.. wise. Please make sure the reviews you do are at a > sufficient quality, an

[clang] 274adcb - Implement delimited escape sequences.

Author: Corentin Jabot Date: 2021-09-15T09:54:49-04:00 New Revision: 274adcb866343cb505408d8f401840ea814522c8 URL: https://github.com/llvm/llvm-project/commit/274adcb866343cb505408d8f401840ea814522c8 DIFF: https://github.com/llvm/llvm-project/commit/274adcb866343cb505408d8f401840ea814522c8.diff

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. > The option of adding sm_XX in Bundle Entry ID when user hasn't used -march > flag, comes under command line simplification. I have a bunch of upcoming > patches which will significantly simplify OpenMP command line for GPU > offloading. But, don't you think this featur

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but pls wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llv

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, pengfei. thakis requested review of this revision. D109708 added "DIA SDK" to our win sysroot for hermetic builds that use LLVM_ENABLE_DIA_SDK. But the build system stil

[clang] 1f3925e - [clang][driver][AIX] Add system libc++ header paths to driver

Author: David Tenty Date: 2021-09-15T10:41:18-04:00 New Revision: 1f3925e25ae010c30273501d24b2bd4e0318fe7a URL: https://github.com/llvm/llvm-project/commit/1f3925e25ae010c30273501d24b2bd4e0318fe7a DIFF: https://github.com/llvm/llvm-project/commit/1f3925e25ae010c30273501d24b2bd4e0318fe7a.diff L

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f3925e25ae0: [clang][driver][AIX] Add system libc++ header paths to driver (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109812/new/ https://reviews.llvm.org/D109812 ___ cfe-commits mailing l

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2

[PATCH] D108138: [WIP] Remove switch statements before vectorization

kmclaughlin updated this revision to Diff 372706. kmclaughlin retitled this revision from "[SimplifyCFG] Remove switch statements before vectorization" to "[WIP] Remove switch statements before vectorization". kmclaughlin edited the summary of this revision. kmclaughlin added a comment. Herald add

[PATCH] D108138: [WIP] Remove switch statements before vectorization

kmclaughlin added a comment. Hi all, I've updated this to take a different approach - the new patch runs LowerSwitch just before the vectoriser, where it will only consider simple switches which are part of a loop. For these switches, the pass will create a series of branches and compares which

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372720. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#3001497 , @catenacyber wrote: > Should we still bump `INSTR_PROF_RAW_VERSION ` so that we are able to > distinguish profraw files produced by clang13 and the ones produced by > clang14 ? > > Right now, both produce `

[PATCH] D108138: [WIP] Remove switch statements before vectorization

lebedev.ri added a comment. Hi. I'm personally still not very okay with the approach as it currently is. Do you need to run LoopRotate after lowering switches? Anything else? But then you don't actually know that after spending all this compile time, the vectorization will actually happen, and y

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

This revision was automatically updated to reflect the committed changes. Closed by commit rG210d72e9d6b4: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Gi

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:28 +// The first Unroll loop pass is the createSimpleLoopUnrollPass that unrolls and peels +// loops with small constant trip counts. Only the second one is handled by ThinLTO. +// THIN

[PATCH] D109836: [Analyzer] ConversionChecker: track back the cast expression

martong created this revision. martong added reviewers: steakhal, Szelethus, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this revision. Hera

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 372733. anirudhp added a comment. - Introduce separate label prefix for `MM_GOFF` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 Files: clang/lib/Basic/Targets/Sy

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. In D109362#3001294 , @uweigand wrote: > In D109362#3000284 , @anirudhp > wrote: > >> In D109362#2999688 , @uweigand >> wrote: >> >>> Looking at

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added inline comments. Comment at: llvm/docs/LangRef.rst:2596 * ``e``: ELF mangling: Private symbols get a ``.L`` prefix. +* ``l``: GOFF mangling: Private symbols get a ``.L`` prefix. * ``m``: Mips mangling: Private symbols get a ``$`` prefix. -

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 372736. ZarkoCA added a comment. - Removed llc tests - Added a helper function to combine the PPC64_SVR4ABI and AIXABI treatment of complex types less than register size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 372737. anirudhp added a comment. - Update to the documentation as well in account for the update to the global prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D1093

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

weiwang added a comment. In D109175#2989997 , @yaxunl wrote: > In D109175#2989823 , @weiwang wrote: > >> In D109175#2987048 , @jdoerfert >> wrote: >> >>> In D109175#29867

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added a comment. In D106393#3000122 , @sfertile wrote: > I suggest we separate the clang change and testing into a standalone patch, > and the llvm backend tests into a standalone patch which we can commit > separately. LLVM tests added in http

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175 _

[clang] ab5f2b5 - [HIP] Diagnose -fopenmp-targets for HIP programs

Author: Yaxun (Sam) Liu Date: 2021-09-15T13:03:57-04:00 New Revision: ab5f2b505a0751bce41f4cec9afa3c1541d485d0 URL: https://github.com/llvm/llvm-project/commit/ab5f2b505a0751bce41f4cec9afa3c1541d485d0 DIFF: https://github.com/llvm/llvm-project/commit/ab5f2b505a0751bce41f4cec9afa3c1541d485d0.dif

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab5f2b505a07: [HIP] Diagnose -fopenmp-targets for HIP programs (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand accepted this revision. uweigand added a comment. This LGTM now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mailing list cfe-commi

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1423-1426 +ObjCMethodList InstanceMethods; +ObjCMethodList FactoryMethods; +llvm::DenseSet AddedInstanceMethods; +llvm::DenseSet AddedFactoryMethods; Do these two sets r

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372748. csmulhern retitled this revision from "Adds an AlignCloseBracket option" to "Adds a BreakBeforeClosingParen option". csmulhern edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372749. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files: clang/test/CodeGen/pgo-

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3000152 , @HazardyKnusperkeks wrote: > I haven't looked too much into it, my main point is that there should be > tests for both variants of that option for braces, parenthesis, and angular > braces, if they are ha

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl added a comment. In D103835#3001011 , @rjmccall wrote: > Hmm. I think "v-tables are in the address space of the object pointer" is > not a good assumption. Probably this ought to be determined by the C++ ABI > for the target. In principle it

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

hans added a comment. The /winsysroot part makes sense to me, but what's the case for the new /diasdkdir flag? Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:66 +static const char *llvmArchToLegacyVCArch(llvm::Triple::ArchType Arch); + Maybe move the arch

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

rjmccall added a comment. I see. Yes, in that case, that sounds right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103835/new/ https://reviews.llvm.org/D103835 ___ cfe-commits mailing list cfe-commits

[PATCH] D109841: Fix vtbl field addr space

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, arichardson. yaxunl requested review of this revision. vtbl filed of an object should have same addr space of the object. Currently it is assumed to be addr space 0 but this may not be true. This caused issue for some out of tree

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin planned changes to this revision. cor3ntin added a comment. I'll fix the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 ___ cfe-commits mailing

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl added a comment. https://reviews.llvm.org/D109841 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103835/new/ https://reviews.llvm.org/D103835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109841: Fix vtbl field addr space

rjmccall added a comment. The following line is always just making a bitcast, then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D109557: Adds a BreakBeforeClosingParen option

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22301 + auto Style = getLLVMStyle(); + Style.BreakBeforeClosingParen = true; + Could you also add tests for `false`, even though they are spread over the other test cas

[PATCH] D108469: Improve handling of static assert messages.

aaron.ballman added a comment. In D108469#2957652 , @jfb wrote: > I worry that changing the general `static_assert` printing (adding a colon, > and dropping the quotes) will get @hwright's law to drop on us. We can try > and see if e.g. users of clang h

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372766. gAlfonso-bit added a comment. git-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. @dgoldman I did it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @Mordante Alfonso Gregory gfunni...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 372770. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/Compile

[PATCH] D109841: Fix vtbl field addr space

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Thanks, I can confirm that this fixes the assertions we were seeing after merging D103835 . A few minor suggestions below: There's a typo in the co

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis updated this revision to Diff 372782. thakis marked an inline comment as done. thakis added a comment. move arch functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109828/new/ https://reviews.llvm.org/D109828 Files: clang/include/clang/Driver/Options.td clang/lib/Driver

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

sfertile accepted this revision as: sfertile. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emi

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis added a comment. In D109828#3002114 , @hans wrote: > The /winsysroot part makes sense to me, but what's the case for the new > /diasdkdir flag? - If you do have a vcvars shell, you don't need the full sysroot path and it's kind of useful (see

[PATCH] D109841: Fix vtbl field addr space

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D109841#3002404 , @arichardson wrote: > Thanks, I can confirm that this fixes the assertions we were seeing after > merging D103835 . A few minor sugge

[clang] 40acc0a - Improve type printing of size-dependent const arrays to normalize array-of-const and const-array

Author: David Blaikie Date: 2021-09-15T13:46:37-07:00 New Revision: 40acc0adad59ac39e9a7a02fcd93161298500c00 URL: https://github.com/llvm/llvm-project/commit/40acc0adad59ac39e9a7a02fcd93161298500c00 DIFF: https://github.com/llvm/llvm-project/commit/40acc0adad59ac39e9a7a02fcd93161298500c00.diff

[PATCH] D109841: Fix vtbl field addr space

yaxunl updated this revision to Diff 372792. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: jrtc27. fix comments and casts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 Files: clang/lib/CodeG

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Tue, Sep 14, 2021 at 10:04 AM Richard Smith wrote: > On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: David Blaikie >> Date: 2021-09-13T19:17:05-07:00 >> New Revision: 2bd84938470bf2e337801faafb8a67710f46429d >> >> URL: >> http

[clang-tools-extra] d249200 - Revert "Re-Revert "clang-tidy: introduce readability-containter-data-pointer check""

Author: Saleem Abdulrasool Date: 2021-09-15T20:52:55Z New Revision: d249200fa7d540fb0b3ddc065575293e1da11107 URL: https://github.com/llvm/llvm-project/commit/d249200fa7d540fb0b3ddc065575293e1da11107 DIFF: https://github.com/llvm/llvm-project/commit/d249200fa7d540fb0b3ddc065575293e1da11107.diff

[clang] 8264846 - Senticify some comments - post-commit review for e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e

Author: David Blaikie Date: 2021-09-15T13:59:11-07:00 New Revision: 8264846c0ef847adeacca9b8fe0f867a8a378c5e URL: https://github.com/llvm/llvm-project/commit/8264846c0ef847adeacca9b8fe0f867a8a378c5e DIFF: https://github.com/llvm/llvm-project/commit/8264846c0ef847adeacca9b8fe0f867a8a378c5e.diff

  1   2   >