hans added a comment. The /winsysroot part makes sense to me, but what's the case for the new /diasdkdir flag?
================ Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:66 +static const char *llvmArchToLegacyVCArch(llvm::Triple::ArchType Arch); + ---------------- Maybe move the arch functions up to before visualstudio::Linker::ConstructJob instead? The file is already kind of organized in that way, with lots of static helper functions on top, and then the implementations of the member functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109828/new/ https://reviews.llvm.org/D109828 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
