thakis added a comment. In D109828#3002114 <https://reviews.llvm.org/D109828#3002114>, @hans wrote:
> The /winsysroot part makes sense to me, but what's the case for the new > /diasdkdir flag? - If you do have a vcvars shell, you don't need the full sysroot path and it's kind of useful (see example in commit message) - it seems nice to be able to explain /winsysroot as combination of other flags in the help text - it makes writing the test a bit easier - it makes diasdkdir more like the other flags controlled by /winsysroot ================ Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:66 +static const char *llvmArchToLegacyVCArch(llvm::Triple::ArchType Arch); + ---------------- hans wrote: > Maybe move the arch functions up to before visualstudio::Linker::ConstructJob > instead? > > The file is already kind of organized in that way, with lots of static helper > functions on top, and then the implementations of the member functions. Sure, done. The file has a bunch of other static functions all over the place too though :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109828/new/ https://reviews.llvm.org/D109828 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
