csmulhern added a comment. In D109557#3000152 <https://reviews.llvm.org/D109557#3000152>, @HazardyKnusperkeks wrote:
> I haven't looked too much into it, my main point is that there should be > tests for both variants of that option for braces, parenthesis, and angular > braces, if they are handled by that option. Otherwise the documentation (and > naming?) should be adapted. If the defaults differ, the option has to be > reworked, for a finer control. I went ahead and limited this in scope to explicitly only deal with closing parentheses. > In D109557#2999085 <https://reviews.llvm.org/D109557#2999085>, > @MyDeveloperDay wrote: > >> This isn't really `AlignCloseBracket` but `BreakBeforeClosingParen` isn't it? > > Yeah I thought that too. Good call. I've renamed the option to BreakBeforeClosingParen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
