[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

leonardchan added a comment. In D84202#2179618 , @aaron.ballman wrote: >> users can still disable the warning on line granularity with pragmas. > > This makes me a bit uncomfortable because those pragmas extremely ugly (and > not easily portable). Also,

[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

aaron.ballman added a comment. In D84202#2179718 , @leonardchan wrote: > In D84202#2179618 , @aaron.ballman > wrote: > >>> users can still disable the warning on line granularity with pragmas. >> >> This makes me a

[PATCH] D83592: [Coverage] Add comment to skipped regions

vsk added a comment. @zequanwu the change that dropped merging of adjacent comments looks good. If no further issues cropped up during stage2 testing, please feel free to re-land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 ___

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny updated this revision to Diff 281330. jdenny added a comment. Replaced `SeparateBeginEnd` parameter with new `TargetDataInfo` field as requested. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84422/new/ https://reviews.llvm.org/D84422 Files: clang/lib/CodeGen/CGOpen

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

ye-luo requested changes to this revision. ye-luo added a comment. This revision now requires changes to proceed. Please check the reproducer in https://bugs.llvm.org/show_bug.cgi?id=46868 with LIBOMPTARGET_DEBUG=1. The reference counting on the base pointer variable has side effects. It was not

[PATCH] D84710: [OpenMP][NFC] Consolidate `to` and `from` clause modifiers

jdenny added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84710/new/ https://reviews.llvm.org/D84710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3462 + // OpenMP 5.1 accepts an optional ',' even if the next character is ':'. + // TODO: Is that intentional? + if (Tok.is(tok::comma)) ABataev wrote: > `FIXME`. This is a

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3462 + // OpenMP 5.1 accepts an optional ',' even if the next character is ':'. + // TODO: Is that intentional? + if (Tok.is(tok::comma)) jdenny wrote: > ABataev wrote: > >

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

NoQ added a comment. I think the overall idea is correct. Yup, the patch will need the new positive tests that started passing. If you can't demonstrate it with integration tests you should do unit tests because the contract you're trying to achieve is fairly clear and obviously correct and it

[PATCH] D84794: Mark override to a function which overrides a virtual one

anhtuyen created this revision. anhtuyen added reviewers: kbobyrev, bkramer, sammccall, logan-5. anhtuyen added a project: LLVM. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. anhtuyen requested review of this revision. Function **void

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny updated this revision to Diff 281339. jdenny marked 4 inline comments as done. jdenny added a comment. Adjusted logic for rejecting `present` as requested. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 Files: clang/include/c

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:73-74 .Default(OMPC_MOTION_MODIFIER_unknown); +if (OpenMPVersion < 51 && Type != OMPC_MOTION_MODIFIER_mapper) + return OMPC_MOTION_MODIFIER_unknown; +return Type; ABat

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil updated this revision to Diff 281341. bsaleil added a comment. Update diff so it can be applied to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 Files: clang/include/clang/Driver/Options.

[PATCH] D84473: Dump Accumulator

kazu added a comment. In D84473#2178167 , @jhenderson wrote: > Could the llvm-readobj bit be spun off into a separate review, please. As > things stand it doesn't have any of its own testing, which should be added at > the same time as adding support in

[clang] b46176b - Reland [Coverage] Add comment to skipped regions

Author: Zequan Wu Date: 2020-07-28T13:20:57-07:00 New Revision: b46176bbb094610460667edad950a9c99f844118 URL: https://github.com/llvm/llvm-project/commit/b46176bbb094610460667edad950a9c99f844118 DIFF: https://github.com/llvm/llvm-project/commit/b46176bbb094610460667edad950a9c99f844118.diff LOG

[PATCH] D83592: [Coverage] Add comment to skipped regions

This revision was automatically updated to reflect the committed changes. Closed by commit rGb46176bbb094: Reland [Coverage] Add comment to skipped regions (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://revi

[PATCH] D84473: Dump Accumulator

kazu updated this revision to Diff 281344. kazu added a comment. Spun off the llvm-readobj bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm

[clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

Author: Richard Smith Date: 2020-07-28T13:23:13-07:00 New Revision: 740a164dec483225cbd02ab6c82199e2747ffacb URL: https://github.com/llvm/llvm-project/commit/740a164dec483225cbd02ab6c82199e2747ffacb DIFF: https://github.com/llvm/llvm-project/commit/740a164dec483225cbd02ab6c82199e2747ffacb.diff

[clang] 389f009 - [NFC] Sema: use checkArgCount instead of custom checking

Author: JF Bastien Date: 2020-07-28T13:41:06-07:00 New Revision: 389f009c5757cf09c0b2d77a15b3b541fb0f2a1c URL: https://github.com/llvm/llvm-project/commit/389f009c5757cf09c0b2d77a15b3b541fb0f2a1c DIFF: https://github.com/llvm/llvm-project/commit/389f009c5757cf09c0b2d77a15b3b541fb0f2a1c.diff LO

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D84666: [NFC] Sema: use checkArgCount instead of custom checking

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG389f009c5757: [NFC] Sema: use checkArgCount instead of custom checking (authored by jfb). Repository: rG LLVM Github Mo

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8843 llvm::Value *&MapTypesArrayArg, llvm::Value *&MappersArrayArg, -CGOpenMPRuntime::TargetDataInfo &Info) { +CGOpenMPRuntime::TargetDataInfo &Info, bool ForEndCall = false) { + assert

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8843 llvm::Value *&MapTypesArrayArg, llvm::Value *&MappersArrayArg, -CGOpenMPRuntime::TargetDataInfo &Info) { +CGOpenMPRuntime::TargetDataInfo &In

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

steakhal planned changes to this revision. steakhal added a comment. Thank you all for the comments. In D84736#2179828 , @NoQ wrote: > I think the overall idea is correct. So I will keep going in this direction, you can expect the more complex version o

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi updated this revision to Diff 281364. yamauchi added a comment. Herald added subscribers: cfe-commits, dexonsmith, steven_wu. Herald added a project: clang. Use JamCRC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://revie

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:642 // Hash format for context sensitive profile. Reserve 4 bits for other // information. davidxl wrote: > The comment looks stale. I think the 4 bits

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:623 // Compute Hash value for the CFG: the lower 32 bits are CRC32 of the index -// value of each BB in the CFG. The higher 32 bits record the number of edges. +// value of each

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

ABataev updated this revision to Diff 281369. ABataev added a comment. Fixed ref count for base pointer + extra test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/ https://reviews.llvm.org/D84767 Files: clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:623 // Compute Hash value for the CFG: the lower 32 bits are CRC32 of the index -// value of each BB in the CFG. The higher 32 bits record the number of edges. +// value of eac

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:660 // information. - FunctionHash = (uint64_t)SIVisitor.getNumOfSelectInsts() << 56 | - (uint64_t)ValueSites[IPVK_IndirectCallTarget].size() << 48 | -

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

davidxl added a comment. We may also need to bump both the raw and index format version with this change. For the profile use side, we also need to keep the hashing scheme of the older version (in profile-use side). More details to come. Many tests can also be enhanced to filter out the hash d

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

riccibruno updated this revision to Diff 281371. riccibruno edited the summary of this revision. riccibruno added a comment. Use a less generic name instead of `get{Open,Close}Delimiter`. I went with `get{Open,Close}DelimiterForUnnamedEntity` but I am happy to change it. Repository: rG LLVM G

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

riccibruno updated this revision to Diff 281373. riccibruno added a comment. Add the forgotten context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84658/new/ https://reviews.llvm.org/D84658 Files: clang/include/clang/AST/Decl.h clang/includ

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

dsanders updated this revision to Diff 281376. dsanders added a comment. Remove external- prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84572/new/ https://reviews.llvm.org/D84572 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

ye-luo added a comment. This patch GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms [CUDA memcpy HtoD] before the July21 change GPU activities: 95.33% 20.317ms 4 5.0793ms 1.6000us 20.305ms [CUDA memcpy HtoD] Still more transfer than it should. Reposito

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 281377. zzheng added a comment. rebased.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.org/D84414 Files: clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolChain.cpp

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

bsaleil updated this revision to Diff 281381. bsaleil added a comment. Update diff so it can be applied to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81442/new/ https://reviews.llvm.org/D81442 Files: clang/include/clang/Driver/Options

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

asbirlea updated this revision to Diff 281382. asbirlea added a comment. Renamed ChildrenGet to getChildren. The same name only exists in GraphDiff, it's ok to keep a consistent naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/ http

[clang] e22de4e - [DominatorTree] Simplify ChildrenGetter.

Author: Alina Sbirlea Date: 2020-07-28T15:44:20-07:00 New Revision: e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c URL: https://github.com/llvm/llvm-project/commit/e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c DIFF: https://github.com/llvm/llvm-project/commit/e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c.diff

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe22de4e46d1d: [DominatorTree] Simplify ChildrenGetter. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 9cf98d2 - PR46637: Fix handling of placeholder types in trailing-return-types.

Author: Richard Smith Date: 2020-07-28T15:54:10-07:00 New Revision: 9cf98d26e7b1204478cc13ae3df44a6843965c11 URL: https://github.com/llvm/llvm-project/commit/9cf98d26e7b1204478cc13ae3df44a6843965c11 DIFF: https://github.com/llvm/llvm-project/commit/9cf98d26e7b1204478cc13ae3df44a6843965c11.diff

[PATCH] D84794: Mark override to a function which overrides a virtual one

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84794/new/ https://reviews.llvm.org/D84794 __

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

ychen updated this revision to Diff 281395. ychen added a comment. - Add `-debug-pass-manager-verbose` to print adaptor passes. (test case in pass-pipeline-parsing.ll where we could ask for adaptor pass from `-passes`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

vsk added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:4359 + /// condition (i.e. no "&&" or "||"). + static bool isLeafCondition(const Expr *C); + alanphipps wrote: > vsk wrote: > > vsk wrote: > > > It might be helpful to either require tha

[clang] 80bd6ae - On Windows build, making the /bigobj flag global , instead of passing it per file.

Author: Zahira Ammarguellat Date: 2020-07-28T18:04:36-05:00 New Revision: 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 URL: https://github.com/llvm/llvm-project/commit/80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 DIFF: https://github.com/llvm/llvm-project/commit/80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0

[PATCH] D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.

This revision was automatically updated to reflect the committed changes. Closed by commit rG80bd6ae13ea2: On Windows build, making the /bigobj flag global , instead of passing it per… (authored by zahiraam, committed by Meinersbur). Herald added projects: clang, LLDB. Herald added subscribers: l

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

vsk added a comment. I haven't taken a close look at the tests yet, but plan on getting to it soon. I'm not sure whether this is something you've already tried, but for this kind of change, it can be helpful to verify that a stage2 clang self-host with assertions enabled completes successfully.

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

ychen updated this revision to Diff 281399. ychen added a comment. - Update `-debug-pass-manager-verbose` test. Some output should be ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84774/new/ https://reviews.llvm.org/D84774 Files: clang/

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

ye-luo added a comment. In D84767#2180280 , @ye-luo wrote: > This patch > GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms > [CUDA memcpy HtoD] > before the July21 change > GPU activities: 95.33% 20.317ms 4 5.0793ms

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

davidxl added a comment. On version bump --- looks like FrontPGO has been bumping version for hashing changes while IR PGO had not, so it is ok to leave the version unchanged (current situation is also confusing as the version of IR and FE PGO are mixed). On the other hand, just in case, we nee

[PATCH] D84710: [OpenMP][NFC] Consolidate `to` and `from` clause modifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3d1f88fa7da: [OpenMP][NFC] Consolidate `to` and `from` clause modifiers (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a3d1f88 - [OpenMP][NFC] Consolidate `to` and `from` clause modifiers

Author: Joel E. Denny Date: 2020-07-28T19:15:18-04:00 New Revision: a3d1f88fa7da3dfc0b4319f2e4eb7374fa60b819 URL: https://github.com/llvm/llvm-project/commit/a3d1f88fa7da3dfc0b4319f2e4eb7374fa60b819 DIFF: https://github.com/llvm/llvm-project/commit/a3d1f88fa7da3dfc0b4319f2e4eb7374fa60b819.diff

[clang] 3c3faae - [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

Author: Joel E. Denny Date: 2020-07-28T19:15:18-04:00 New Revision: 3c3faae497046be706df29e16c9fbccb7e1fce09 URL: https://github.com/llvm/llvm-project/commit/3c3faae497046be706df29e16c9fbccb7e1fce09 DIFF: https://github.com/llvm/llvm-project/commit/3c3faae497046be706df29e16c9fbccb7e1fce09.diff

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c3faae49704: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2) (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:116-121 + unsigned Priority = 0; for (ClangTidyModuleRegistry::iterator I = ClangTidyModuleRegistry::begin(), E = ClangTidyModuleRegistry::e

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi updated this revision to Diff 281407. yamauchi added a comment. Shift the higher 32 bits by 28 bits and add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files: clang/test/CodeGen/Inputs/thinl

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. > Many tests can also be enhanced to filter out the hash details if they are > not part the main test. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 _

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

NoQ added a comment. Whoops, i meant to post the comment in https://reviews.llvm.org/rG22a084cfa337d5e5ea90eba5261f7937e28d250b#937772 here. Anyway, i found a crash caused by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new/ ht

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

jroelofs added subscribers: dcoughlin, jroelofs. jroelofs added inline comments. Herald added subscribers: ASDenysPetrov, martong. Comment at: clang/test/Analysis/fuchsia_handle.cpp:80 + zx_status_t status = zx_channel_create(0, &sa, &sb); + // expected-note@-1 {{Handle allocat

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

jroelofs added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:80 + zx_status_t status = zx_channel_create(0, &sa, &sb); + // expected-note@-1 {{Handle allocated through 2nd parameter}} + if (status == 0) { // expected-note {{Assuming 'status' is equal to 0

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is useful for the remote index:

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev updated this revision to Diff 281416. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84697/new/ https://reviews.llvm.org/D84697 Files: clang

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi updated this revision to Diff 281417. yamauchi added a comment. Add a flag to back out to the old hashing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files: clang/test/CodeGen/Inputs/thinlto

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. In D84782#2180432 , @davidxl wrote: > On version bump --- looks like FrontPGO has been bumping version for hashing > changes while IR PGO had not, so it is ok to leave the version unchanged > (current situation is also confusing

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 updated this revision to Diff 281418. njames93 marked 2 inline comments as done. njames93 added a comment. Remove unreachable after switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82898/new/ https://reviews.llvm.org/D82898 Files: c

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:629 Priority = std::make_tuple(Begin, Type, -End, -ErrorSize, ErrorId); - else +return; + case ET_Insert: aaron.ballman wrote: > I'

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar updated this revision to Diff 281419. tstellar added a comment. Add volatile test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/buil

[clang-tools-extra] fb22678 - [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

Author: Kirill Bobyrev Date: 2020-07-29T01:48:24+02:00 New Revision: fb22678cd67801e41af4917acceb4014ab5d007e URL: https://github.com/llvm/llvm-project/commit/fb22678cd67801e41af4917acceb4014ab5d007e DIFF: https://github.com/llvm/llvm-project/commit/fb22678cd67801e41af4917acceb4014ab5d007e.diff

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb22678cd678: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: clang/test/CodeGen/builtins-overflow.c:123 + // CHECK: br i1 [[C2]] + int r; + if (__builtin_mul_overflow(x, y, &r)) vsk wrote: > vsk wrote: > > Could you add a test for the

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

davidxl added a comment. Can you split out the test changes and commit it separately? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 ___ cfe-commits mailing list

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

vitalybuka added a comment. LGTM as it fixes update_cc_test_checks.py Comment at: llvm/utils/update_cc_test_checks.py:116-126 +def infer_dependent_args(args): + if args.clang is None: +if args.llvm_bin is None: + args.clang = 'clang' +else: + args.clang = os.

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

vitalybuka added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# works as expected +config.substitutions.append( +('%update_cc_test_checks_llvm_bin', "%s %s %s" % ( arichardson wrote: > MaskRay wrote: > > The substituti

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

MaskRay accepted this revision. MaskRay added a comment. LGTM. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# works as expected +config.substitutions.append( +('%update_cc_test_checks_llvm_bin', "%s %s %s" % ( vitalybuka wrote: > ari

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi updated this revision to Diff 281426. yamauchi added a comment. Rebase (converting one more test) and fixing a typo and whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files: clang/te

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. In D84782#2180578 , @davidxl wrote: > Can you split out the test changes and commit it separately? How exactly? Do you mean commit the non-test part without flipping the flag and then flip it with the test changes? Repository:

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

davidxl added a comment. changes like in llvm/test/Transforms/PGOProfile/PR41279.ll etc can be independently committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 _

[clang] 69fc33f - Revert "[OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)"

Author: Joel E. Denny Date: 2020-07-28T20:30:05-04:00 New Revision: 69fc33f0cd130b02a38d2fc582afc7b0fcd6458a URL: https://github.com/llvm/llvm-project/commit/69fc33f0cd130b02a38d2fc582afc7b0fcd6458a DIFF: https://github.com/llvm/llvm-project/commit/69fc33f0cd130b02a38d2fc582afc7b0fcd6458a.diff

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8055 for (const auto L : C->component_lists()) { -InfoGen(std::get<0>(L), std::get<1>(L), OMPC_MAP_to, llvm::None, +SmallVector MapModifiers; +translateMotionModifiers(C

[PATCH] D84812: [clang-tidy][NFC] Added convienence methods for getting optional options

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Herald added a subscriber: aheejin. These methods abstract away Error handling when tryi

[PATCH] D84812: [clang-tidy][NFC] Added convienence methods for getting optional options

njames93 updated this revision to Diff 281433. njames93 added a comment. Fix wrong patch diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84812/new/ https://reviews.llvm.org/D84812 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Herald added a subscriber: aheejin. When checking for the style of a decl that i

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

njames93 updated this revision to Diff 281439. njames93 added a comment. Add missing new lines in test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84814/new/ https://reviews.llvm.org/D84814 Files: clang-tools-extra/clang-tidy/readabilit

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + aheejin wrote: > It'd be clearer to say starting indices of these don't start with 0 or > [lanecoun

[clang] 11bb7ee - [WebAssembly] Remove intrinsics for SIMD widening ops

Author: Thomas Lively Date: 2020-07-28T18:25:55-07:00 New Revision: 11bb7eef4152cab895983f19e638f0cfdf8a580f URL: https://github.com/llvm/llvm-project/commit/11bb7eef4152cab895983f19e638f0cfdf8a580f DIFF: https://github.com/llvm/llvm-project/commit/11bb7eef4152cab895983f19e638f0cfdf8a580f.diff

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11bb7eef4152: [WebAssembly] Remove intrinsics for SIMD widening ops (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D8455

[PATCH] D84622: [PowerPC] Implement Vector Extract Low/High Order Builtins in LLVM/Clang

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM. But please hold on for one more days to see if there is other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84622/new

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:80 + zx_status_t status = zx_channel_create(0, &sa, &sb); + // expected-note@-1 {{Handle allocated through 2nd parameter}} + if (status == 0) { // expected-note {{Assuming 'status' is equal to 0}} --

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + tlively wrote: > aheejin wrote: > > It'd be clearer to say starting indices of these don't start wit

[clang] c26f237 - [analyzer] FuchsiaHandleChecker: Suppress a non-deterministic test failure.

Author: Artem Dergachev Date: 2020-07-28T18:57:11-07:00 New Revision: c26f237cef1b33277f072c609c19192c5213f348 URL: https://github.com/llvm/llvm-project/commit/c26f237cef1b33277f072c609c19192c5213f348 DIFF: https://github.com/llvm/llvm-project/commit/c26f237cef1b33277f072c609c19192c5213f348.dif

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:80 + zx_status_t status = zx_channel_create(0, &sa, &sb); + // expected-note@-1 {{Handle allocated through 2nd parameter}} + if (status == 0) { // expected-note {{Assuming 'status' is equal to 0}} --

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

NoQ added a comment. > `BuiltinBug` is deprecated and we should be using `BugType` anyway Like, i've never heard of `BuiltinBug` being deprecated but i'm pretty happy that it gets removed :) Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:215 // The ex

[clang] d352705 - [NFC] Edit the comment for the return type of await_suspend

Author: Chuanqi Xu Date: 2020-07-29T10:20:55+08:00 New Revision: d3527052fc2a952d752f82ffbe39220bad33fc8d URL: https://github.com/llvm/llvm-project/commit/d3527052fc2a952d752f82ffbe39220bad33fc8d DIFF: https://github.com/llvm/llvm-project/commit/d3527052fc2a952d752f82ffbe39220bad33fc8d.diff LO

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + aheejin wrote: > tlively wrote: > > aheejin wrote: > > > It'd be clearer to say starting indices of

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + tlively wrote: > aheejin wrote: > > tlively wrote: > > > aheejin wrote: > > > > It'd be clearer to s

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. Specified in https://github.com/WebAssembly/

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl added a comment. @tra target ID documentation is added by https://reviews.llvm.org/D84822 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. Fixed by 6a75496836ea14bcfd2f4b59d35a1cad4ac58cee :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 _

<    1   2   3   >