jdenny marked an inline comment as done.
jdenny added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8843
llvm::Value *&MapTypesArrayArg, llvm::Value *&MappersArrayArg,
- CGOpenMPRuntime::TargetDataInfo &Info) {
+ CGOpenMPRuntime::TargetDataInfo &Info, bool ForEndCall = false) {
+ assert((!ForEndCall || Info.separateBeginEndCalls()) &&
----------------
ABataev wrote:
> Do not append param here, use the one from `Info`
`Info.SeparateBeginEndCalls` and `ForEndCall` do not represent the same thing.
If `Info.SeparateBeginEndCalls=true`, as in `emitTargetDataCalls` below, then
`emitOffloadingArraysArgument` is called twice with the same `Info`, once with
`ForEndCall=false` and once with `ForEndCall=true`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84422/new/
https://reviews.llvm.org/D84422
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
