tlively added inline comments.

================
Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113
+
+;; Also test that similar patterns are still expanded correctly
+
----------------
aheejin wrote:
> It'd be clearer to say starting indices of these don't start with 0 or 
> [lanecount - 1] so they can't be widened using `widen_low` or `widen_high` 
> instructions.
> 
> Question: Can we also widen these using shifts?
Sure, since I didn't end up testing more patterns, I can make the comment more 
specific.

Regarding shifts, I don't think it's possible to do widening with shifts 
because widening has to fundamentally change the number of lanes, which shifts 
can't do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84556/new/

https://reviews.llvm.org/D84556

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to