ABataev added inline comments.
================ Comment at: clang/lib/Parse/ParseOpenMP.cpp:3462 + // OpenMP 5.1 accepts an optional ',' even if the next character is ':'. + // TODO: Is that intentional? + if (Tok.is(tok::comma)) ---------------- jdenny wrote: > ABataev wrote: > > `FIXME`. This is a bug. > I think you mean: > > * It's a bug in TR8. > * I should change TODO to FIXME. > * This patch implements and tests the TR8 bug, and I should leave it that way > for now. > > Is all that right? Ah, I misread your comment here. I thought it is a bug in a compiler. Then just leave it as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
