[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom updated this revision to Diff 206593. jvikstrom marked 24 inline comments as done. jvikstrom added a comment. Fixed a bunch of small comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63559/new/ https://reviews.llvm.org/D63559 Files

[PATCH] D63194: [clangd] Link and initialize target infos

kadircet updated this revision to Diff 206598. kadircet marked an inline comment as done. kadircet added a comment. - revert leftover change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 Files: clang-to

r364386 - [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

Author: kadircet Date: Wed Jun 26 00:39:03 2019 New Revision: 364386 URL: http://llvm.org/viewvc/llvm-project?rev=364386&view=rev Log: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase Summary: Wraps JSON compilation database with a target and mode adding dat

[clang-tools-extra] r364387 - [clangd] Link and initialize target infos

Author: kadircet Date: Wed Jun 26 00:39:14 2019 New Revision: 364387 URL: http://llvm.org/viewvc/llvm-project?rev=364387&view=rev Log: [clangd] Link and initialize target infos Added: clang-tools-extra/trunk/clangd/test/target_info.test Modified: clang-tools-extra/trunk/clangd/CMakeLists.

[PATCH] D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rL364386: [clang][Tooling] Infer target and mode from argv[0] when using… (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[clang-tools-extra] r364389 - [clangd] Enable extraction of system includes from custom toolchains

Author: kadircet Date: Wed Jun 26 00:45:27 2019 New Revision: 364389 URL: http://llvm.org/viewvc/llvm-project?rev=364389&view=rev Log: [clangd] Enable extraction of system includes from custom toolchains Summary: Some custom toolchains come with their own header files and compiler drivers. Those

[PATCH] D63194: [clangd] Link and initialize target infos

kadircet closed this revision. kadircet added a comment. Landed as rL364387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

This revision was automatically updated to reflect the committed changes. Closed by commit rL364389: [clangd] Enable extraction of system includes from custom toolchains (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r364390 - [clangd] Add Value field to HoverInfo

Author: kadircet Date: Wed Jun 26 01:00:24 2019 New Revision: 364390 URL: http://llvm.org/viewvc/llvm-project?rev=364390&view=rev Log: [clangd] Add Value field to HoverInfo Summary: Put a symbols value information which is deduced from initializer expression into HoverInfo struct. Reviewers: sam

[PATCH] D63330: [clangd] Add Value field to HoverInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL364390: [clangd] Add Value field to HoverInfo (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlight.cpp:28 + : Ctx(AST.getASTContext()), SM(AST.getSourceManager()) { +Ctx.setTraversalScope(AST.getLocalTopLevelDecls()); + } hokein wrote: > I'd move this line to `col

[clang-tools-extra] r364392 - [clangd] Don't rename the namespace.

Author: hokein Date: Wed Jun 26 01:10:26 2019 New Revision: 364392 URL: http://llvm.org/viewvc/llvm-project?rev=364392&view=rev Log: [clangd] Don't rename the namespace. Summary: Also fix a small bug -- the extra argument "-xc++" doesn't overwrite the language if the argument is present after the

[PATCH] D63759: [clangd] Don't rename the namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364392: [clangd] Don't rename the namespace. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham marked 3 inline comments as done. simon_tatham added inline comments. Comment at: cfe/trunk/lib/Basic/Targets/ARM.cpp:912 + return true; +} case 'U': // a memory reference... craig.topper wrote: > Is this supposed to fallthrough from 'T'

r364396 - [clang][Tooling] Fix windows build-bots after rL364386

Author: kadircet Date: Wed Jun 26 01:39:42 2019 New Revision: 364396 URL: http://llvm.org/viewvc/llvm-project?rev=364396&view=rev Log: [clang][Tooling] Fix windows build-bots after rL364386 Modified: cfe/trunk/unittests/Tooling/CompilationDatabaseTest.cpp Modified: cfe/trunk/unittests/Toolin

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

hokein added a comment. much clearer now, a few more nits. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:69 bool HandleTopLevelDecl(DeclGroupRef DG) override { +//FIXME: There is an edge case where this will still get decls from include files. for (Decl *D :

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom updated this revision to Diff 206618. jvikstrom marked 11 inline comments as done. jvikstrom added a comment. - [clangd] Added functionality for getting semantic highlights for variable and function declarations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightTests.cpp:47 +TEST(SemanticTokenCollector, GetsCorrectTokens) { + const char *TestCases[] = { + R"cpp( hokein wrote: > the code seems not clang-format, could yo

[PATCH] D58033: Add option for emitting dbg info for call site parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL364399: [CC1Option] Add the option to enable the debug entry values (authored by djtodoro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. @dexonsmith ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp:49 +diag(OperatorLoc, "POSIX functions (except posix_openpt) never return negative values") +<< FixItHint::CreateReplacement(OperatorLoc, Twine(">").str()); +r

[PATCH] D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63784/new/ https://reviews.llvm.org/D63784

[PATCH] D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.

gribozavr accepted this revision. gribozavr added a comment. Good catch! Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h:48 + +template class TestClangTidyAction : public ASTFrontendAction { "CheckTypes"? 'cause "Checks" below is also tech

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:69 + +// A trivial rewrite rule generator that requires ObjectiveC code. +Optional needsObjC(const LangOptions &LangOpts, -

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:54 + +// RAV subclass to find all DeclRefs in a given Stmt +class FindDeclRefsVisitor I believe this class is rather used to check if any decl referenced in a

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

hokein added a comment. thanks mostly good. Thinking more about the name, we should align with the LSP proposal, see my comments inline. Comment at: clang-tools-extra/clangd/SemanticHighlight.cpp:20 +// Collects all semantic tokens in an ASTContext. +class SemanticTokenCollect

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlight.h:17 + +enum class SemanticHighlightKind { + Variable, hokein wrote: > LSP proposal is using `Highlighting` rather than `Highlight

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlight.h:17 + +enum class SemanticHighlightKind { + Variable, jvikstrom wrote: > hokein wrote: > > LSP proposal is using `Highlighting` rather than `Highlight`, let's align > > with t

[clang-tools-extra] r364413 - [clangd] Disable failing unittest on non-x86 platforms

Author: kadircet Date: Wed Jun 26 04:52:20 2019 New Revision: 364413 URL: http://llvm.org/viewvc/llvm-project?rev=364413&view=rev Log: [clangd] Disable failing unittest on non-x86 platforms Modified: clang-tools-extra/trunk/clangd/test/target_info.test Modified: clang-tools-extra/trunk/clang

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom updated this revision to Diff 206630. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Renamed types to follow LSP. Also renamed files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63559/new/ https://reviews.llvm.or

r364399 - [CC1Option] Add the option to enable the debug entry values

Author: djtodoro Date: Wed Jun 26 02:38:09 2019 New Revision: 364399 URL: http://llvm.org/viewvc/llvm-project?rev=364399&view=rev Log: [CC1Option] Add the option to enable the debug entry values The option enables debug info about parameter's entry values. The example of using the option: clang

r364402 - [clang] Fix test failures after the rL364399

Author: djtodoro Date: Wed Jun 26 03:23:25 2019 New Revision: 364402 URL: http://llvm.org/viewvc/llvm-project?rev=364402&view=rev Log: [clang] Fix test failures after the rL364399 Modified: cfe/trunk/test/CodeGenCXX/dbg-info-all-calls-described.cpp Modified: cfe/trunk/test/CodeGenCXX/dbg-inf

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1 +//==- SemanticHighlightingTest.cpp - SemanticHighlightTest tests-*- C++ -*

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:808 +if(NOT llvm-pass-plugins) +# Target used to hold global properties referencable from generator-expression [serious] I get the following error: ``` CMake Error at cmake/modu

[PATCH] D63817: [clangd] No longer getting template instantiations from header files in Main AST.Added another check to DeclTrackingASTConsumer to check that a Decl is actually in the main file.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. [clangd] No longer getting template instantiations from header files in Main AST. Repository:

[PATCH] D63818: [clangd] Collect the refs when the main file is header.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Previously, we only collect refs of the symbols which are declared in the preamble and referenced in the main file, it w

[PATCH] D63760: [clangd] Address limitations in SelectionTree:

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clangd/Selection.cpp:45 + if (R.first > Begin) +return false; // [R.First, Begin) is not covered. + if (Begin < R.second)

[clang-tools-extra] r364421 - [clangd] Added functionality for getting semantic highlights for variable and function declarations

Author: jvikstrom Date: Wed Jun 26 06:08:36 2019 New Revision: 364421 URL: http://llvm.org/viewvc/llvm-project?rev=364421&view=rev Log: [clangd] Added functionality for getting semantic highlights for variable and function declarations Added: clang-tools-extra/trunk/clangd/SemanticHighlighti

[PATCH] D63817: [clangd] No longer getting template instantiations from header files in Main AST.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:74 + if (!SM->isInMainFile(D->getLocation())) +// This decl comes from another file and should not be included in the you could get SourceManager from `D->getASTConte

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 206648. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. @Meinersbur your comment and my devs crossed, but this should be fine. This update enables new PM static plugin support for clang, something that was lac

r364423 - [OpenCL] Improve diagnostic for placement new

Author: svenvh Date: Wed Jun 26 06:31:24 2019 New Revision: 364423 URL: http://llvm.org/viewvc/llvm-project?rev=364423&view=rev Log: [OpenCL] Improve diagnostic for placement new Without an explicit declaration for placement new, clang would reject uses of placement new with "'default new' is not

r364424 - [clang/DIVar] Emit the flag for params that have unmodified value

Author: djtodoro Date: Wed Jun 26 06:32:02 2019 New Revision: 364424 URL: http://llvm.org/viewvc/llvm-project?rev=364424&view=rev Log: [clang/DIVar] Emit the flag for params that have unmodified value Emit the debug info flag that indicates that a parameter has unchanged value throughout a functi

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah marked 12 inline comments as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:54 + +// RAV subclass to find all DeclRefs in a given Stmt +class FindDeclRefsVisitor kadircet wrote: > I believ

[PATCH] D63561: [OpenCL] Improve diagnostic for placement new

This revision was automatically updated to reflect the committed changes. Closed by commit rL364423: [OpenCL] Improve diagnostic for placement new (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

This revision was automatically updated to reflect the committed changes. Closed by commit rL364424: [clang/DIVar] Emit the flag for params that have unmodified value (authored by djtodoro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille marked 10 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:808 +if(NOT llvm-pass-plugins) +# Target used to hold global properties referencable from generator-expression Meiner

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, javed.absar. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63821 Files: clang-tools-

r364428 - Make CodeGen depend on ASTMatchers

Author: hliao Date: Wed Jun 26 07:13:43 2019 New Revision: 364428 URL: http://llvm.org/viewvc/llvm-project?rev=364428&view=rev Log: Make CodeGen depend on ASTMatchers - Shared library builds are broken due to the missing dependency. Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt Modified: c

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan marked 3 inline comments as done. ebevhan added a comment. In D62574#1552220 , @Anastasia wrote: > Ok, I think at some point you might want to test extra functionality that > doesn't fit into OpenCL model, for example explicit conversion over > n

[PATCH] D63822: [Driver] Delete --print-supported-cpus in favor of -mcpu=? or -mtune=?

MaskRay created this revision. MaskRay added reviewers: kongyi, ziangwan. Herald added subscribers: cfe-commits, srhines. Herald added a project: clang. Also fix some style issues after D63105 . Repository: rC Clang https://reviews.llvm.org/D63822 Files: do

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah updated this revision to Diff 206663. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Refactored code - Refactored code as pointed by kadircet - Fixed crash for if statements without an else clause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63817: [clangd] No longer getting template instantiations from header files in Main AST.

jvikstrom updated this revision to Diff 206664. jvikstrom added a comment. Removed comment, getting SM from Decl and removed old check for checking the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63817/new/ https://reviews.llvm.org/D63817

[PATCH] D63817: [clangd] No longer getting template instantiations from header files in Main AST.

jvikstrom marked 3 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:75 + if (!SM->isInMainFile(D->getLocation())) +// This decl comes from another file and should not be included in the +// top leve

[PATCH] D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.

ymandel updated this revision to Diff 206667. ymandel marked 3 inline comments as done. ymandel added a comment. responded to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63784/new/ https://reviews.llvm.org/D63784 Files: clang-tools-e

[PATCH] D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.

ymandel added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h:48 + +template class TestClangTidyAction : public ASTFrontendAction { gribozavr wrote: > "CheckTypes"? 'cause "Checks" below is also technically a "check list". A

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

ymandel updated this revision to Diff 206668. ymandel added a comment. resp. to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63288/new/ https://reviews.llvm.org/D63288 Files: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck

[PATCH] D63817: [clangd] No longer getting template instantiations from header files in Main AST.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:47 #include +#include NIT: This include is redundant, maybe remove? Probably added by accident. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:71

[clang-tools-extra] r364435 - [clang-tidy] Fix ClangTidyTest to initialize context before checks.

Author: ymandel Date: Wed Jun 26 08:04:33 2019 New Revision: 364435 URL: http://llvm.org/viewvc/llvm-project?rev=364435&view=rev Log: [clang-tidy] Fix ClangTidyTest to initialize context before checks. Summary: Currently, `clang::tidy::test::runCheckOnCode()` constructs the check instances *befor

[clang-tools-extra] r364442 - [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

Author: ymandel Date: Wed Jun 26 09:04:38 2019 New Revision: 364442 URL: http://llvm.org/viewvc/llvm-project?rev=364442&view=rev Log: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator. Summary: Tidy check behavior often depends on language and/or clang-tidy options. This

[PATCH] D63822: [Driver] Delete --print-supported-cpus in favor of -mcpu=? or -mtune=?

ziangwan added a comment. Hey @MaskRay , can you explain why we should remove --print-supported-cpus. There already are similar options in clang such as `--print-effective-triple` and `--print-libgcc-file-name`. On the other hand, I almost never see an option goes like `-xxx=?`. Repository:

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, ar

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao added a comment. Ping =) @JonasToth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:744 OMPRTL__tgt_target_data_update_nowait, + // Call to int64_t __tgt_mapper_num_components(void *rt_mapper_handle); + OMPRTL__tgt_mapper_num_components, --

[PATCH] D63518: BitStream reader: propagate errors

jfb added a comment. I think this is ready to go! I rebased and ran `check-all` for LLVM / clang / clang-tools-extras and everything passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63518/new/ https://reviews.llvm.org/D63518 __

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

r364453 - Make AddLastArg() variadic and use it more. No behavior change.

Author: nico Date: Wed Jun 26 10:51:47 2019 New Revision: 364453 URL: http://llvm.org/viewvc/llvm-project?rev=364453&view=rev Log: Make AddLastArg() variadic and use it more. No behavior change. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Cla

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked 2 inline comments as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, ar

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

juliehockett added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63734/new/ https://reviews.llvm.org/D63734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 206714. ilya-biryukov added a comment. - Introduce roles to allow distinguishing the child nodes. - Remove recovery node, use an unknown role instead. - TreeBuidler now can consume children at any point, not just suffix nodes. Repository: rG LLVM Git

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added inline comments. Comment at: include/llvm/IR/IntrinsicInst.h:235 + ebStrict ///< This corresponds to "fpexcept.strict". }; rjmccall wrote: > kpn wrote: > > rjmccall wrote: > > > Is it okay that `ebUnspecified` and `ebInvalid` overl

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 206715. ilya-biryukov added a comment. - Remove (outdated) changes to gn files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61637/new/ https://reviews.llvm.org/D61637 Files: clang/include/clang/Toolin

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp:49 +diag(OperatorLoc, "POSIX functions (except posix_openpt) never return negative values") +<< FixItHint::CreateReplacement(

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added a comment. This is now in a pretty good shape, I've incorporated changes after our offline discussions about child roles. The builder interface is also much richer now, removing a requirement that the tree has to be traversed left-to-right (bottom-up is still required!). Re

[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

quantum updated this revision to Diff 206719. quantum added a comment. Split wasm-ld change into D63833 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63742/new/ https://reviews.llvm.org/D63742 Files: clang/lib/

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

rjmccall added inline comments. Comment at: include/llvm/IR/IntrinsicInst.h:235 + ebStrict ///< This corresponds to "fpexcept.strict". }; kpn wrote: > rjmccall wrote: > > kpn wrote: > > > rjmccall wrote: > > > > Is it okay that `ebUnspecifie

[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Remember to remove "A symbol __global_base is added so that code may know where the shadow memory ends and real memory begins." from the CL description. Repository: rG LLVM Github Monorepo

[PATCH] D63835: [Syntax] Add nodes for most common statements

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. ilya-biryukov added a parent revision: D61637: [Syntax] Introduce syntax trees. Most of the statements mirror the ones provided by clang AST. Major differences are: - expressions are wra

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

astrelni updated this revision to Diff 206720. astrelni marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62977/new/ https://reviews.llvm.org/D62977 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt clang-tools-extra/clang-tidy/google/GoogleTidyM

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

astrelni added a comment. In D62977#1559344 , @lebedev.ri wrote: > In D62977#1559334 , @astrelni wrote: > > > In D62977#1556346 , @lebedev.ri > > wrote: > > > > > In D62977#

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

lebedev.ri added a comment. It //sounds// correct, but i don't see accompanying test changes, so i can't be sure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62977/new/ https://reviews.llvm.org/D62977 ___ cfe-commits mailing list cfe-com

[PATCH] D63835: [Syntax] Add nodes for most common statements

ilya-biryukov added a comment. This change mostly aims to illustrate that `TreeBuilder` seems to be powerful enough to go beyond basic nodes. But it also introduces enough nodes to make the syntax trees minimally useful for traversing statement nodes. Hopefully that could become a good basis to

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/PosixReturnCheck.cpp:49 +diag(OperatorLoc, "POSIX functions (except posix_openpt) never return negative values") +<< FixItHint::CreateReplacement(OperatorLoc, Twine(">").str()); +r

[PATCH] D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling

aganea added a subscriber: rnk. aganea added a comment. A bit more detail on what we're seeing on our end (specs in the post above). The 'Count' column represents the number of 1ms samples taken in that function. The 'Weight' column is cumulated times for all cores, for a given process, in ms.

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

astrelni added a comment. In D62977#1559628 , @lebedev.ri wrote: > It //sounds// correct, but i don't see accompanying test changes, so i can't > be sure. The tests as they are cover the positive case in that they would not show warning or fixes if we

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

lebedev.ri added a comment. In D62977#1559637 , @astrelni wrote: > In D62977#1559628 , @lebedev.ri > wrote: > > > It //sounds// correct, but i don't see accompanying test changes, so i > > can't be sure. > > > The

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

r364462 - Print NULL as "(null)" in diagnostic message

Author: xingxue Date: Wed Jun 26 12:27:16 2019 New Revision: 364462 URL: http://llvm.org/viewvc/llvm-project?rev=364462&view=rev Log: Print NULL as "(null)" in diagnostic message Summary: Passing a null pointer to the printf family for a %s format specifier leads to undefined behaviour. The test

[PATCH] D63786: Print NULL as "(null)" in diagnostic message

This revision was automatically updated to reflect the committed changes. Closed by commit rL364462: Print NULL as "(null)" in diagnostic message (authored by xingxue, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked 2 inline comments as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, ar

r364464 - BitStream reader: propagate errors

Author: jfb Date: Wed Jun 26 12:50:12 2019 New Revision: 364464 URL: http://llvm.org/viewvc/llvm-project?rev=364464&view=rev Log: BitStream reader: propagate errors The bitstream reader handles errors poorly. This has two effects: * Bugs in file handling (especially modules) manifest as an "une

[clang-tools-extra] r364464 - BitStream reader: propagate errors

Author: jfb Date: Wed Jun 26 12:50:12 2019 New Revision: 364464 URL: http://llvm.org/viewvc/llvm-project?rev=364464&view=rev Log: BitStream reader: propagate errors The bitstream reader handles errors poorly. This has two effects: * Bugs in file handling (especially modules) manifest as an "une

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, ar

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak planned changes to this revision. ahatanak added a comment. This patch should diagnose lvalue-to-rvalue conversion of volatile non-trivial C unions too, but it currently doesn't. void test(volatile union U0 *a) { (void)*a; } Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL364468: [WebAssembly] Implement Address Sanitizer for Emscripten (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D63742?vs=206719&id=206732#toc Repository: rL

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, ar

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. Any updates on this? I'm thinking that in the meantime maybe we could commit D63174 and work on this while that lands. If so, we could get an upstream new PM buildbot that can catch any new PM regressions. CHANGES SINCE LAST ACTIO

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. @chandlerc ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

  1   2   >