hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:74 + if (!SM->isInMainFile(D->getLocation())) + // This decl comes from another file and should not be included in the ---------------- you could get SourceManager from `D->getASTContext().getSourceManager()`. ================ Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:75 + if (!SM->isInMainFile(D->getLocation())) + // This decl comes from another file and should not be included in the + // top level decls. ---------------- nit: This comment just repeats the code, I think the comment describe why we need to do this check (because of the template instantiation?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63817/new/ https://reviews.llvm.org/D63817 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
