hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Thanks, looks good. ================ Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:1 +//==- SemanticHighlightingTest.cpp - SemanticHighlightTest tests-*- C++ -* -==// +// ---------------- nit: SemanticHighlightingTest.cpp => SemanticHighlightingTests.cpp ================ Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:18 + +std::vector<HighlightingToken> makeHighlightingTokens(llvm::ArrayRef<Range> Ranges, + HighlightingKind Kind) { ---------------- nit: clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63559/new/ https://reviews.llvm.org/D63559 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits