ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:47
#include <memory>
+#include <iostream>
----------------
NIT: This include is redundant, maybe remove?
Probably added by accident.
================
Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:71
for (Decl *D : DG) {
- if (D->isFromASTFile())
+ if
(!D->getASTContext().getSourceManager().isInMainFile(D->getLocation()))
continue;
----------------
Please use `isWrittenInMainFile` instead.
`isInMainFile` takes `#line` markers into account, we don't want that in clangd.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63817/new/
https://reviews.llvm.org/D63817
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
