johannes added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537
+
+#include "../../AST/DeclDataCollectors.inc"
+
arphaman wrote:
> I didn't realize that you're including files from within `lib`. That's not
> ideal. You should add a pre-commit tha
danielmarjamaki accepted this revision.
danielmarjamaki added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:165
+with open(filename, 'r') as in_file:
+for line in in_file:
+
Author: arphaman
Date: Fri Sep 1 02:16:02 2017
New Revision: 312316
URL: http://llvm.org/viewvc/llvm-project?rev=312316&view=rev
Log:
[refactor] Use a RefactoringResultConsumer instead of tagged refactoring
rule classes
This commit changes the way that the refactoring results are produced. Inste
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312316: [refactor] Use a RefactoringResultConsumer instead
of tagged refactoring (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D37291?vs=113397&id=113520#toc
Repository:
r
arphaman updated this revision to Diff 113521.
arphaman added a comment.
Rebase on ToT
Repository:
rL LLVM
https://reviews.llvm.org/D37210
Files:
include/clang/Tooling/Refactoring/RefactoringResultConsumer.h
unittests/Tooling/RefactoringActionRulesTest.cpp
Index: unittests/Tooling/Refa
PriMee added a reviewer: krasimir.
PriMee added a subscriber: krasimir.
PriMee added a comment.
@krasimir Could you please tell me what did you mean in the comment:
> I am still not convinced about the extern part: some clients might prefer the
> other style.
Do you suggest adding a new option,
ilya-biryukov added a comment.
This looks like a useful change even without prior changes to VSCode.
Maybe add a command-line flag to clangd(`--enable-snippets`) and commit that?
When snippets are disabled, we could simply do `insertText = /**/`
after `ProcessChunks`, we will deprecate and remo
ilya-biryukov added a comment.
Also wanted to stress once again that we need some tests for this change.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:418
+// for functions and methods, the return type.
+assert(item.detail.empty() && "Unexpected extraneous CK_ResultType");
+Item.detail = Chunk.Text;
Typo: should be `I
hamzasood created this revision.
This patch adds a test case to ensure that every library header uses the
correct visibility macros.
libc++ headers should use _LIBCPP_* macros whereas libc++experimental headers
should use _LIBCPPX_* macros.
This was originally part of https://reviews.llvm.org/D
hamzasood created this revision.
Herald added a subscriber: mgorny.
This patch fixes a few problems with building libc++experimental on Windows.
Previously _LIBCPP_BUILDING_LIBRARY was defined for every source file,
including files destined for the experimental library. As a result of this,
non
arphaman updated this revision to Diff 113533.
arphaman added a comment.
Rebase on top of trunk and https://reviews.llvm.org/D37210.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D36574
Files:
include/clang/Tooling/Refactoring/RefactoringAction.h
include/clang/Tooling/Refactoring/R
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D35110#854334, @zaks.anna wrote:
> Is this blocked on the same reasons as what was raised in
> https://reviews.llvm.org/D35109?
No, it is blocked because https://reviews.llvm.org/D35109 is a prerequisite.
https://reviews.llvm.or
baloghadamsoftware added a comment.
Anna, Devin, should I proceed with Artem's suggested way?
https://reviews.llvm.org/D35109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:337
+// Fill in the kind field of the CompletionItem.
+Item.kind = getKind(Result.CursorKind);
+
ilya-biryukov wrote:
> Could we also set `Item.filterText` to completion item name?
> S
mgorny added a comment.
@ajbennieston, ping.
Repository:
rL LLVM
https://reviews.llvm.org/D34091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Nevermind. I found out what's wrong via looking at the older patch versions.
Repository:
rL LLVM
https://reviews.llvm.org/D34091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
mgorny created this revision.
The test_exception_specification_kind.py test has been committed
to the tests/ directory of clang Python bindings. As a result, it fails
since it attempts to load util.py module relatively from the current
directory:
NoQ planned changes to this revision.
NoQ added a comment.
This is all wrong. While `RetainCountChecker` is more function-local than, say,
`MallocChecker`, we still can't say for sure that it is the bottom frame's
function (or block) that should be owning the object in this case. Ideally it
sho
klimek added a comment.
One of my main concerns is still that I don't see the need for all the template
magic yet :) Why doesn't everybody use the RefactoringResult we define here?
Comment at: test/Refactor/LocalRename/Field.cpp:4
+class Baz {
+ int /*range=*/Foo; // CHECK: s
arphaman added a comment.
In https://reviews.llvm.org/D36574#858763, @klimek wrote:
> One of my main concerns is still that I don't see the need for all the
> template magic yet :) Why doesn't everybody use the RefactoringResult we
> define here?
This refactoring result is only really useful
arphaman added inline comments.
Comment at: test/Refactor/LocalRename/Field.cpp:4
+class Baz {
+ int /*range=*/Foo; // CHECK: symbol [[@LINE]]:17 -> [[@LINE]]:20
+public:
klimek wrote:
> Does this just test the selection?
No, this is the moved `clang-rename/Fiel
Author: compnerd
Date: Fri Sep 1 08:25:17 2017
New Revision: 312330
URL: http://llvm.org/viewvc/llvm-project?rev=312330&view=rev
Log:
Driver: extract modules flag handling (NFC)
Extract a function to render the options related to modules. This
reduces the cyclomatic complexity of the `Construct
brad.king created this revision.
In commit r303930 (Switch from using a DiagnosticTrap and a note...,
2017-05-25) use of DiagnosticErrorTrap was removed because it was no
longer needed to detect whether to add a diagnostic note. However, the
trap was also necessary to correctly detect and mark in
lebedev.ri added a comment.
1. Please upload path with full context (-U)
2. Tests?
https://reviews.llvm.org/D37381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad.king updated this revision to Diff 113544.
brad.king added a comment.
Updated diff with full context.
https://reviews.llvm.org/D37381
Files:
lib/Sema/SemaDeclCXX.cpp
Index: lib/Sema/SemaDeclCXX.cpp
===
--- lib/Sema/SemaDecl
brad.king added a comment.
> Tests?
`make check` didn't regress from this.
This behavior difference is not observable from within Clang itself, only in
external applications that use SuppressAllDiagnostics while forcing definition
of implicit members. Adding a test will require reproducing a
lebedev.ri added a comment.
In https://reviews.llvm.org/D37381#858800, @brad.king wrote:
> > Tests?
>
> `make check` didn't regress from this.
Which is the problem.
Say this gets committed, and then someone else for some reason reverts part of
the patch.
Normally, tests should catch that. But
ilya-biryukov created this revision.
The crash occured when FunctionDecl was parsed with an initializer.
https://reviews.llvm.org/D37382
Files:
lib/Parse/ParseDecl.cpp
test/CodeCompletion/crash-func-init.cpp
Index: test/CodeCompletion/crash-func-init.cpp
==
johannes updated this revision to Diff 113546.
johannes added a comment.
fix by adding an option in RecursiveASTVisitor
https://reviews.llvm.org/D36998
Files:
include/clang/AST/LexicallyOrderedRecursiveASTVisitor.h
include/clang/AST/RecursiveASTVisitor.h
unittests/Tooling/LexicallyOrdered
johannes created this revision.
Herald added a subscriber: mgorny.
Herald added 1 blocking reviewer(s): teemperor.
This adds an option "-gen-clang-data-collectors" to the Clang TableGen
that is used to generate StmtDataCollectors.inc.
https://reviews.llvm.org/D37383
Files:
include/clang/AST/C
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:337
+// Fill in the kind field of the CompletionItem.
+Item.kind = getKind(Result.CursorKind);
+
ilya-biryukov wrote:
> ilya-biryukov wrote:
> > Could we also set `Item.filterText` to
Anastasia accepted this revision.
Anastasia added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Basic/Builtins.def:1427
+// OpenCL half load/store builtin
+BUILTIN(__builtin_store_half, "vdh*", "n")
+BUILTIN(__builtin_store_halff, "vf
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D36678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Anastasia added a comment.
LGTM! Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D37231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/no-half.cl:19
+ __builtin_store_half(foo, bar);
+// CHECK: [[HALF_VAL:%.*]] = fptrunc double %foo to half
+// CHECK: store half [[HALF_VAL]], half addrspace({{.}})* %bar, align 2
Would it make
Author: d0k
Date: Fri Sep 1 09:51:51 2017
New Revision: 312336
URL: http://llvm.org/viewvc/llvm-project?rev=312336&view=rev
Log:
std::function -> llvm::function_ref. NFC.
Modified:
cfe/trunk/include/clang/Analysis/CloneDetection.h
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/
arphaman added a comment.
TableGen is great for structured data, but we shouldn't use it just to embed
code in it. What was the issue you've had with the build when the inc file was
in include?
https://reviews.llvm.org/D37383
___
cfe-commits maili
arphaman added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:507-508
// Traverses template parameter lists of either a DeclaratorDecl or TagDecl.
template
bool TraverseDeclTemplateParameterLists(T *D);
I don't think you need to
teemperor added a comment.
@arphaman I suggested tablegen in https://reviews.llvm.org/D36664 because I
remembered we had some CMake sanity check about not having an *.inc in our
include dir:
https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure
if it actually fires for
kasaurov created this revision.
Herald added subscribers: t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng,
kzhuravl.
In current OpenCL implementation some options are set in OpenCL RT/Driver,
which causes discrepancy between online and offline paths.
Implement infrastructure to move options fr
Author: compnerd
Date: Fri Sep 1 10:43:59 2017
New Revision: 312344
URL: http://llvm.org/viewvc/llvm-project?rev=312344&view=rev
Log:
Driver: extract ObjC option rendering (NFC)
Extract the ObjC option rendering for the frontend. This localises the
option translation. It augments the existing
arphaman added a comment.
In https://reviews.llvm.org/D37383#858905, @teemperor wrote:
> @arphaman I suggested tablegen in https://reviews.llvm.org/D36664 because I
> remembered we had some CMake sanity check about not having an *.inc in our
> include dir:
> https://github.com/llvm-mirror/clan
emankov added inline comments.
Comment at: lib/Driver/ToolChains/AMDGPU.cpp:60-62
+ for (auto *A : Args) {
+DAL->append(A);
+ }
redundant braces
Comment at: lib/Driver/ToolChains/AMDGPU.cpp:74-75
+// as they defined that way in Option
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Assuming no sphinx issues with the docs, this LGTM, thank you!
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let C
rampitec added inline comments.
Comment at: lib/Driver/ToolChains/AMDGPU.h:44
+private:
+ const std::map OptionsDefault = {
+ {options::OPT_O, "3"},
Is it really needed to create map in the header?
https://reviews.llvm.org/D37386
__
brad.king updated this revision to Diff 113561.
brad.king edited the summary of this revision.
brad.king added a comment.
Herald added a subscriber: mgorny.
Updated diff to add a test case.
https://reviews.llvm.org/D37381
Files:
lib/Sema/SemaDeclCXX.cpp
unittests/Sema/CMakeLists.txt
unitt
Author: kcc
Date: Fri Sep 1 11:34:36 2017
New Revision: 312346
URL: http://llvm.org/viewvc/llvm-project?rev=312346&view=rev
Log:
[libFuzzer] switch -fsanitize=fuzzer from trace-pc-guard to inline-8bit-counters
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe/trunk/test/Driver/fuzzer.
Author: compnerd
Date: Fri Sep 1 11:57:34 2017
New Revision: 312351
URL: http://llvm.org/viewvc/llvm-project?rev=312351&view=rev
Log:
Driver: extract diagnostics flag handling (NFC)
Extract a function to render the diagnostics options to the clang
frontend. This continues the simplification of
ahatanak added a comment.
Is it possible to avoid creating CXXDependentScopeMemberExpr in the first
place? It seems to me that we shouldn't be creating a
CXXDependentScopeMemberExpr for an ObjC property access.
Or perhaps there are reasons to type-correct it later?
https://reviews.llvm.org/D3
JDevlieghere created this revision.
JDevlieghere added a project: clang.
Herald added a subscriber: mgorny.
This patch adds a new tool to diagnostic tool called `list-warning-flags` to
display only warnings that have a corresponding -W flag.
While we already have `list-warnings`, the output cont
Don't wait on me here.
On Thu, Aug 31, 2017, 10:53 PM Craig Topper via Phabricator <
revi...@reviews.llvm.org> wrote:
> craig.topper accepted this revision.
> craig.topper added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
>
>
> https://reviews.llvm.org/D36707
>
>
>
>
__
Oops, totally forgot this got approved ☺ Thanks for the reminder!
From: Eric Christopher [mailto:echri...@gmail.com]
Sent: Friday, September 1, 2017 12:40 PM
To: reviews+d36707+public+aa8b48c258736...@reviews.llvm.org; Keane, Erich
; llvm-...@redking.me.uk; craig.top...@gmail.com
Cc: cfe-commits
Author: erichkeane
Date: Fri Sep 1 12:42:45 2017
New Revision: 312355
URL: http://llvm.org/viewvc/llvm-project?rev=312355&view=rev
Log:
[CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with
"target" implementation
A small set of refactors that'll make it easier for me to impl
johannes added a comment.
In https://reviews.llvm.org/D37383#858905, @teemperor wrote:
> @arphaman I suggested tablegen in https://reviews.llvm.org/D36664 because I
> remembered we had some CMake sanity check about not having an *.inc in our
> include dir:
> https://github.com/llvm-mirror/clan
johannes updated this revision to Diff 113581.
johannes added a comment.
undo visibility change
https://reviews.llvm.org/D36998
Files:
include/clang/AST/LexicallyOrderedRecursiveASTVisitor.h
include/clang/AST/RecursiveASTVisitor.h
unittests/Tooling/LexicallyOrderedRecursiveASTVisitorTest.
cameron314 added a comment.
The `IsValid = true` line coincidentally fixes a tangentially related bug --
see https://reviews.llvm.org/D20338 (in which I tried to introduce the same fix
almost a year earlier, but nobody accepted the review). I guess I have to
maintain the test for that case out
jvesely updated this revision to Diff 113588.
jvesely marked 6 inline comments as done.
jvesely edited the summary of this revision.
jvesely added a comment.
fully check loads in tests
Repository:
rL LLVM
https://reviews.llvm.org/D37231
Files:
include/clang/Basic/Builtins.def
include/cla
jvesely added inline comments.
Comment at: include/clang/Basic/Builtins.def:1427
+// OpenCL half load/store builtin
+BUILTIN(__builtin_store_half, "vdh*", "n")
+BUILTIN(__builtin_store_halff, "vfh*", "n")
Anastasia wrote:
> jvesely wrote:
> > Anastasia wrote:
> >
Author: eugenis
Date: Fri Sep 1 13:37:20 2017
New Revision: 312361
URL: http://llvm.org/viewvc/llvm-project?rev=312361&view=rev
Log:
Enable check-ubsan-minimal in standalone compiler-rt build.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
URL:
http:/
Author: hans
Date: Fri Sep 1 14:02:55 2017
New Revision: 312371
URL: http://llvm.org/viewvc/llvm-project?rev=312371&view=rev
Log:
Creating release candidate rc5 from release_500 branch
Added:
libcxx/tags/RELEASE_500/rc5/ (props changed)
- copied from r312370, libcxx/branches/release_
Author: hans
Date: Fri Sep 1 14:02:56 2017
New Revision: 312372
URL: http://llvm.org/viewvc/llvm-project?rev=312372&view=rev
Log:
Creating release candidate rc5 from release_500 branch
Added:
libcxxabi/tags/RELEASE_500/rc5/
- copied from r312371, libcxxabi/branches/release_50/
___
Author: hans
Date: Fri Sep 1 14:03:03 2017
New Revision: 312378
URL: http://llvm.org/viewvc/llvm-project?rev=312378&view=rev
Log:
Creating release candidate rc5 from release_500 branch
Added:
libunwind/tags/RELEASE_500/rc5/ (props changed)
- copied from r312377, libunwind/branches/re
mgrang created this revision.
This fixes failures seen in the reverse iteration builder:
http://lab.llvm.org:8011/builders/reverse-iteration/builds/26
Failing Tests (4):
Clang :: Analysis/MisusedMovedObject.cpp
Clang :: Analysis/keychainAPI.m
Clang :: Analysis/loop-unrolling.cpp
Clang ::
mgrang added a comment.
The thing I am concerned with here is whether changing SmallPtrSet to a
SetVector can potentially slow down the Static Analyzer? ExplodedNode seem to
be used heavily in the analyzer and I can see it being iterated upon in several
places.
https://reviews.llvm.org/D37400
aprantl added a comment.
Can this be tested?
Comment at: tools/diagtool/ListWarningFlags.cpp:36
+ for (ArrayRef::iterator di = AllDiagnostics.begin(),
+de = AllDiagnostics.end();
+ di != de; ++di) {
range-based
Author: compnerd
Date: Fri Sep 1 15:04:24 2017
New Revision: 312385
URL: http://llvm.org/viewvc/llvm-project?rev=312385&view=rev
Log:
Driver: extract floating point optimization handling (NFC)
Extract the logic for the floating point handling into its own function.
None of this information is ne
ddcc updated this revision to Diff 113619.
ddcc added a comment.
Rebase, factor out floating-point changes, fix Z3 type bug, support general
APSInt comparison
https://reviews.llvm.org/D28955
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h
include/clang/StaticAnal
ddcc added a comment.
@dcoughlin No, all three patches are separate. I have been testing them with
each applied incrementally onto the previous, with the order trunk,
https://reviews.llvm.org/D35450, https://reviews.llvm.org/D28954, then
https://reviews.llvm.org/D28955 (this). But since these a
ddcc added a comment.
@NoQ Does the proposal in https://reviews.llvm.org/D28955#652465 satisfy your
concern?
https://reviews.llvm.org/D28955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
jvesely updated this revision to Diff 113624.
jvesely added a comment.
mark load pointers const
Repository:
rL LLVM
https://reviews.llvm.org/D37231
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
lib/Basic/Builtins.cpp
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOp
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
It's not reasonable for external users of Clang's AST to infer deep meaning
from the "invalid" flag. It's simply a mechanism by which we (a) limit the
amount of follow-on diagnostics
Author: compnerd
Date: Fri Sep 1 16:44:01 2017
New Revision: 312392
URL: http://llvm.org/viewvc/llvm-project?rev=312392&view=rev
Log:
Driver: extract `-fbuiltin` option handling (NFC)
Extract the handling of the `-fbuiltin` family of flags to the driver.
This centralises the handling of those op
yaxunl added a comment.
Is it possible to add a test for this? Thanks.
https://reviews.llvm.org/D37386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: awatry
Date: Fri Sep 1 19:23:16 2017
New Revision: 312402
URL: http://llvm.org/viewvc/llvm-project?rev=312402&view=rev
Log:
Add halfN types and enable fp16 when generating builtin declarations
Uses the same mechanism to enable fp16 as we use for fp64 when
processing clc.h
Signed-off-by:
Author: awatry
Date: Fri Sep 1 19:23:26 2017
New Revision: 312403
URL: http://llvm.org/viewvc/llvm-project?rev=312403&view=rev
Log:
relational: Implement shuffle builtin
This was added in CL 1.1
Tested with a Radeon HD 7850 (Pitcairn) using the CL CTS via:
test_conformance/relationals/test_rela
Author: awatry
Date: Fri Sep 1 19:23:28 2017
New Revision: 312404
URL: http://llvm.org/viewvc/llvm-project?rev=312404&view=rev
Log:
relational: Implement shuffle2 builtin
This was added in CL 1.1
Tested with a Radeon HD 7850 (Pitcairn) using the CL CTS via:
test_conformance/relationals/test_rel
Author: vitalybuka
Date: Fri Sep 1 20:53:42 2017
New Revision: 312407
URL: http://llvm.org/viewvc/llvm-project?rev=312407&view=rev
Log:
Don't search libxml2 if using msan. LLVM already has similar check.
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.txt
URL:
http://llvm
coby created this revision.
Allow the proper recognition of Enum values and global variables inside ms
inline-asm memory / immediate expressions, as they require some additional
overhead and treated incorrect if doesn't early recognized.
supersedes https://reviews.llvm.org/D33277, https://review
79 matches
Mail list logo
