brad.king added a comment.

> Tests?

`make check` didn't regress from this.

This behavior difference is not observable from within Clang itself, only in 
external applications that use SuppressAllDiagnostics while forcing definition 
of implicit members.  Adding a test will require reproducing a chunk of the 
application code in the test suite to create the appropriate CompilerInstance.  
I'd be happy to do that to keep this working in the future, but where would be 
the appropriate place?

BTW, I'd like to see this integrated in the `release_50` branch because this 
regression breaks my application that works with 3.6, 3.7, 3.8, 3.9, and 4.0.


https://reviews.llvm.org/D37381



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to