aprantl added a comment.

Can this be tested?



================
Comment at: tools/diagtool/ListWarningFlags.cpp:36
+  for (ArrayRef<DiagnosticRecord>::iterator di = AllDiagnostics.begin(),
+                                            de = AllDiagnostics.end();
+       di != de; ++di) {
----------------
range-based for / auto?


================
Comment at: tools/diagtool/ListWarningFlags.cpp:38
+       di != de; ++di) {
+    unsigned diagID = di->DiagID;
+    llvm::StringRef flag = DiagnosticIDs::getWarningOptionForDiag(diagID);
----------------
The LLVM style wants variables to begin with an uppercase letter.


Repository:
  rL LLVM

https://reviews.llvm.org/D37390



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to