arphaman added a comment. In https://reviews.llvm.org/D37383#858905, @teemperor wrote:
> @arphaman I suggested tablegen in https://reviews.llvm.org/D36664 because I > remembered we had some CMake sanity check about not having an *.inc in our > include dir: > https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure > if it actually fires for our case, but it looks like it does. I see, thanks. > Also it would be nicer to maintain once we have a second attribute for an > optional single-TU code as tablegen could just fall back from `SingleTUCode` > to the normal `Code` attribute. And we would have an easy solution for the > CrossTU/SingleTU inc files as tablegen could just create both without us > having to manually copy code around or do preprocessor hacks. If you think there's a need for TableGen in the future then I see no problem with this approach. I was just reluctant to accept it only for code. > I guess this review will make more sense once we have both CrossTU and > SingleTU code ready. https://reviews.llvm.org/D37383 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
