klimek added a comment.
One of my main concerns is still that I don't see the need for all the template
magic yet :) Why doesn't everybody use the RefactoringResult we define here?
================
Comment at: test/Refactor/LocalRename/Field.cpp:4
+class Baz {
+ int /*range=*/Foo; // CHECK: symbol [[@LINE]]:17 -> [[@LINE]]:20
+public:
----------------
Does this just test the selection?
================
Comment at: tools/clang-refactor/ClangRefactor.cpp:135
+
+class ToolRefactoringEngine final : public RefactoringEngine {
+public:
----------------
Can we use composition instead of inheritance here?
Repository:
rL LLVM
https://reviews.llvm.org/D36574
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
