Author: echristo
Date: Wed Aug 26 02:01:30 2015
New Revision: 246020
URL: http://llvm.org/viewvc/llvm-project?rev=246020&view=rev
Log:
Remove a TODO that isn't going to get fixed in this way.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llv
Author: echristo
Date: Wed Aug 26 02:01:33 2015
New Revision: 246021
URL: http://llvm.org/viewvc/llvm-project?rev=246021&view=rev
Log:
Remove dead code associated with parsing and setting ABI based on
string name.
Modified:
cfe/trunk/include/clang/Basic/TargetCXXABI.h
cfe/trunk/include/cl
Author: ericwf
Date: Wed Aug 26 02:03:43 2015
New Revision: 246022
URL: http://llvm.org/viewvc/llvm-project?rev=246022&view=rev
Log:
Remove XFAIL in test. The bug causing it has been fixed.
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.co
Author: echristo
Date: Wed Aug 26 02:29:58 2015
New Revision: 246024
URL: http://llvm.org/viewvc/llvm-project?rev=246024&view=rev
Log:
Group some of the inline assembly related function prototypes near
each other.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
Modified: cfe/trunk/inclu
Author: yrnkrn
Date: Wed Aug 26 03:10:22 2015
New Revision: 246026
URL: http://llvm.org/viewvc/llvm-project?rev=246026&view=rev
Log:
Make FileManager::getFileSystemOptions consistent with
CompilerInstance::getFileSystemOpts
and CompilerInvocation::getFileSystemOpts by renaming it to getFileSystem
Author: echristo
Date: Wed Aug 26 03:21:55 2015
New Revision: 246027
URL: http://llvm.org/viewvc/llvm-project?rev=246027&view=rev
Log:
Convert a bunch of loops to ranged-for and clean up accordingly.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
ht
seaneveson created this revision.
seaneveson added a subscriber: cfe-commits.
Dear All,
We have been looking at the following problem, where any code after the
constant bound loop is not analyzed because of the limit on how many times the
same block is visited, as described in bugzillas #7638 a
danielmarjamaki created this revision.
danielmarjamaki added a subscriber: cfe-commits.
This is a new warning for Clang. It will warn when a pointer parameter can be
const.
The design is inspired by the Wunused-parameter warning.
I have tested this on many debian packages. In 2151 projects ther
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
Fix a bug where modernize-loop-convert check would take as alias a reference to
other containers. Add the pertinent test.
http://reviews.llvm.org/D12361
Files:
clang-ti
berenm created this revision.
berenm added a reviewer: djasper.
berenm added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This allows clang-format to align identifiers in consecutive declarations.
This is, arguably, a feature useful for increasing the readability of the code,
in
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D12361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: angelgarcia
Date: Wed Aug 26 09:51:11 2015
New Revision: 246034
URL: http://llvm.org/viewvc/llvm-project?rev=246034&view=rev
Log:
LoopConvert no longer take as alias references to other containers.
Summary: Fix a bug where modernize-loop-convert check would take as alias a
reference to o
djasper added inline comments.
Comment at: unittests/Format/FormatTest.cpp:8619
@@ -8618,1 +8618,3 @@
+TEST_F(FormatTest, AlignConsecutiveDeclarations) {
+ FormatStyle Alignment = getLLVMStyle();
This needs tests that check what happens if both declarations and
scott-0 created this revision.
scott-0 added a subscriber: cfe-commits.
I'm going to use SideEffectFinder in my subsequent patch.
http://reviews.llvm.org/D12365
Files:
include/clang/AST/SideEffectFinder.h
lib/AST/Expr.cpp
Index: lib/AST/Expr.cpp
=
scott-0 created this revision.
scott-0 added a subscriber: cfe-commits.
This makes an existing optimization apply in more cases.
http://reviews.llvm.org/D12366
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/destructors.cpp
Index: test/CodeGenCXX/destructors.cpp
=
sberg added a subscriber: sberg.
sberg added a comment.
causes false positive for
char * f(char *);
char * g(char * p) { return f(p); }
http://reviews.llvm.org/D12359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
berenm added a comment.
Actually, I think there is a bug in the assignment alignment code. Even without
this patch, this code doesn't align properly:
int oneTwoThree = 123;
int oneTwo = 12;
method();
I don't think I completely understand the assignment alignment code, and that's
why
gbedwell created this revision.
gbedwell added reviewers: hans, rnk, aaron.ballman.
gbedwell added a subscriber: cfe-commits.
This is a clang release note to match the LLVM release note in D12367.
As we're planning on raising the minimum Windows version to Windows 7 for LLVM
3.8 as per this disc
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM for the release branch!
http://reviews.llvm.org/D12368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
pgousseau added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:825
@@ -816,1 +824,3 @@
+ProgramStateRef CStringChecker::IsFirstBufInBound(CheckerContext &C,
+ ProgramStateRef state,
dc
Author: sbenza
Date: Wed Aug 26 11:15:59 2015
New Revision: 246037
URL: http://llvm.org/viewvc/llvm-project?rev=246037&view=rev
Log:
[ASTMatchers] Add type matcher for SubstTemplateTypeParmType.
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
cfe/trunk/lib/ASTMatchers/Dynamic/
berenm created this revision.
berenm added a reviewer: djasper.
berenm added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This simple test case (added to the unit tests) was failing to align,
apparently due to the ``method();`` on the last line:
```
int oneTwoThree = 123;
int on
berenm added a comment.
I'm not entirely sure of what was going on, so I rewrote the code a bit, and
hopefully, more clearly.
Comment at: lib/Format/WhitespaceManager.cpp:218
@@ -217,3 +229,1 @@
- bool AlignedAssignment = false;
- int PreviousShift = 0;
for (unsigned i = S
berenm updated this revision to Diff 33212.
berenm added a comment.
Added some test cases in combined usage with AlignConsecutiveAssignments.
The tests should pass with http://reviews.llvm.org/D12369 applied.
http://reviews.llvm.org/D12362
Files:
include/clang/Format/Format.h
lib/Format/Fo
djasper added a comment.
Adding Matt, the original author of the code. (also I don't have much time to
review this or the other patch today, but will try to finish before the end of
the week)
http://reviews.llvm.org/D12369
___
cfe-commits mailing
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
Prevent LoopConvert from taking as alias anything that comes from a random
member function call.
http://reviews.llvm.org/D12370
Files:
clang-tidy/modernize/LoopConvertU
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D12370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: angelgarcia
Date: Wed Aug 26 12:08:24 2015
New Revision: 246039
URL: http://llvm.org/viewvc/llvm-project?rev=246039&view=rev
Log:
Fix another LoopConvert fail.
Summary: Prevent LoopConvert from taking as alias anything that comes from a
random member function call.
Reviewers: alexfh
Su
Author: dschuff
Date: Wed Aug 26 12:14:08 2015
New Revision: 246040
URL: http://llvm.org/viewvc/llvm-project?rev=246040&view=rev
Log:
Change Native Client x86 usr include and link path to match SDK expectations
GNU multilib style uses x86_64-nacl/include and x86_64-nacl/usr/include
but the SDK ex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246040: Change Native Client x86 usr include and link path
to match SDK expectations (authored by dschuff).
Changed prior to commit:
http://reviews.llvm.org/D11271?vs=29924&id=33216#toc
Repository:
r
davidxl added a subscriber: davidxl.
davidxl added a comment.
In libc++, placement new is used in many places. When selecting the buffer
size for the placed object, it uses the 'actual' size of the buffer including
the padding bytes from alignment, instead of the declared of the buffer. As a
r
EricWF updated this revision to Diff 33219.
EricWF added a comment.
Address failing test that @awi pointed out.
http://reviews.llvm.org/D12299
Files:
include/list
Index: include/list
===
--- include/list
+++ include/list
@@ -191
EricWF added a comment.
I think I'm starting to understand but I think the correct fix for this would
be to fix function so that:
1. It aligns its buffer by alignof(void*).
2. It doesn't stick over-aligned types in the small object buffer.
Point two can probably be done without an ABI break, bu
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davidxl added a comment.
We certainly need a fix without breaking ABI. Is there a ABI conformance test
for libcxx?
http://reviews.llvm.org/D12247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
EricWF added a comment.
In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
> We certainly need a fix without breaking ABI. Is there a ABI conformance test
> for libcxx?
Well this patch definitely breaks the ABI. This was my attempt at fixing the
problem in `std::function` that might no
On Wed, Aug 26, 2015 at 11:11 AM, Eric Fiselier wrote:
> EricWF added a comment.
>
> In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
>
>> We certainly need a fix without breaking ABI. Is there a ABI conformance
>> test for libcxx?
>
>
> Well this patch definitely breaks the ABI. This wa
EricWF added a comment.
In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
> We certainly need a fix without breaking ABI. Is there a ABI conformance test
> for libcxx?
To actually answer @davidxl's question: No. libc++ does not have an ABI test
suite of any sort.
http://reviews.llvm
sepavloff added a subscriber: sepavloff.
sepavloff added a comment.
Ping.
Thanks,
--Serge
http://reviews.llvm.org/D11844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ping.
Thanks,
--Serge
2015-08-22 3:15 GMT+06:00 Sean Silva :
> silvas added inline comments.
>
>
> Comment at: test/Modules/auto-module-import.m:89
> @@ +88,3 @@
> + expected-error {{import of module
> 'NoUmbrella.A' appears within function 'includeN
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, hans.
aaron.ballman added a subscriber: cfe-commits.
PR24559 brings up a long-standing issue in Clang where attribute order with
differing syntax impacts whether a parse will succeed or fail with poor
diagnostics. For in
ahatanak added a comment.
float-abi=hard has no effect on the backend code-generation if the ABI is APCS,
meaning GPRs will be used to pass floating point arguments. This patch makes
changes to the driver so that the error is detected in the front-end rather
than silently ignoring the option in
Author: ahatanak
Date: Wed Aug 26 14:00:11 2015
New Revision: 246054
URL: http://llvm.org/viewvc/llvm-project?rev=246054&view=rev
Log:
[ARM] Error out if float-ab=hard and abi=apcs-gnu on macho platforms.
Error out if -mfloat-abi=hard or -mhard-float is specified on the command
line and the targe
Author: ericwf
Date: Wed Aug 26 14:04:40 2015
New Revision: 246055
URL: http://llvm.org/viewvc/llvm-project?rev=246055&view=rev
Log:
Refactor flaky shared_mutex tests
Modified:
libcxx/trunk/test/std/thread/thread.mutex/thread.mutex.requirements/thread.shared_mutex.requirements/thread.shared_
jroelofs added a comment.
the `addWarningFlagIfSupported` part of this patch LGTM.
Comment at: test/libcxx/compiler.py:88
@@ -87,1 +87,3 @@
+def compileString(self, source, out=None, flags=[], env=None, cwd=None):
+cmd = self.compileCmd('-', out, flags)
---
bader created this revision.
bader added a subscriber: cfe-commits.
http://reviews.llvm.org/D12378
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/cond.cl
Index: test/SemaOpenCL/cond.cl
EricWF added a comment.
Those methods are currently unused but are you opposed to me adding them in
this patch? They will be useful for compiling short tests to check for compiler
features.
http://reviews.llvm.org/D11333
___
cfe-commits mailing li
jroelofs added a comment.
I'd say put them in when you have actual uses for them
http://reviews.llvm.org/D11333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added inline comments.
Comment at: test/libcxx/compiler.py:195
@@ +194,3 @@
+cmd.remove('-v')
+out, err, rc = lit.util.executeCommand(cmd, input='#error\n')
+assert rc != 0
... you could at least use `compileString` here.
htt
mclow.lists added a comment.
So far, this looks good. I'm going to apply it locally and futz with it.
Comment at: include/__functional_base_03:30
@@ +29,3 @@
+typedef _Ret _Bullet2;
+typedef _Ret type;
+};
Let's be consistent. :-)
typedef _Bullet2 t
mclow.lists added a comment.
I think I'd rather see the call to `strcmp` and `wcscmp` in the char_traits
class.
http://reviews.llvm.org/D12355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
pekka.jaaskelainen added a subscriber: pekka.jaaskelainen.
pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a reviewer: pekka.jaaskelainen.
pekka.jaaskelainen added a comment.
This revision is now accepted and ready to land.
Perhaps the assert() is unneccessary, but otherwise LG
EricWF updated this revision to Diff 33235.
EricWF added a comment.
Address @mclow.lists note about consistency.
http://reviews.llvm.org/D11553
Files:
include/__functional_base
include/__functional_base_03
include/functional
test/std/utilities/function.objects/refwrap/refwrap.const/type
mclow.lists added inline comments.
Comment at: include/__functional_base:521
@@ +520,3 @@
+operator() (_ArgTypes&&... __args) const {
+return __invoke(get(), _VSTD::forward<_ArgTypes>(__args)...);
+}
I know you didn't change this, but how did we ge
EricWF updated this revision to Diff 33236.
EricWF added a comment.
Remove unused "CompileString" functions. The reason they can't be used to
implement `addWarningFlagIfSupported` is because we have to fuss with the flags
before invoking the compiler .
http://reviews.llvm.org/D11333
Files:
mclow.lists added a comment.
Everything except __functional_03 LGTM. That's not to say that that file has
problems, it's just that the diff display is not really helping :-)
http://reviews.llvm.org/D11553
___
cfe-commits mailing list
cfe-commits@
bkramer added a subscriber: bkramer.
bkramer added a comment.
Won't this do the wrong thing for embedded '\0' in a std::string?
std::string("hello\0world", 11).compare("hello")
should not return 0.
http://reviews.llvm.org/D12355
___
cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Ok, I think this is good to go. Thanks, Eric.
http://reviews.llvm.org/D11553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
mclow.lists added a comment.
I like this because it localizes the weirdness into one routine `self`.
If we can't get D12999 applied due to ABI concerns, this will help a bunch.
http://reviews.llvm.org/D12297
___
cfe-commits mailing list
cfe-commits@
EricWF added a comment.
In http://reviews.llvm.org/D12355#233477, @bkramer wrote:
> Won't this do the wrong thing for embedded '\0' in a std::string?
>
> std::string("hello\0world", 11).compare("hello")
>
>
> should not return 0.
Woops. Yep that seems correct but it will sure hamper the po
mclow.lists added a comment.
So... what do we need to do to enumerate the "ABI breakage" of this patch?
I get that there's a couple of member variables that are changing type. Can
they change (as a result of this patch) from a plain pointer to a fancy pointer
(or vice versa)? Can they change si
Author: ericwf
Date: Wed Aug 26 15:15:02 2015
New Revision: 246068
URL: http://llvm.org/viewvc/llvm-project?rev=246068&view=rev
Log:
[libcxx] Rewrite C++03 __invoke.
Summary:
This patch rewrites the C++03 `__invoke` and related meta-programming. There
are a number of major changes.
`__invoke` i
Author: ericwf
Date: Wed Aug 26 15:17:33 2015
New Revision: 246069
URL: http://llvm.org/viewvc/llvm-project?rev=246069&view=rev
Log:
[libcxx] Add special warning flag detection logic to compiler.py
Summary: Detecting `-Wno-` flags can be tricky with GCC (See
https://gcc.gnu.org/onlinedocs/gcc/Wa
Author: ericwf
Date: Wed Aug 26 15:18:21 2015
New Revision: 246070
URL: http://llvm.org/viewvc/llvm-project?rev=246070&view=rev
Log:
[libcxx] Remove installation rules on Darwin when it would overwrite the system
installation.
Summary:
On Mac OS X overwriting `/usr/lib/libc++.dylib` can cause yo
On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman
wrote:
> aaron.ballman created this revision.
> aaron.ballman added reviewers: rsmith, hans.
> aaron.ballman added a subscriber: cfe-commits.
>
> PR24559 brings up a long-standing issue in Clang where attribute order
> with differing syntax impacts
xazax.hun updated this revision to Diff 33239.
xazax.hun added a comment.
- Fine tuned the heuristics for cocoa APIs.
- Only track "nullable" and "contradicted" nullability for symbols. Use the
rest statically.
- Cleanups.
http://reviews.llvm.org/D11468
Files:
docs/analyzer/nullability.rst
mclow.lists added a comment.
In http://reviews.llvm.org/D12355#233477, @bkramer wrote:
> Won't this do the wrong thing for embedded '\0' in a std::string?
>
> std::string("hello\0world", 11).compare("hello")
>
>
> should not return 0.
Good point; I think that pretty much kills this propose
On Wed, Aug 26, 2015 at 4:30 PM, Richard Smith wrote:
> On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman
> wrote:
>>
>> aaron.ballman created this revision.
>> aaron.ballman added reviewers: rsmith, hans.
>> aaron.ballman added a subscriber: cfe-commits.
>>
>> PR24559 brings up a long-standing iss
zhengkai created this revision.
zhengkai added a reviewer: rtrieu.
zhengkai added a subscriber: cfe-commits.
Use a new algorithm to find map back the ranges to its spelling locations.
But the function is not working properly either, and it breaks a test.
In the last case in the test file
/llvm/
On Wed, Aug 26, 2015 at 1:55 PM, Aaron Ballman
wrote:
> On Wed, Aug 26, 2015 at 4:30 PM, Richard Smith
> wrote:
> > On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman >
> > wrote:
> >>
> >> aaron.ballman created this revision.
> >> aaron.ballman added reviewers: rsmith, hans.
> >> aaron.ballman ad
yiranwang added a comment.
In http://reviews.llvm.org/D12247#233349, @EricWF wrote:
> In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
>
> > We certainly need a fix without breaking ABI. Is there a ABI conformance
> > test for libcxx?
>
>
> Well this patch definitely breaks the ABI. Thi
eugenis removed rL LLVM as the repository for this revision.
eugenis updated this revision to Diff 33246.
eugenis added a comment.
Introduced cmake options for specifying the desired ABI version.
ABI version affects library soname and include path (include/c++/vN).
Baked ABI version into the heade
Author: rksimon
Date: Wed Aug 26 16:17:12 2015
New Revision: 246083
URL: http://llvm.org/viewvc/llvm-project?rev=246083&view=rev
Log:
[X86][SSE] Add _mm_undefined_* intrinsics
Added missing SSE/AVX 'undefined' intrinsics (PR24040):
_mm_undefined_pd, _mm_undefined_ps + _mm_undefined_si128
_mm256_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246083: [X86][SSE] Add _mm_undefined_* intrinsics (authored
by RKSimon).
Changed prior to commit:
http://reviews.llvm.org/D12052?vs=32514&id=33249#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12
yiranwang added a comment.
some more explanation of last comment.
For most architecture sizeof(function) is 4*sizeof(void *), but it is
6*sizeof(void*) on AARCH64/LINUX, which does not sound so great as there are
padding of 2*sizeof(void*) bytes.
http://reviews.llvm.org/D12247
_
eugenis added a comment.
> How long is a major and minor ABI version supported?
We don't want to bump major version too often, and we want to support both +1
and -1 of the current major version, along with all possible minor versions.
> When is the major and minor ABI version bumped?
See Abi
xazax.hun created this revision.
xazax.hun added reviewers: krememek, zaks.anna, jordan_rose, dcoughlin.
xazax.hun added a subscriber: cfe-commits.
This patch merged the functionality from ObjCGenericsChecker into
DynamicTypePropagation checker.
Note that the Generics Checker can still be turned
EricWF updated this revision to Diff 33252.
EricWF added a comment.
Instead of optimizing away the length calculation, this patch still performs it
but uses the calculated length to return early if the two strings differ in
length.
http://reviews.llvm.org/D12355
Files:
include/string
Index
EricWF updated this revision to Diff 33253.
EricWF added a comment.
Fix debug assertion.
http://reviews.llvm.org/D12355
Files:
include/string
Index: include/string
===
--- include/string
+++ include/string
@@ -3795,7 +3795,10 @@
--> lists.llvm.org
-- Forwarded message --
From: Ettore Speziale
Date: 26 August 2015 at 14:35
Subject: Re: [PATCH] __attribute__((enable_if)) and non-overloaded member
functions
To: Nick Lewycky
Cc: llvm cfe
Hello,
> Sorry about the extreme delay. This patch slipped through
Forward to the right ML:
>> Sorry about the extreme delay. This patch slipped through the cracks, and I
>> only noticed it again when searching my email for enable_if. Committed in
>> r245985! In the future, please feel free to continue pinging weekly!
>
> NP, thank you for committing the patch
EricWF added a comment.
In http://reviews.llvm.org/D12247#233595, @yiranwang wrote:
> In http://reviews.llvm.org/D12247#233349, @EricWF wrote:
>
> > In http://reviews.llvm.org/D12247#233323, @davidxl wrote:
> >
> > > We certainly need a fix without breaking ABI. Is there a ABI conformance
> > >
Author: rnk
Date: Wed Aug 26 16:57:20 2015
New Revision: 246088
URL: http://llvm.org/viewvc/llvm-project?rev=246088&view=rev
Log:
[ms-inline-asm] Add field access to MS inline asm identifier lookup
Now we can parse code like this:
struct A {
int field;
};
int f(A o) {
__asm mov eax,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246090: Add a clang release note about raising the minimum
Windows version for the… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D12368?vs=33208&id=33255#toc
Repository:
rL LL
hans added a comment.
Committed in r246090.
http://reviews.llvm.org/D12368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mzolotukhin added a comment.
Hi,
I implemented builtin-based version in http://reviews.llvm.org/D12313 - could
you please take a look?
Thanks,
Michael
http://reviews.llvm.org/D12221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: lcharles
Date: Wed Aug 26 17:13:30 2015
New Revision: 246093
URL: http://llvm.org/viewvc/llvm-project?rev=246093&view=rev
Log:
Corrected 3 typos. NFC
Modified:
cfe/trunk/lib/AST/Type.cpp
Modified: cfe/trunk/lib/AST/Type.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/
eugenis created this revision.
eugenis added reviewers: mclow.lists, EricWF, rsmith.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
This goes with the ABI versioning support in libc++ in
http://reviews.llvm.org/D11740
Repository:
rL LLVM
http
Author: ab
Date: Wed Aug 26 17:21:07 2015
New Revision: 246094
URL: http://llvm.org/viewvc/llvm-project?rev=246094&view=rev
Log:
[ARM] Mark mcr/mrc builtin operands as required-immediate.
An early error message is better than the "cannot select" alternative.
Modified:
cfe/trunk/include/clang
Author: dexonsmith
Date: Wed Aug 26 17:21:09 2015
New Revision: 246095
URL: http://llvm.org/viewvc/llvm-project?rev=246095&view=rev
Log:
DI: Clarify meaning of createTempFunctionFwdDecl() arg, NFC
I stared at `false /*declaration*/` for quite some time before giving up
and checking the actual fun
eugenis created this revision.
eugenis added reviewers: EricWF, mclow.lists.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
With http://reviews.llvm.org/D11740, libc++ headers can not be used from the
libc++ source directly, because they include
yiranwang added a comment.
Hi Eric,
Could you please explain a bit more what is broken specifically? As we can see,
sizeof(), _Len, and _Align, and alignof() of "aligned_storage" are all not
changed.
http://reviews.llvm.org/D12247
___
cfe-commits
jroelofs added a subscriber: jroelofs.
Comment at: lib/Driver/ToolChains.cpp:3535
@@ -3534,1 +3534,3 @@
+static std::string DetectLibcxxIncludePath(const std::string &base) {
+ std::error_code EC;
StringRef instead?
Comment at: lib/Driver/Tool
eugenis removed rL LLVM as the repository for this revision.
eugenis updated this revision to Diff 33259.
http://reviews.llvm.org/D12382
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/basic_linux_libcxxv2_tree/usr/bin/.keep
test/Driver/Inputs/basic_linux_libcxxv2_tree/usr/include/c++/v
eugenis marked 2 inline comments as done.
eugenis added a comment.
http://reviews.llvm.org/D12382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
In http://reviews.llvm.org/D12247#233717, @yiranwang wrote:
> Hi Eric,
>
> Could you please explain a bit more what is broken specifically? As we can
> see, sizeof(), _Len, and _Align, and alignof() of "aligned_storage" are all
> not changed.
That's correct. At the ris
Prazek created this revision.
Prazek added reviewers: rsmith, majnemer, rjmccall.
Prazek added a subscriber: cfe-commits.
It wasn't always safe to generate assumption loads. Last time build failed on
linking of classes like FenceInst because
it didn't introduce any new virtual function, and it ha
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks good overall. I might have additional post-commit comments.
http://reviews.llvm.org/D11468
___
cfe-commits mailing list
cfe-commits@l
rsmith added inline comments.
Comment at: include/clang/Basic/Builtins.def:1249-1255
@@ +1248,9 @@
+BUILTIN(__builtin_nontemporal_store, "v.", "t")
+BUILTIN(__builtin_nontemporal_store_1, "vcc*.", "")
+BUILTIN(__builtin_nontemporal_store_2, "vss*.", "")
+BUILTIN(__builtin_nontempo
Author: dexonsmith
Date: Wed Aug 26 17:50:48 2015
New Revision: 246099
URL: http://llvm.org/viewvc/llvm-project?rev=246099&view=rev
Log:
DI: Update DISubprogram testcases after LLVM r246098
Modified:
cfe/trunk/test/CodeGen/debug-info-scope-file.c
cfe/trunk/test/CodeGenCXX/PR20038.cpp
1 - 100 of 131 matches
Mail list logo
