jroelofs added a subscriber: jroelofs.
================
Comment at: lib/Driver/ToolChains.cpp:3535
@@ -3534,1 +3534,3 @@
+static std::string DetectLibcxxIncludePath(const std::string &base) {
+ std::error_code EC;
----------------
StringRef instead?
================
Comment at: lib/Driver/ToolChains.cpp:3564
@@ -3544,3 +3563,3 @@
// The primary location is within the Clang installation.
// FIXME: We shouldn't hard code 'v1' here to make Clang future proof
to
// newer ABI versions.
----------------
Kill the FIXME while you're here fixing what the FIXME complains about.
Repository:
rL LLVM
http://reviews.llvm.org/D12382
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
