berenm added a comment.

Actually, I think there is a bug in the assignment alignment code. Even without 
this patch, this code doesn't align properly:

  int oneTwoThree = 123;
  int oneTwo      = 12;
  method();

I don't think I completely understand the assignment alignment code, and that's 
why mine is slightly rewritten. I will open another request for fixes in the 
assignment alignment code.


================
Comment at: unittests/Format/FormatTest.cpp:8619
@@ -8618,1 +8618,3 @@
 
+TEST_F(FormatTest, AlignConsecutiveDeclarations) {
+  FormatStyle Alignment = getLLVMStyle();
----------------
djasper wrote:
> This needs tests that check what happens if both declarations and assignments 
> are aligned.
Indeed, I will add such tests.


http://reviews.llvm.org/D12362



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to