jroelofs added a comment. the `addWarningFlagIfSupported` part of this patch LGTM.
================ Comment at: test/libcxx/compiler.py:88 @@ -87,1 +87,3 @@ + def compileString(self, source, out=None, flags=[], env=None, cwd=None): + cmd = self.compileCmd('-', out, flags) ---------------- this looks unused to me. ================ Comment at: test/libcxx/compiler.py:105 @@ -98,1 +104,3 @@ + def compileLinkString(self, source, out=None, flags=[], env=None, cwd=None): + cmd = self.compileLinkCmd('-', out, flags) ---------------- this looks unused to me. http://reviews.llvm.org/D11333 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits