[PATCH] D158755: [Driver] Make "-fno-split-machine-functions" a valid flag for all archs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b27167a57c5: [Driver] Make "-fno-split-machine-functions" a valid flag for all archs (authored by shenhan). Repository: rG LLVM Github Monorepo

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:19 +// RUN: not %clang -### -x cuda -S -nocudainc -nocudalib -fsplit-machine-functions %s 2>&1 | FileCheck %s --check-prefix=ERR2 +// ERR2: clang: error: unsupported option '-fsplit-machine-f

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553256. shenhan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsp

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan added a comment. In D158755#4614566 , @MaskRay wrote: > Thanks for the patch. We need a test. I cleaned up > `fsplit-machine-functions.c` a bit. You can rebase and modify the `not %clang > -### -c --target=arm-unknown-linux -fsplit-machine-funct

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan updated this revision to Diff 553219. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158755/new/ https://reviews.llvm.org/D158755 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsplit-machine-functions.c Index: clang/tes

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan created this revision. shenhan added a reviewer: MaskRay. Herald added a subscriber: pengfei. Herald added a project: All. shenhan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, when clang reports an error when -fno-spl

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions M

[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d079d6188b: [clang][test] Refine clang machine-function-split tests. (authored by shenhan). Herald added subscribers: cfe-commits, mattd, asavonic.

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551680. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551634. shenhan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:1 +// REQUIRES: system-linux +// REQUIRES: x86-registered-target MaskRay wrote: > Any reason `system-linux` is needed? Deleted. Also deleted "REQUIRES: system-linux" from "f

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551632. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551630. shenhan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan marked an inline comment as done. shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s ---

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551583. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s MaskRay wrote: > `-target ` has

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551332. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added a comment. Thanks all. Created D158231 to address the post-submit comments and added all as reviewers. @MaskRay @Hahnfeld @steelannelida Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ h

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan created this revision. shenhan added reviewers: MaskRay, Hahnfeld, steelannelida. Herald added subscribers: mattd, asavonic. Herald added a project: All. shenhan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG317a0fe5bd71: [Driver][CodeGen] Properly handle -fsplit-machine-functions for fatbinary… (authored by shenhan). Repository: rG LLVM Github Monorep

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added a comment. In D157750#4593582 , @dhoekwater wrote: > This patch will make it difficult to write tests for MFS on AArch64 before it > is officially enabled. Currently, because clang performs the Triple check, we > can use `-enable-split-ma

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550913. shenhan added a comment. Refined the test case a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550885. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/test

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: llvm/test/CodeGen/X86/mfs-triple.ll:8 + +define void @foo4(i1 zeroext %0, i1 zeroext %1) nounwind { + br i1 %0, label %3, label %7 shenhan wrote: > snehasish wrote: > > Any reason why we can't use the bitcode already in

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550834. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/li

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan marked 3 inline comments as done. shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass()); -

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550423. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/li

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan marked an inline comment as done. shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 +else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } arsenm wrote: > she

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/test

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions t

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass()); snehasish wrote: > Can you

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions t

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan created this revision. shenhan added reviewers: xur, snehasish. Herald added subscribers: mattd, asavonic, pengfei, hiraditya. Herald added a project: All. shenhan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang,

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

shenhan added a comment. In D85408#2253055 , @MaskRay wrote: > I am still reading the patch, but I have noticed one thing worth discussing. > `.bb_addr_map` is a non-SHF_ALLOC section (meaning that it is not part of the > memory image). An absolute reloc

[PATCH] D68049: Propeller: Clang options for basic block sections

shenhan added inline comments. Comment at: lld/ELF/LTO.cpp:80 // Check if basic block sections must be used. // Allowed values for --lto-basicblock-sections are "all", "labels", // "", or none. This is the equivalent Maybe "--lto-basicblock-sections" sh

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

shenhan added a comment. Ping? Can we make a decision on this? I've this simple one D35849: [UBSan] Provide default blacklist filename for UBSan which, depending on this, shall be discarded or move forward. If this CL stalls, I'll seek to proceed with https://r

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

shenhan added a comment. Thanks for pointing out the relevant CLs. I agree that's the clearer and better solution. (The only concern is that it has been sitting there for 2 months. I'll check back.) In https://reviews.llvm.org/D35849#820473, @vsk wrote: > This won't do the right thing if more

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

shenhan added a comment. Thanks. Can you update "SanitizerArgs::collectDefaultBlacklists" to include "ubsan_blacklist.txt"? https://reviews.llvm.org/D32842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

shenhan created this revision. This is to provide a default blacklist filename for UBSan. While UBSan is turned on, it's better that clang pick up a blacklist file (when exists), just as what ASan / MSan does, so we do not end up adding the "-fsanitize-blacklist" option to every command line.