shenhan marked an inline comment as done. shenhan added inline comments.
================ Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 + else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } ---------------- arsenm wrote: > shenhan wrote: > > arsenm wrote: > > > You cannot spam warnings here. The other instance of printing here looks > > > like a new addition and should be removed > > Thanks. Do you suggest moving the warnings to the underlying pass? > > (Although that means we create passes that only issue warnings.) > Move it to the pass, and use a backend remark, not directly print to the > console (e.g. DiagnosticInfoUnsupported) Thanks, created DiagnosticInfoMachineFunctionSplit and moved the warning to MFS pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
