shenhan marked an inline comment as done. shenhan added inline comments.
================ Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s ---------------- MaskRay wrote: > shenhan wrote: > > MaskRay wrote: > > > `-target ` has been deprecated since Clang 3.4. Use `--target=` > > > > > > > > > The warning test should be moved to `Driver/`. > > > Whenever a warning can be placed either in Driver or in Frontend, we > > > prefer Driver. > > > -target has been deprecated since Clang 3.4. Use --target= > > > > Replaced with --target=arm-unknown-linux-gnueabi > > > > > Whenever a warning can be placed either in Driver or in Frontend, we > > > prefer Driver. > > > > Just a little bit confused, you mentioned in [the other > > comment](https://reviews.llvm.org/D157750#inline-1530250) that `Driver > > tests should not run the backend. Most driver commands should use -###.` > > And the warning to be tested here is issued from backend, so -### does not > > trigger it at all, so I moved the tests from Driver/ to here . Do you > > suggest move these back to Driver/? > `test/Driver` tests `%clang -###` and driver options. > > Other directories (e.g. `test/CodeGen`) test `%clang_cc1` and CC1 options. > `%clang ` is discouraged. Thanks. Now test/CodeGen/ tests are using %clang_cc1 and test/Driver/ tests are using %clang -###. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
