shenhan added a comment.

Thanks for pointing out the relevant CLs. I agree that's the clearer and better 
solution.

(The only concern is that it has been sitting there for 2 months. I'll check 
back.)

In https://reviews.llvm.org/D35849#820473, @vsk wrote:

> This won't do the right thing if more than one sanitizer with a default 
> blacklist is enabled. It's also problematic that a default blacklist for one 
> sanitizer can blacklist code for a different sanitizer. See:
>
> https://reviews.llvm.org/D32043
>  https://reviews.llvm.org/D32047
>  https://reviews.llvm.org/D32842
>
> IMO I think https://reviews.llvm.org/D32842 is the right path forward. I 
> don't have the time to get back to it this week, but if you'd like to pick it 
> up and respond to review feedback from @eugenis, please do (I can certainly 
> help with the review).





https://reviews.llvm.org/D35849



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to