[PATCH] D126586: [InstrProf] Single byte counters in coverage

ayzhao added a comment. In D126586#4622003 , @gulfem wrote: > Fixed the issue that causes a crash in InstCombinePHI.cpp. Phi instructions > need to be inserted at the beginning of basic blocks, and profile increments > need to be inserted after phis for

[PATCH] D126586: [InstrProf] Single byte counters in coverage

ayzhao added a comment. Thanks for your work on this! FYI, I'm getting the following crash when I try to build Chrome's base_unittests with `-mllvm -enable-single-byte-coverage=true`: [195/4447] CXX obj/base/allocator/partition_allocator/allocator_core/pcscan_internal.o FAILED: obj/base/a

[PATCH] D155523: [clang] Fix a crash when casting to an array type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0116aba833: [clang] Fix a crash when casting to an array type (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D155523: [clang] Fix a crash when casting to an array type

ayzhao updated this revision to Diff 541588. ayzhao marked an inline comment as done. ayzhao added a comment. quote C++20 standard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155523/new/ https://reviews.llvm.org/D155523 Files: clang/docs/Relea

[PATCH] D155523: [clang] Fix a crash when casting to an array type

ayzhao created this revision. ayzhao added a reviewer: aaron.ballman. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In C++20, if Clang fails to perform constructor overload on a RecordType, then Clang w

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao accepted this revision. ayzhao added a comment. This revision is now accepted and ready to land. In D150122#4388978 , @ayzhao wrote: > In D150122#4388972 , @cor3ntin > wrote: > >> I guess we should land th

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao added a comment. In D150122#4388972 , @cor3ntin wrote: > I guess we should land that now @erichkeane ? Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We shou

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cf5188c7290: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate… (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

ayzhao updated this revision to Diff 527099. ayzhao added a comment. rebasing, CI seems to be fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151763/new/ https://reviews.llvm.org/D151763 Files: clang/docs/ReleaseNotes.rst clang/lib/Sem

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

ayzhao updated this revision to Diff 526858. ayzhao added a comment. rebase to see if this fixes CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151763/new/ https://reviews.llvm.org/D151763 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Se

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

ayzhao created this revision. ayzhao added a reviewer: shafik. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The previous code incorrectly assumed that we would never call warnBracedScalarInit(...) with

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao added a subscriber: shafik. ayzhao added a comment. Status update on backports: - https://github.com/llvm/llvm-project/issues/62266 has been backported in https://github.com/llvm/llvm-project-release-prs/pull/441 - https://github.com/llvm/llvm-project/issues/61567 is still waiting on @sha

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d35f04c6cb: [clang] Fix initializer_list matching failures with modules (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao updated this revision to Diff 520744. ayzhao added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 Files: clang/include/clang/AST/DeclBase.h clang/lib/Sema/SemaDeclCXX.cpp c

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao added a comment. In D150122#4329401 , @aaron.ballman wrote: > I believe we are having another release of Clang 16, but @tstellar can > confirm or deny that. > > AIUI, there were a few issues holding us back from claiming complete support > (adde

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao updated this revision to Diff 520429. ayzhao marked an inline comment as done. ayzhao added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 Files: clang/include/clang/AST/D

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, if a class with a defined public virtual destructor is declared before including and initializer_list is provided

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b4faa11c68b: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate… (authored by ayzhao). Repository: rG LLVM Github Monorepo

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 518479. ayzhao added a comment. rebase + fix merge conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0089c99ba1: [clang] Fix default initializers being ignored when initializing templated… (authored by ayzhao). Repository: rG LLVM Github Monorep

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao added a comment. In D149389#4303966 , @shafik wrote: > So the change makes sense but the original issue: > https://github.com/llvm/llvm-project/issues/62266 it worked for the first > once but not the second, it also worked for the non-paren aggre

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao updated this revision to Diff 518054. ayzhao added a comment. rebase + add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149389/new/ https://reviews.llvm.org/D149389 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaIn

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 518044. ayzhao added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out that FieldDecl::getInClassInitializer() will return nullptr for default member initializers if the field is part

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517699. ayzhao marked an inline comment as done. ayzhao added a comment. code review comments + pull in D149301 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https:

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7417e9d75c9a: [clang] Fix a crash with parenthesized aggregate initialization and base classes (authored by ayzhao). Repository: rG LLVM Github Mo

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao added a comment. In D149301#4302621 , @aaron.ballman wrote: > I think you should add a release note for this when landing, Done > and this seems pretty reasonable to consider backporting to 16.x, WDYT? Agreed, given that this is a crash. Repo

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao updated this revision to Diff 517636. ayzhao added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149301/new/ https://reviews.llvm.org/D149301 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.cpp c

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When calling InitializeBase(...), TryOrBuidlParenListInit(...) needs to pass in the parent entity; otherwise, we erroneously t

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517250. ayzhao added a comment. add another test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/incl

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517249. ayzhao added a comment. add another test and fix whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKi

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5364-5368 if (const ConstantArrayType *CAT = S.getASTContext().getAsConstantArrayType(Entity.getType())) ArrayLength = CAT->getSize().getZExtValue(); else ArrayLength = Args

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 517246. ayzhao marked 5 inline comments as done. ayzhao added a comment. code review comments + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/i

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 514425. ayzhao marked 3 inline comments as done. ayzhao added a comment. code review comments + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/i

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 514389. ayzhao marked an inline comment as done. ayzhao added a comment. remove unrelated formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: c

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 514291. ayzhao added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 513808. ayzhao added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/include/clang/Sema/Initialization.h:509 bool isImplicitMemberInitializer() const { -return getKind() == EK_Member && Variable.IsImplicitFieldInit; +return (getKind() == EK_Member || getKind() == EK_ParenAggInitMember) &&

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 513805. ayzhao marked 7 inline comments as done. ayzhao added a comment. Address code review comments and (try) to fix Windows bot failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://review

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2130 + "initializer|a related result|a parameter of CF audited function|a " + "structured binding|a member subobject}0 " "%diff{of type $ with an %select{rvalue|lvalue}2 of type $|" --

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 513377. ayzhao added a comment. fix missing EOF newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, initialized class members would have the LifetimeKind LK_MemInitializer, which does not allow for binding a

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG7df3c71b508b: [clang] Fix 2 bugs with parenthesized aggregate initialization (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 509160. ayzhao marked an inline comment as done. ayzhao added a comment. fix stray whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao marked 2 inline comments as done. ayzhao added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1582-1596 + MultiExprArg ExprsToPass; + if (Exprs.size() == 1 && isa(Exprs[0])) { +// C++20 [expr.static.cast]p4: +// An expression E can be explicitly co

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 509158. ayzhao added a comment. use ParenListExpr and fix getSubExprAsWritten(...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib/AST/Expr.cpp cl

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1582-1596 + MultiExprArg ExprsToPass; + if (Exprs.size() == 1 && isa(Exprs[0])) { +// C++20 [expr.static.cast]p4: +// An expression E can be explicitly converted to a type T...if T is an +//

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 506755. ayzhao added a comment. remove extra semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaIni

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 506754. ayzhao added a comment. clean up test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaInit.cpp c

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fix an issue where temporaries initialized via parenthesized aggregate initialization don't get destroyed. - Fix an issue w

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ayzhao added a comment. Thanks for your effort on this! FYI I landed parenthesized aggregate initialization in D141546 , so CTAD for that feature should no longer be blocked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D141546: [clang] Reland parenthesized aggregate init patches

This revision was automatically updated to reflect the committed changes. Closed by commit rG95a4c0c83554: [clang] Reland parenthesized aggregate init patches (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141546/new/ https://re

[PATCH] D141546: [clang] Reland parenthesized aggregate init patches

ayzhao updated this revision to Diff 488486. ayzhao added a comment. fix spelling + improve diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141546/new/ https://reviews.llvm.org/D141546 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6198-6199 + dyn_cast(DestType->getAs()->getDecl()); + S.getLangOpts().CPlusPlus20 && RD && RD->isAggregate() && Failed() && + getFailureKind() == FK_ConstructorOverloadFailed &&

[PATCH] D141546: [clang] Reland parenthesized aggregate init patches

ayzhao created this revision. ayzhao added a reviewer: ilya-biryukov. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. T

[PATCH] D140159: [clang][nfc] Fixes for D129531

ayzhao abandoned this revision. ayzhao added a comment. Abandoning as the underlying commit was reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140159/new/ https://reviews.llvm.org/D140159 ___ cf

[PATCH] D140327: [clang] Remove overly restrictive aggregate paren init logic

This revision was automatically updated to reflect the committed changes. Closed by commit rGc77a91bb7ba7: [clang] Remove overly restrictive aggregate paren init logic (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140327/new/ h

[PATCH] D140327: [clang] Remove overly restrictive aggregate paren init logic

ayzhao created this revision. ayzhao added a reviewer: ilya-biryukov. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, we would only attempt to perform a parenthesized aggregate initialization

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao marked 3 inline comments as done. ayzhao added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:4760 + : Expr(CXXParenListInitExprClass, T, + T->isLValueReferenceType() ? VK_LValue + : T->isRValueReferenceType() ? VK_XValue

[PATCH] D140159: [clang][nfc] Fixes for D129531

ayzhao created this revision. ayzhao added a reviewer: shafik. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Additional fixes for review comments made in https://reviews.llvm.org/D129531 after the patch

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40c52159d3ee: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a… (authored by ayzhao). Repository: rG LLVM Github Monorepo

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 482862. ayzhao marked an inline comment as done. ayzhao added a comment. use getFailureKind() + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/d

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. In D129531#3990050 , @ayzhao wrote: > In D129531#3988996 , @ilya-biryukov > wrote: > >> Since the errors only shows up in modular builds, I would look closely for >> bugs inside `ASTReade

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 482566. ayzhao added a comment. fix memory access issues identified by UBSan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. In D129531#3988996 , @ilya-biryukov wrote: > Since the errors only shows up in modular builds, I would look closely for > bugs inside `ASTReader`/`ASTWriter`. > Also, it seems that `ArrayFiller` is not taken in to account in >

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 482261. ayzhao added a comment. rebase + some compiler warning fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/inclu

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} ilya-biryukov wrote: > ayzhao wrote: > > ayzhao wrote: > > > So the libc++ test compile failures are due to this line. > >

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 481700. ayzhao marked 6 inline comments as done. ayzhao added a comment. address comments + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/AST/JSONNodeDumper.cpp:852 case VarDecl::ListInit: JOS.attribute("init", "list"); break; +case VarDecl::ParenListInit: + JOS.attribute("init", "paren-list"); ilya-biryukov wrote: > ayzhao wrote: >

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} ayzhao wrote: > So the libc++ test compile failures are due to this line. > > One example of a failing unit test is > [r

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 481508. ayzhao added a comment. rebase + (hopefully) fix libc++ c++2b test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rs

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} So the libc++ test compile failures are due to this line. One example of a failing unit test is [range.take.while/ctor.v

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/test/CXX/class/class.compare/class.spaceship/p1.cpp:106 Cmp() <=> Cmp(), // expected-note-re {{in defaulted three-way comparison operator for '{{.*}}Cmp<{{.*}}G2>' first required here}}j - // expected-error@#cmp {{no ma

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480596. ayzhao marked 3 inline comments as done. ayzhao added a comment. restore original diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/do

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480189. ayzhao marked 2 inline comments as done. ayzhao added a comment. add missing EOF newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/Re

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:581 + Expr *filler = nullptr; + if (auto *ILE = dyn_cast(ExprToVisit)) +filler = ILE->getArrayFiller(); ayzhao wrote: > ilya-biryukov wrote: > > ilya-biryukov wrote: > > > ayzhao wrot

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480184. ayzhao added a comment. use NumUserSpecifiedExprs instead of syntatic/semantic forms, also address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D12953

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao marked 4 inline comments as done. ayzhao added a comment. In D129531#3971392 , @ilya-biryukov wrote: > Thanks! > > I have two major comments and also inline NITs. Not sure if we should block > on those, just wanted to hear your opinions: > > - `I

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:581 + Expr *filler = nullptr; + if (auto *ILE = dyn_cast(ExprToVisit)) +filler = ILE->getArrayFiller(); ilya-biryukov wrote: > ilya-biryukov wrote: > > ayzhao wrote: > > > ilya-biryuk

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 479758. ayzhao marked 2 inline comments as done. ayzhao added a comment. implement CXXDefaultInitExpr and ImplicitValueInitExpr, array fillers, and semantic vs syntatic forms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/AST/JSONNodeDumper.cpp:852 case VarDecl::ListInit: JOS.attribute("init", "list"); break; +case VarDecl::ParenListInit: + JOS.attribute("init", "paren-list"); ilya-biryukov wrote: > NIT: maybe use t

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 476625. ayzhao marked 9 inline comments as done. ayzhao added a comment. address code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/do

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

ayzhao added a comment. In D133757#3916040 , @sammccall wrote: > In D133757#3916028 , @nridge wrote: > >> In D133757#3915995 , @ayzhao wrote: >> >>> This change is causing

[PATCH] D137674: [clangd] Make system-include-extractor.test more resilient in the face of paths with special characters

ayzhao accepted this revision. ayzhao added a comment. Thanks for the quick fix! I patched this in and I can confirm it fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137674/new/ https://reviews.llvm.org/D137674 __

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

ayzhao added a comment. This change is causing system-include-extractor.test to fail on Chrome: https://crbug.com/1382508 The test fails on this assertion

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473789. ayzhao added a comment. s/pro20/post20/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473779. ayzhao added a comment. remove extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473772. ayzhao added a comment. whoops, uploaded the wrong commit. should be fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Friendly ping, does anyone else have any more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 ___ cfe-commits mailing list cfe

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473746. ayzhao added a comment. rebase + update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang/AST/Decl.h clang/include/

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 472702. ayzhao marked 3 inline comments as done. ayzhao added a comment. addressed code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 472441. ayzhao marked an inline comment as done. ayzhao added a comment. Merge CXXParenListInitExpr with VisitInitListExpr, also friendly ping as all comments are addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 472405. ayzhao added a comment. clang-format + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Inde

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Status update: While investigating @cor3ntin's comment about refactoring `VisitInitListExpr` and `VisitCXXParenListInitExpr` as they share common code, I discovered that flexible array members would cause this patch to explode. Specifically, the following code: struc

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 472190. ayzhao marked 6 inline comments as done. ayzhao added a comment. address some comments and implement disallowing flexible array members Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://r

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Friendly ping for reviewers as all comments should be addressed by now. In D129531#3873775 , @cor3ntin wrote: > It starting to look great. > Should we add an extension warning? Note that I'm not suggesting to support > that in ea

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471694. ayzhao marked 2 inline comments as done. ayzhao added a comment. add C++20 extension diagnostics and some other code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://revi

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471338. ayzhao added a comment. we don't need CHECK-DAG here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. In D129531#3880875 , @ayzhao wrote: > In D129531#3873872 , @royjacobson > wrote: > >> Thanks for working on it! It looks really good. Please remember to update >> the feature test macro (

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471329. ayzhao marked 11 inline comments as done. ayzhao added a comment. Fix PCH test and address some code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D12

  1   2   3   >