ayzhao marked 3 inline comments as done. ayzhao added inline comments.
================ Comment at: clang/include/clang/AST/ExprCXX.h:4760 + : Expr(CXXParenListInitExprClass, T, + T->isLValueReferenceType() ? VK_LValue + : T->isRValueReferenceType() ? VK_XValue ---------------- shafik wrote: > It looks like we use this idiom in several places, it may be worth it to sink > this as a member function of `QualType` note: this patch was already merged, so I created a new patch addressing the revisions at D140159 It turns out there's a method `getValueKindForType(...)` that does the exact same thing, so I used that instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
