ayzhao added a comment. Friendly ping for reviewers as all comments should be addressed by now.
In D129531#3873775 <https://reviews.llvm.org/D129531#3873775>, @cor3ntin wrote: > It starting to look great. > Should we add an extension warning? Note that I'm not suggesting to support > that in earlier modes, just an off-by-default warning that says "this is a > c++20 feature". but we are a bit inconsistent with those. Done > can you rename `test/SemaCXX/P0960R3.cpp` to something like > `test/SemaCXX/cxx20-paren-list-init.cpp` (and same for other tests?) it's > more consistent with other existing tests. Done ================ Comment at: clang/lib/Sema/SemaInit.cpp:5263 +static void TryOrBuildParenListInitialization( + Sema &S, const InitializedEntity &Entity, const InitializationKind &Kind, ---------------- shafik wrote: > I feel like this function could use a lot of comments, I found it hard to > follow the flow of logic and I think I get it mostly now but comments would > have helped a lot. I added some comments, did a little refactoring, and renamed some variables. PTAL and LMKWYT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
