[clang-tools-extra] d12c471 - [clang-tidy] Modernize ClangTidyValue (NFC)

Author: Kazu Hirata Date: 2023-04-25T23:58:24-07:00 New Revision: d12c471b892d2eb3087f7b1f8e13516122535966 URL: https://github.com/llvm/llvm-project/commit/d12c471b892d2eb3087f7b1f8e13516122535966 DIFF: https://github.com/llvm/llvm-project/commit/d12c471b892d2eb3087f7b1f8e13516122535966.diff L

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

phosek added a comment. Supporting only a single tool and simplifying the script would be my preference as well. I see that the script already supports `llvm-readobj`, do we need the `llvm-nm` support in that case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 517041. VincentWu marked 18 inline comments as done. VincentWu added a comment. address comments check invalid `mvsa01 s0, s0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.or

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:859 + // The rest is a simplified version of TestTU::build(). + // Don't call TestTU::build() itself because it would assert on + // failure to build an AST. (I cou

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517070. chaitanyav added a comment. Herald added a subscriber: arphaman. Fix more failing tests due to missing parentheses in conditional operator expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge created this revision. nridge added reviewers: hokein, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The previous

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl added a comment. In D149123#4294619 , @mingmingl wrote: > While testing this patch with `./bin/clang -cc1 -S -triple=aarch64 > inline-asm-aarch64-flag-output.c` (which invokes global-isel for instruction > selection according to `print-after-a

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

mingmingl updated this revision to Diff 517062. mingmingl marked 3 inline comments as done. mingmingl edited the summary of this revision. mingmingl added a comment. update on the crashing issue (solved) resolve comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149123/new/ https:

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. Ping for reivew. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D148457: [clangd] Support macro evaluation on hover

nridge added a comment. Thanks for the patch and the thorough testcase! I wonder if we should make this a bit more strict: if the macro expansion itself is an expression, show the value of //that// expression, but not e.g. an enclosing expression. Otherwise, the `Definition` field of the hover

[PATCH] D148987: [clang][Interp] Check Neg ops for errors

tbaeder updated this revision to Diff 517054. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148987/new/ https://reviews.llvm.org/D148987 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/PrimType.h clang/test/AST/Interp/literals.cpp Index

[PATCH] D149154: [clang][Interp] Emit diagnostic when comparing function pointers

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:652-653 + const SourceInfo &Loc = S.Current->getSource(OpPC); + S.FFDiag(Loc, diag::note_constexpr_pointer_comparison_unspecified) + << LS << RS; + return false; aaron.ballman wrote:

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. In D147610#4297533 , @joshua-arch1 wrote: >> The RVI toolchain SIG is supposed to be setting up a task group to define >> intrinsics for all extensions. > > Where should I discuss this intrinsic issue right now? I guess ht

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 517044. tejohnson added a comment. Remove extraneous call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm.org/D149215 Files: clang/test/CodeGen/thinlto-distributed-supports-h

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 517043. tejohnson added a comment. Rebase onto latest D149117 to remove extraneous test diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. Added parentheses to lots of files to fix the precedence warning. Still a lot to change in OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 517042. chaitanyav added a comment. Herald added subscribers: jplehr, kosarev, jdoerfert, sstefan1, kerbowa, jvesely. Herald added a reviewer: jdoerfert. Fix tests/code by adding parentheses around the conditional operator expression Repository: rG LLV

[clang] e037880 - [clang-repl] Only enable dynamic-library test on x86_64

Author: Anubhab Ghosh Date: 2023-04-26T09:46:38+05:30 New Revision: e037880b8eff2b425ff80ea9d6337fda27a64337 URL: https://github.com/llvm/llvm-project/commit/e037880b8eff2b425ff80ea9d6337fda27a64337 DIFF: https://github.com/llvm/llvm-project/commit/e037880b8eff2b425ff80ea9d6337fda27a64337.diff

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper requested changes to this revision. craig.topper added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:853 Error RISCVISAInfo::checkDependency() { + bool HasC = Exts.count("c") != 0; bool HasD = Exts.

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 ___

[PATCH] D148992: [clang-repl] Fix dynamic library test to avoid cstdio and linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f96ce5e133b: [clang-repl] Fix dynamic library test to avoid cstdio and linker (authored by argentite). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148992/

[clang] 7f96ce5 - [clang-repl] Fix dynamic library test to avoid cstdio and linker

Author: Anubhab Ghosh Date: 2023-04-26T09:11:09+05:30 New Revision: 7f96ce5e133be54891af177adbf8952d413e0f85 URL: https://github.com/llvm/llvm-project/commit/7f96ce5e133be54891af177adbf8952d413e0f85 DIFF: https://github.com/llvm/llvm-project/commit/7f96ce5e133be54891af177adbf8952d413e0f85.diff

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

pengfei accepted this revision. pengfei added a comment. LGTM with one nit. Comment at: clang/lib/Headers/avx2intrin.h:942 +/// +/// \code +/// FOR element := 0 to 1 Use `\code{.operation}` please, the same below. Our internal tool will recognize this pattern.

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 517029. heatd added a comment. Update the test to work with tip (completely forgot, apologies) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272 Files: clang/include/cl

[PATCH] D149017: [RISCV] Rewrite all found class-based subroutines to functions

michaelmaitland accepted this revision. michaelmaitland added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149017/new/ https://reviews.llvm.org/D149017

[PATCH] D149017: [RISCV] Rewrite all found class-based subroutines to functions

pcwang-thead added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:703 class VPseudoUSLoadMask : - Pseudo<(outs GetVRegNoV0.R:$rd), - (ins GetVRegNoV0.R:$merge, + Pseudo<(outs GetVRegNoV0'(RetClass):$rd), + (ins Ge

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 517020. heatd added a comment. Address MaskRay's comments on Options.td, adjust the help message, rebase to current tip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

Manna updated this revision to Diff 517018. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149163/new/ https://reviews.llvm.org/D149163 Files: clang/lib/CodeGen/CGGPUBuiltin.cpp clang/lib/CodeGen/CGNonTrivialStruct.cpp clang/lib/CodeGen/Cod

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 517019. HerrCai0907 added a comment. change LexicalDeclContext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wdng. I feel like this should have documentation explaining the library split, but not sure where the best place to put that would be Repository: rG LLVM Github M

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

ikudrin added a comment. In D149119#4295110 , @tmatheson wrote: > This looks like a nice addition. Would it make sense to use llvm-nm always, > not restricted to bootstrap builds? And would that work on Windows and allow > us to simplify this script sub

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. > The RVI toolchain SIG is supposed to be setting up a task group to define > intrinsics for all extensions. Where should I discuss this intrinsic issue right now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 517012. gulfem marked an inline comment as done. gulfem added a comment. Added more info into HelpText and reversed prefix map in the first place to incorporate coworker feedback. GCC uses a linked list to store the prefix mappings in reverse order: https://gi

[PATCH] D149017: [RISCV] Rewrite all found class-based subroutines to functions

michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:703 class VPseudoUSLoadMask : - Pseudo<(outs GetVRegNoV0.R:$rd), - (ins GetVRegNoV0.R:$merge, + Pseudo<(outs GetVRegNoV0'(RetClass):$rd), + (ins

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz updated this revision to Diff 517011. shchenz added a comment. address @qiucf comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/a

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

Manna updated this revision to Diff 517010. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149163/new/ https://reviews.llvm.org/D149163 Files: clang-tools-extra/clangd/CodeComplete.cpp clang/include/clang/Sema/CodeCompleteConsumer.h clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Co

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

dyung added inline comments. Comment at: llvm/test/MC/ELF/debug-prefix-map.s:54 + +# MAPABS_V5_A:DW_AT_comp_dir [DW_FORM_string] ("{{(/|\\)+}}src_root/bar") +# MAPABS_V5_A:DW_AT_decl_file [DW_FORM_data4] ("/src_root{{(/|\\)+}}bar{{(/|\\)+}}src.s") This m

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

dyung added a comment. @MaskRay , a test you modified, debug-prefix-map.s is failing on the PS5 Windows bot. Can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/20460 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148975/new/

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay updated this revision to Diff 517004. MaskRay retitled this revision from "[Driver] -gsplit-dwarf: derive .dwo names from -o for link actions" to "[Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking". MaskRay edited the summary of this revision. MaskRay added a comment.

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav added a comment. In D147844#4293299 , @cjdb wrote: > I think this is a good diagnostic to add: it improves readability and > eliminates ambiguities. My only request is that if there isn't already a > FixIt hint, one be added, please. @cjb qu

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem marked 2 inline comments as done. gulfem added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1638 : CGM(CGM), SourceInfo(SourceInfo) { - CoveragePrefixMap = CGM.getCodeGenOpts().CoveragePrefixMap; + for (const auto &[From, To] : CGM.getCodeGe

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 516993. gulfem added a comment. Added a comment about reverse traversal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 516989. gulfem added a comment. Addressed feedback and rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Files: clang/include/clang/Basic/CodeGenOptions.h c

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

delcypher added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// @hnrklssn I just noticed we don't have a `

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

LiDongjin added inline comments. Comment at: llvm/include/llvm-c/Core.h:4088 * \returns a constant that specifies that the result of a \c ShuffleVectorInst * is undefined. */ undefined to poison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson added a comment. This was refactored out of patch 3 (the applyImport stuff that I refactored into patch 4 in D149117 ). Previously I was controlling this behavior via the MemProfContextDisambiguation pass itself, but in refactoring I realized that it

[PATCH] D149193: [Driver] -gsplit-dwarf: derive .dwo names from -o for link actions

MaskRay updated this revision to Diff 516980. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: ormris. add notes and more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149193/new/ https://reviews

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. LGTM. I'm not a maintainer so wait a day to push so others can take a look. Comment at: clang/lib/Headers/avx2intrin.h:789 - static __inline__ __m128i __DEFA

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson created this revision. tejohnson added a reviewer: snehasish. Herald added subscribers: hoy, ormris, arphaman, steven_wu, hiraditya, inglorion. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-com

[PATCH] D149193: [Driver] -gsplit-dwarf: derive .dwo names from -o for link actions

MaskRay added a comment. In D149193#4297043 , @scott.linder wrote: > I'm a bit confused after trying to work out the rules for the GCC version of > `-dumpdir` over at > https://gcc.gnu.org/onlinedocs/gcc/Overall-Options.html#index-dumpdir but it > at

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4295719 , @tbaeder wrote: > In D148601#4279604 , @Unique_Usman > wrote: > >> In D148601#4279334 , @tbaeder >> wrote: >> >>> I am

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito created this revision. ManuelJBrito added reviewers: aqjune, efriedma, RKSimon, nikic, nlopes, spatel. Herald added a reviewer: deadalnix. Herald added subscribers: luke, kosarev, StephenFan, frasercrmck, okura, kuter, lebedev.ri, kerbowa, luismarques, apazos, sameer.abuasal, pengfei,

[PATCH] D149193: [Driver] -gsplit-dwarf: derive .dwo names from -o for link actions

scott.linder added a comment. I'm a bit confused after trying to work out the rules for the GCC version of `-dumpdir` over at https://gcc.gnu.org/onlinedocs/gcc/Overall-Options.html#index-dumpdir but it at least seems like our version is a subset of theirs. Do we support any of the other `-dum

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4117 + if (const Arg *A = Args.getLastArg(OPT_fcheck_new)) +Opts.CheckNew = true; + heatd wrote: > MaskRay wrote: > > Use `CodeGenOpts<"CheckNew">` and avoid change to this

[clang] d3e1217 - [CodeGen] Remove unneeded CoveragePrefixMap. NFC

Author: Fangrui Song Date: 2023-04-25T15:21:15-07:00 New Revision: d3e121780ac2724969a030415f3092170f3c7589 URL: https://github.com/llvm/llvm-project/commit/d3e121780ac2724969a030415f3092170f3c7589 DIFF: https://github.com/llvm/llvm-project/commit/d3e121780ac2724969a030415f3092170f3c7589.diff

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

MaskRay added a comment. LGTM Comment at: clang/include/clang/Basic/CodeGenOptions.h:211 + + /// Prefix replacement map for coverage. + llvm::SmallVector, 0> CoveragePrefixMap; While adding a comment, clarify what coverage it is? There are multiple coverage

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 516953. krzysz00 edited the summary of this revision. krzysz00 added a comment. Make address space 8 non-integral as well because that's a good idea and we'll have an address space cast intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaad48d6b236: -fdebug-prefix-map=: make the last win when multiple prefixes match (authored by MaskRay). Repository: rG LLVM Github Monorepo CHAN

[clang] daad48d - -fdebug-prefix-map=: make the last win when multiple prefixes match

Author: Fangrui Song Date: 2023-04-25T15:12:17-07:00 New Revision: daad48d6b236d74c6b29daebba46289b98104241 URL: https://github.com/llvm/llvm-project/commit/daad48d6b236d74c6b29daebba46289b98104241 DIFF: https://github.com/llvm/llvm-project/commit/daad48d6b236d74c6b29daebba46289b98104241.diff

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148665/new/ https://reviews.llvm.org/D148665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 516926. iii added a comment. Herald added a subscriber: hoy. - Fixed an issue with copyRegSaveArea() overwriting shadow of caller's locals. The problem was that the kernel is compiled with "packed-stack", so register save areas may be smaller than 160 bytes. Sin

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

MaskRay added a comment. In D148975#4296625 , @scott.linder wrote: > LGTM, thank you! > > Does this warrant a release note, as it is changing the behavior in a > backwards-incompatible manner? I do think changing to match GCC is > worthwhile, even if i

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

MaskRay updated this revision to Diff 516924. MaskRay marked an inline comment as done. MaskRay added a comment. Update HelpText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148975/new/ https://reviews.llvm.org/D148975 Files: clang/include/clan

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC!

paulkirth created this revision. paulkirth added reviewers: hans, tejohnson, phosek. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously we only accepted the `-fdiagnostics-misexpect-tol

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D149205 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Dec

[PATCH] D149193: [Driver] -gsplit-dwarf: derive .dwo names from -o for link actions

MaskRay created this revision. MaskRay added reviewers: dblaikie, phosek, yaxunl. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the final phase is linking, Clang currently places auxiliary files i

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:43 +namespace { + mboehme wrote: > There were a number of pre-exist

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe12753ed: [clang] add diagnose when member function contains invalid default argument (authored by HerrCai0907). Repository: rG LLVM Github Mo

[clang] 3333e12 - [clang] add diagnose when member function contains invalid default argument

Author: Congcong Cai Date: 2023-04-25T23:08:30+02:00 New Revision: e12753ed9c27fc25c73858a990081b0ceb11 URL: https://github.com/llvm/llvm-project/commit/e12753ed9c27fc25c73858a990081b0ceb11 DIFF: https://github.com/llvm/llvm-project/commit/e12753ed9c27fc25c73858a990081b0ceb11.diff

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf34ecb50e2c0: [clang] Don't emit type tests for dllexport/import classes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] f34ecb5 - [clang] Don't emit type tests for dllexport/import classes

Author: Arthur Eubanks Date: 2023-04-25T14:00:57-07:00 New Revision: f34ecb50e2c03e27b5785576545aab07b3b19a94 URL: https://github.com/llvm/llvm-project/commit/f34ecb50e2c03e27b5785576545aab07b3b19a94 DIFF: https://github.com/llvm/llvm-project/commit/f34ecb50e2c03e27b5785576545aab07b3b19a94.diff

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. LGTM, thank you! Does this warrant a release note, as it is changing the behavior in a backwards-incompatible manner? I do think changing to match GCC is worthwhile, even if it me

[PATCH] D148372: [clang] add diagnose when member function contains invalid default argument

HerrCai0907 added a comment. > Are there any calls to Sema::ActOnParamDefaultArgumentError left? Yes, it has. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148372/new/ https://reviews.llvm.org/D148372 _

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-c

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. Herald added a subscriber: bd1976llvm. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

nikic added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson added a comment. In D72538#4296277 , @nikic wrote: > In D72538#4296119 , @tejohnson wrote: > >> In D72538#4291552 , @nikic wrote: >> >>> Would it be possible to cut

[clang] e5b0276 - [ThinLTO] Reduce pipeline clang test to avoid churn from LLVM changes

Author: Teresa Johnson Date: 2023-04-25T13:33:09-07:00 New Revision: e5b0276dc882f7c5b2a349e2f02abf16b1d41322 URL: https://github.com/llvm/llvm-project/commit/e5b0276dc882f7c5b2a349e2f02abf16b1d41322 DIFF: https://github.com/llvm/llvm-project/commit/e5b0276dc882f7c5b2a349e2f02abf16b1d41322.diff

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Clang was writing paths to the dependency file that don't exist when using a sysroot with symlinks, causing every

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

Manna updated this revision to Diff 516883. Manna added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Fix bot failures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149163/new/ https://reviews.llvm.org/D149163 Files: clang-tools-extra/clan

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie created this revision. dblaikie added a reviewer: aaron.ballman. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The packed attribute can still be useful in this case if the struct is then plac

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

MaskRay added a comment. This refactoring looks reasonable to me as well. In `clang/lib/Driver`, we have D30372 that splits some huge files into target-specific files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

aaron.ballman added a reviewer: efriedma. aaron.ballman added a comment. I think this is a reasonable refactoring, but I'm hoping the CodeGen code owners can chime in with their thoughts as well given how large the changes are in their area. (I did not verify that the refactoring didn't change

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4266201 , @nikic wrote: > We should probably just use the `META` fallback for all metadata not already > explicitly handled. I think there's pretty little value in adding a special > name for each metadata kind. I a

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4266174 , @arichardson wrote: > Change looks good to me, but if clang can't emit these yet we should probably > wait until committing this? Do you have a link to a review that uses this > metadata? It can emit them

[PATCH] D148901: [clang][Interp] Fix post-inc/dec operator result

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148901/new/ https://reviews.llvm.org/D148901

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:209 - std::map DebugPrefixMap; + llvm::SmallVector, 0> DebugPrefixMap; std::map CoveragePrefixMap; scott.linder wrote: > MaskRay

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

MaskRay updated this revision to Diff 516863. MaskRay marked 3 inline comments as done. MaskRay added a comment. remove a DebugPrefixMap variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148975/new/ https://reviews.llvm.org/D148975 Files: c

[PATCH] D149154: [clang][Interp] Emit diagnostic when comparing function pointers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/Interp.h:652-653 + const SourceInfo &Loc = S.Current->getSource(OpPC); + S.FFDiag(Loc, diag::note_constexpr_pointer_comp

[PATCH] D148987: [clang][Interp] Check Neg ops for errors

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:438-441 + // FIXME: This code Just Works[tm] for floats, but it's probably not doing + // the right thing. At least the diagnostic could be better without + // the conversion to an APInt. +

[PATCH] D148967: Disable atexit()-based lowering when LTO'ing kernel/kext code

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3f0153ec27a: [MachO] Disable atexit()-based lowering when LTO'ing kernel/kext code (authored by yln). Changed prior to commit: https://reviews.llvm.org/D148967?vs=515929&id=516862#toc Repository: rG

[clang] c3f0153 - [MachO] Disable atexit()-based lowering when LTO'ing kernel/kext code

Author: Julian Lettner Date: 2023-04-25T12:13:40-07:00 New Revision: c3f0153ec27a5e2cff97179d319ab99651c4c539 URL: https://github.com/llvm/llvm-project/commit/c3f0153ec27a5e2cff97179d319ab99651c4c539 DIFF: https://github.com/llvm/llvm-project/commit/c3f0153ec27a5e2cff97179d319ab99651c4c539.diff

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

nikic added a comment. In D72538#4296119 , @tejohnson wrote: > In D72538#4291552 , @nikic wrote: > >> Would it be possible to cut down the Clang side tests to only check parts >> that Clang controls in some way, e.

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:1216 +// Returns the length of cc constraint. +static unsigned matchAsmCCConstraint(const char *&Name) { + constexpr unsigned len = 5; davidxl wrote: > Name is not modified in

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. In D115907#4296154 , @hans wrote: > In D115907#4295923 , @paulkirth > wrote: > >>> 2. Due to inlining etc., it often gets the source locations wrong, which >>> means it points at code

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516857. Krishna-13-cyber added a comment. - Updated with reviewed changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000 Files: clang/lib/Sema/SemaCheckin

[PATCH] D147281: Stop modifying trailing return types.

thakis added a comment. Looks like this caused a change in behavior: https://github.com/llvm/llvm-project/issues/62361 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147281/new/ https://reviews.llvm.org/D147281

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. @ivanmurashko: Sorry for the delay getting back to you here. Feel free to commandeer, as I don't have plans to get to this soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930

[PATCH] D148967: Disable atexit()-based lowering when LTO'ing kernel/kext code

ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. A comment inline, but LGTM otherwise, thanks! Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1208 + // -disable-atexit-based-global-dtor-lowering CodeGen flag. + //

  1   2   >