ab accepted this revision. ab added a comment. This revision is now accepted and ready to land.
A comment inline, but LGTM otherwise, thanks! ================ Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1208 + // -disable-atexit-based-global-dtor-lowering CodeGen flag. + // report_fatal_error("@llvm.global_dtors should have been lowered already"); } ---------------- stray fatal_error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148967/new/ https://reviews.llvm.org/D148967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits