MaskRay added a comment.
LGTM
================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:211
+
+ /// Prefix replacement map for coverage.
+ llvm::SmallVector<std::pair<std::string, std::string>, 0> CoveragePrefixMap;
----------------
While adding a comment, clarify what coverage it is? There are multiple
coverage instrumentation features in Clang.
================
Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1638
: CGM(CGM), SourceInfo(SourceInfo) {
- CoveragePrefixMap = CGM.getCodeGenOpts().CoveragePrefixMap;
+ for (const auto &[From, To] : CGM.getCodeGenOpts().CoveragePrefixMap)
+ CoveragePrefixMap.emplace_back(From, To);
----------------
`CoveragePrefixMap` can be removed. I just removed `DebugPrefixMap` as well:)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148757/new/
https://reviews.llvm.org/D148757
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
