gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:43
+namespace {
+
----------------
mboehme wrote:
> There were a number of pre-existing declarations that were ODR violation
> risks. I'm adding a new file-local function below, so instead of making it
> static, I decided to put everything that's supposed to be file-local in an
> anonymous namespace.
https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
"Avoid putting declarations other than classes into anonymous namespaces"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149144/new/
https://reviews.llvm.org/D149144
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
