[PATCH] D128952: [AMDGPU] Add WMMA clang builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7822521277: [AMDGPU] Add WMMA clang builtins (authored by piotr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 4a78225 - [AMDGPU] Add WMMA clang builtins

Author: Piotr Sobczak Date: 2022-07-01T08:55:25+02:00 New Revision: 4a782252127761b60d33e74f9d9acb0aad6f742f URL: https://github.com/llvm/llvm-project/commit/4a782252127761b60d33e74f9d9acb0aad6f742f DIFF: https://github.com/llvm/llvm-project/commit/4a782252127761b60d33e74f9d9acb0aad6f742f.diff

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

phosek added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:49-51 +namespace profile = llvm::compression::zlib; + +namespace serialize = llvm::compression::zlib; I think we will need to support dynamically selecting (de)compression algorithm

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe66aebd7551: [pseudo] Define a clangPseudoCLI library. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D128679?vs=440929&

[clang-tools-extra] fe66aeb - [pseudo] Define a clangPseudoCLI library.

Author: Haojian Wu Date: 2022-07-01T08:31:34+02:00 New Revision: fe66aebd755191fac66a73b50d94c29f60be9a88 URL: https://github.com/llvm/llvm-project/commit/fe66aebd755191fac66a73b50d94c29f60be9a88 DIFF: https://github.com/llvm/llvm-project/commit/fe66aebd755191fac66a73b50d94c29f60be9a88.diff LO

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a reviewer: ilya-biryukov. ChuanqiXu added a subscriber: ilya-biryukov. ChuanqiXu added a comment. Add @ilya-biryukov since he did similar things in https://reviews.llvm.org/D128921 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D1180

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff added a comment. Herald added a reviewer: NoQ. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123952/new/ https://reviews.llvm.org/D123952 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added a comment. In D126189#3617896 , @iains wrote: > In D126189#3617850 , @ChuanqiXu > wrote: > >> @iains may I ask what's the issue to not land this? It looks like you're >> waiting for the behavior

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi updated this revision to Diff 441587. akyrtzi added a comment. Herald added a project: clang-tools-extra. Update `clang-tools-extra/test/pp-trace/pp-trace-include.cpp` to accomodate for `PrevFID` getting a value and preserve using `getFileEntryForID()` for the `SourceManager::getFilename(

[clang] 6bd53df - [clang][NFC][tests] dr208.c optional signext handling

Author: Hubert Tong Date: 2022-07-01T00:03:58-04:00 New Revision: 6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7 URL: https://github.com/llvm/llvm-project/commit/6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7 DIFF: https://github.com/llvm/llvm-project/commit/6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7.diff L

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

NoQ added a subscriber: usama54321. NoQ added a comment. Thanks, very nice! @usama54321 you recently fixed a similar problem in a clang-tidy check, do you know if it also requires a similar clause for polymorphic expressions inside `typeid`? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ceb9c347f14: [ODRHash diagnostics] Move common code for calculating diag locations in… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 2ceb9c3 - [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

Author: Volodymyr Sapsai Date: 2022-06-30T19:39:22-07:00 New Revision: 2ceb9c347f14e81a8c71d644724cefd10fce6eaf URL: https://github.com/llvm/llvm-project/commit/2ceb9c347f14e81a8c71d644724cefd10fce6eaf DIFF: https://github.com/llvm/llvm-project/commit/2ceb9c347f14e81a8c71d644724cefd10fce6eaf.di

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ChuanqiXu added a reviewer: ChuanqiXu. ChuanqiXu added a comment. Thanks for filing that issue. I wanted to add that myself before. It should be better to change `isVisible` and `hasVisibleDefinition` to `isReachable` and `hasReachableDefinition`. The definition of reachability comes from C++20

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:10020 +auto GetMismatchedDeclLoc = [](const NamedDecl *Container, + ODRMismatchDecl DiffType, const Decl *D) { + SourceLocation Loc; vsap

[PATCH] D128048: Add a new clang option "-ftime-trace="

dongjunduo updated this revision to Diff 441574. dongjunduo added a comment. [Clang] format the source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/clang/Driver/Options.td

[PATCH] D128048: Add a new clang option "-ftime-trace="

Whitney accepted this revision. Whitney added inline comments. Comment at: clang/tools/driver/cc1_main.cpp:265 + SmallString<128> TracePath(Clang->getFrontendOpts().TimeTracePath); + if (llvm::sys::fs::is_directory(TracePath)) { +llvm::sys::path::append(TracePat

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo marked an inline comment as done. dongjunduo added inline comments. Comment at: clang/test/Driver/check-time-trace.cpp:9 +// RUN: | FileCheck %s +// RUN: %clangxx -S -ftime-trace=%T -ftime-trace-granularity=0 -o %T/check-time-trace %s +// RUN: cat %T/check-time-trac

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 441572. dongjunduo added a comment. [Clang] change test cases to different directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/clang/D

[PATCH] D128488: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15cb180dcbf8: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 15cb180 - [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

Author: Volodymyr Sapsai Date: 2022-06-30T18:40:46-07:00 New Revision: 15cb180dcbf84701f3af47983e223d0beaac3c9b URL: https://github.com/llvm/llvm-project/commit/15cb180dcbf84701f3af47983e223d0beaac3c9b DIFF: https://github.com/llvm/llvm-project/commit/15cb180dcbf84701f3af47983e223d0beaac3c9b.di

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:212 +}; +/// List of captuer fields +llvm::SmallVector ABataev wrote: > Captured? Fixed. Thanks. Comment at: clang/lib/Sema/TreeTransform.h:122 + /// the Rebuil

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 updated this revision to Diff 441565. jyu2 added a comment. Thanks Alexey for the review. This patch to address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127803/new/ https://reviews.llvm.org/D127803 Files: clang/include/cl

[PATCH] D128488: [ODRHash diagnostics] Split `err_module_odr_violation_mismatch_decl_diff` into per-entity diagnostics. NFC.

vsapsai added a comment. Thanks for the review, Chuanqi! Comment at: clang/lib/Serialization/ASTReader.cpp:9642 + // note_module_odr_violation_record + enum ODRCXXRecordDifference { StaticAssertCondition, ChuanqiXu wrote: > Is this specific to C++? That

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi updated this revision to Diff 441556. akyrtzi added a comment. Pass a value for `PrevFID` for `FileChanged()` callback as well, for `PPCallbacks::EnterFile` reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128947/new/ https://reviews.

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi updated this revision to Diff 441551. akyrtzi added a comment. Use `Optional::value_or()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128947/new/ https://reviews.llvm.org/D128947 Files: clang/include/clang/Basic/SourceManager.h clang

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Herald added a reviewer: ributzka. I tried the ninja stage2-check-all on my local build with this patch applied and don't reproduce the issue. Is there any way someone could get me the preprocessed source that this crashed on off the servers or something? @JDevlieg

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1016 +return *Name; return StringRef(); } benlangmuir wrote: > Just a suggestion: `value_or` can be a nice way to express simple cases like > this: > > ``` > getFilename(getFil

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3623059 , @nickdesaulniers wrote: > I see you modified the mir parser & printer; consider adding a .mir test. I added a .mir test for parsing the cfi-type. The machine instructions generated for the various call

[PATCH] D128952: [AMDGPU] Add WMMA clang builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128952/new/ https://reviews.llvm.org/D128952 ___

[PATCH] D128489: [ODRHash diagnostics] Move common code for calculating diag locations in `DiagnoseODRMismatch` into a lambda. NFC.

vsapsai added a comment. Thanks for the review! Comment at: clang/lib/Serialization/ASTReader.cpp:10020 +auto GetMismatchedDeclLoc = [](const NamedDecl *Container, + ODRMismatchDecl DiffType, const Decl *D) { + SourceLocation Loc;

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

benlangmuir added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1016 +return *Name; return StringRef(); } Just a suggestion: `value_or` can be a nice way to express simple cases like this: ``` getFilename(getFileID(SpellingLoc)).value_o

[PATCH] D128754: Refactor LLVM compression namespaces (Part 1: remove crc32)

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should probably add `[llvm]` to the subject also. Generally it's helpful for immediately knowing which subrepo you're touching. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb1d908e5cf7: Adds AST matcher for ObjCStringLiteral (authored by t-rasmud). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D128754: Refactor LLVM compression namespaces (Part 1: remove crc32)

ckissane updated this revision to Diff 441541. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' into ckissane.refactor-compression.part-1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm

[clang] eb1d908 - Adds AST matcher for ObjCStringLiteral

Author: Rashmi Mudduluru Date: 2022-06-30T15:20:10-07:00 New Revision: eb1d908e5cf7279b98b84d1587d4665d3cdecbe9 URL: https://github.com/llvm/llvm-project/commit/eb1d908e5cf7279b98b84d1587d4665d3cdecbe9 DIFF: https://github.com/llvm/llvm-project/commit/eb1d908e5cf7279b98b84d1587d4665d3cdecbe9.di

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

ckissane updated this revision to Diff 441540. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' of github.com:ckissane/llvm-project into ckissane.refactor-compression.part-0 - Merge branch 'main' into ckissane.refactor-compression.part-0 Repository: rG LLVM Gith

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for publicly visible classes

aeubanks created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D128953: refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Should also probably add `[NFC]` to the start of the subject Comment at: lld/ELF/InputSection.cpp:77 +if (!compression::zlib::isAvailable()) + error(

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441537. ckissane added a comment. make part 1 after part 0 of refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: llvm/docs/ReleaseNotes.rst llvm/inc

[PATCH] D128953: chore: refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain. Changes are as follows: * Relocate the `ll

ckissane created this revision. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added

[PATCH] D128952: [AMDGPU] Add WMMA clang builtins

piotr created this revision. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. piotr requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Add WMMA clang builtins and

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] da1609a - Improve the formatting of static_assert messages

Author: Corentin Jabot Date: 2022-06-30T23:59:21+02:00 New Revision: da1609ad73540978f66111e96ea500b97ca9b39a URL: https://github.com/llvm/llvm-project/commit/da1609ad73540978f66111e96ea500b97ca9b39a DIFF: https://github.com/llvm/llvm-project/commit/da1609ad73540978f66111e96ea500b97ca9b39a.diff

[PATCH] D128844: Improve the formatting of static_assert messages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda1609ad7354: Improve the formatting of static_assert messages (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 441530. serge-sans-paille added a comment. Extra test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td clang/

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson updated this revision to Diff 441529. tejohnson marked 3 inline comments as done. tejohnson added a comment. Rebase on top of D128854 which now includes the extracted Analysis utilities. I have not yet addressed the other comments on this patch. Repo

[PATCH] D128844: Improve the formatting of static_assert messages

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM. (The clang-format if more of a suggestion than anything else currently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https:

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. @philnik There seems to be an unrelated clang-format issue but otherwise the build looks fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 __

[PATCH] D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback

akyrtzi created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a preprocessor callback focused on the lexed file changing, wi

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:483 + !Type.getNonReferenceType().isConstQualified() && + !isExpandedParameterPack(Param); } sammccall wrote: > upsj wrote: > > sammccall wrote: > > > upsj wrot

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 441520. upsj marked 3 inline comments as done. upsj added a comment. detect whether forwarding functions preserve reference-ness and value categories of their arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

Re: [clang] cce06da - Test and document some C99 DRs

Thanks! I'm looking into it and will fix or revert shortly ~Aaron On Thu, Jun 30, 2022 at 5:02 PM Nico Weber wrote: > > Looks like this might break tests: http://45.33.8.238/linux/80043/step_7.txt > > On Thu, Jun 30, 2022, 9:47 PM Aaron Ballman via cfe-commits > wrote: >> >> >> Author: Aaron B

[clang] 56dc4db - Fix test expectation positioning relative to FIXME comment

Author: Reid Kleckner Date: 2022-06-30T14:08:25-07:00 New Revision: 56dc4dbe45e2b1a3e33ab69323ae9d885ab34899 URL: https://github.com/llvm/llvm-project/commit/56dc4dbe45e2b1a3e33ab69323ae9d885ab34899 DIFF: https://github.com/llvm/llvm-project/commit/56dc4dbe45e2b1a3e33ab69323ae9d885ab34899.diff

Re: [clang] cce06da - Test and document some C99 DRs

Looks like this might break tests: http://45.33.8.238/linux/80043/step_7.txt On Thu, Jun 30, 2022, 9:47 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date: 2022-06-30T15:46:47-04:00 > New Revision: cce06da1ecf789658551ca5f3b255c361f063abf > > UR

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 441509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. I'm not sure how to check the no-op case without constructing at least a queue. Even assuming only 2 commutative operands, if they look the same `depth=1`, then the comparison has to iterate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille updated this revision to Diff 441505. serge-sans-paille added a comment. Update test case to take into accounts reviewers suggestions. As a consequence use a more complex approach to detect whether two `NamedDecl` may interfere. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Question: Should this check be extended to also include C.86 : "Flag an operator==() for which the argument types differ; same fo

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. Thanks for the comments. Comment at: clang/test/Driver/linker-wrapper.c:109 // RUN: clang-offload-packager -o %t-lib.out \ // RUN: --image=file=%S/Inputs/dummy-elf.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ tra wrote:

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441499. njames93 added a comment. Changed to only use the major version. If this still seems too flaky, happy to go back to just linking to the in progress release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

vitalybuka added a comment. > Yikes! Thanks for the revert. I didn't see the email from the bot until > just about 2 minutes before you reverted. I'll see if I can reproduce. FYI. The same on a different bot https://lab.llvm.org/buildbot/#/builders/5/builds/25486/steps/19/logs/stdio Reposi

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:122 + /// the RebuildME uses to set if member expression needs to be rebuilt. + bool RebuildME = false; + jyu2 wrote: > ABataev wrote: > > I think we don't need to add a new field here. C

[clang] cce06da - Test and document some C99 DRs

Author: Aaron Ballman Date: 2022-06-30T15:46:47-04:00 New Revision: cce06da1ecf789658551ca5f3b255c361f063abf URL: https://github.com/llvm/llvm-project/commit/cce06da1ecf789658551ca5f3b255c361f063abf DIFF: https://github.com/llvm/llvm-project/commit/cce06da1ecf789658551ca5f3b255c361f063abf.diff

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

tra added a comment. Syntax/style looks OK to me with a few nits. Comment at: clang/test/Driver/linker-wrapper.c:109 // RUN: clang-offload-packager -o %t-lib.out \ // RUN: --image=file=%S/Inputs/dummy-elf.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ ---

[PATCH] D128853: [Interpreter] Pass target features to JIT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf22795de683d: [Interpreter] Pass target features to JIT (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D128853?vs=44115

[clang] f22795d - [Interpreter] Pass target features to JIT

Author: Jonas Hahnfeld Date: 2022-06-30T21:25:14+02:00 New Revision: f22795de683d571bbf7e655a7b4ed5ccda186e66 URL: https://github.com/llvm/llvm-project/commit/f22795de683d571bbf7e655a7b4ed5ccda186e66 DIFF: https://github.com/llvm/llvm-project/commit/f22795de683d571bbf7e655a7b4ed5ccda186e66.diff

[clang-tools-extra] 9b6bb12 - [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

Author: Sam McCall Date: 2022-06-30T21:20:55+02:00 New Revision: 9b6bb12b85846e8337f8ff75aebd4e9798b56bdd URL: https://github.com/llvm/llvm-project/commit/9b6bb12b85846e8337f8ff75aebd4e9798b56bdd DIFF: https://github.com/llvm/llvm-project/commit/9b6bb12b85846e8337f8ff75aebd4e9798b56bdd.diff LO

[PATCH] D128930: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b6bb12b8584: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D128930?vs=441458&id=441482#toc

[PATCH] D128930: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:68 + +struct NodeStats { + unsigned Total = 0; hokein wrote: > I can foresee we will use it in other places (e.g. our internal

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3623120 , @JDevlieghere wrote: > This change triggers an assertion when building an LLDB test case: > > UNREACHABLE executed at > /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/lib/Sema/SemaTem

[PATCH] D128589: [clang-repl] Support destructors of global objects.

sunho added inline comments. Comment at: clang/test/Interpreter/execute.cpp:22-23 +struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, m=0x%llx]\n", f, reinterpret_cast(m)); }} d; +// CHECK: D[f=1.00, m=0x0] + Hahnfeld wrote: > I think i

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

JDevlieghere added a comment. This change triggers an assertion when building an LLDB test case: UNREACHABLE executed at /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/lib/Sema/SemaTemplate.cpp:1726! Assertion failed: (InstantiatingSpecializations.empty() && "failed to cle

[PATCH] D128930: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:68 + +struct NodeStats { + unsigned Total = 0; I can foresee we will use it in other places

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8893-8894 + + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + abidmalikwaterloo wrote: > ABataev wrote: > > make it private > Any reas

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov updated this revision to Diff 441468. ilya-biryukov added a comment. - remove leftover test from previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128921/new/ https://reviews.llvm.org/D128921 Files: clang/include/clang

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov added a comment. I haven't seen your reply before posting my initial comments. Many thanks for a very quick turnaroud on this! Will wait for module folks to approve. Comment at: clang/lib/Sema/SemaTemplate.cpp:8674 auto *Old = Previous.getRepresentativeDecl(

[PATCH] D128853: [Interpreter] Pass target features to JIT

Hahnfeld added inline comments. Comment at: clang/lib/Interpreter/IncrementalExecutor.h:34 struct PartialTranslationUnit; +struct TargetInfo; That's wrong, should be `class TargetInfo`. I'll fix this before landing if my other tests go well... Repository:

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov updated this revision to Diff 441466. ilya-biryukov added a comment. - Update code to match how typedefs behave Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128921/new/ https://reviews.llvm.org/D128921 Files: clang/include/clang/S

[PATCH] D119296: KCFI sanitizer

nickdesaulniers accepted this revision. nickdesaulniers added a comment. I see you modified the mir parser & printer; consider adding a .mir test. Still LGTM. Might be nice to document the generated asm more for other compiler vendors to better understand the implementation, rather than having t

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:8893-8894 + + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + ABataev wr

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud added a comment. In D128103#363 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like me to use for patch attribution? Thank you @aaron.ballman. I believe I have the

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov updated this revision to Diff 441462. psamolysov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix `Clang :: CodeGen/thinlto-distributed-newpm.ll` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[PATCH] D128930: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

sammccall added a comment. Results on the first 1k lines of SemaCodeComplete.cpp: Forest bytes: 809824 nodes: 47378 GSS bytes: 24736 nodes: 41925 1490 Ambiguous nodes: 518 type-name 377 simple-type-specifier 137 namespace-name 135 nested-name-specifier 65 postfix-exp

[PATCH] D128930: [pseudo] Add ForestNode descendants iterator, print ambiguous/opaque node stats.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Gi

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. In D109701#3622983 , @aaron.ballman wrote: > I had to roll it back because of failures with test bots: > > https://lab.llvm.org/buildbot/#/builders/91/builds/11328 > > So this was reverted in b46ad1b5be694feefabd4c6cd112cbbd04a

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. I had to roll it back because of failures with test bots: https://lab.llvm.org/buildbot/#/builders/91/builds/11328 So this was reverted in b46ad1b5be694feefabd4c6cd112cbbd04a7b3a7 , can you take

[clang] b46ad1b - Revert "[clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface"

Author: Aaron Ballman Date: 2022-06-30T13:39:47-04:00 New Revision: b46ad1b5be694feefabd4c6cd112cbbd04a7b3a7 URL: https://github.com/llvm/llvm-project/commit/b46ad1b5be694feefabd4c6cd112cbbd04a7b3a7 DIFF: https://github.com/llvm/llvm-project/commit/b46ad1b5be694feefabd4c6cd112cbbd04a7b3a7.diff

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

nicovank added a reviewer: serge-sans-paille. nicovank added a comment. Did some digging, looks like this was added in rG7f92a1a84b96 , most likely to also fix that CI build error with `misc-misleading-identifier`. Repository

[clang] 329fae7 - [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

Author: Vaibhav Yenamandra Date: 2022-06-30T13:23:15-04:00 New Revision: 329fae7103d355e728cc326a0a9abef889ccc577 URL: https://github.com/llvm/llvm-project/commit/329fae7103d355e728cc326a0a9abef889ccc577 DIFF: https://github.com/llvm/llvm-project/commit/329fae7103d355e728cc326a0a9abef889ccc577.

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG329fae7103d3: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface (authored by vaibhav.y, committed by aaron.ballman). Re

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin updated this revision to Diff 441448. cor3ntin added a comment. Missing -re in a few places Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D128844: Improve the formatting of static_assert messages

Mordante accepted this revision. Mordante added a comment. In D128844#360 , @aaron.ballman wrote: > So I *think* this LG, but am not certain what will happen when you land it. I > think the precommit CI failures are not failures that will happen whe

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fixes to this! I'll land this again on your behalf with the same information as before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

Mordante added a comment. Thanks @egorzhdan for working on this, I seem to have overlooked this item in the review queue. SGMT, but it seems the libc++ CI hasn't been triggered with this change. Maybe change one file in libc++ to give the CI a spin? Comment at: clang/docs/Cla

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

martong added a comment. In D103096#3613059 , @ASDenysPetrov wrote: > @martong Just FYI. I've been working on reworking this solution to using > `EquivalenceClasses` for several weeks. It turned out that this is an > extremely hard task to acomplish. T

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin updated this revision to Diff 441439. cor3ntin added a comment. Pushing for CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D128927: [libc++] Always build c++experimental.a

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM with some suggestions. Comment at: libcxx/docs/ReleaseNotes.rst:226 + experimental features provided by it. Note that vendors are encour

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:911 +// Annotation for the riscv pragma directives - #pragma clang riscv intrinsic .. +PRAGMA_ANNOTATION(pragma_riscv) Why only 2 periods at the end. Should be 3 like on l

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a subscriber: mstorsjo. ldionne added a comment. @mstorsjo I might need some assistance figuring out what to do with the Windows parts of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org

  1   2   >