sammccall marked an inline comment as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:68
+
+struct NodeStats {
+ unsigned Total = 0;
----------------
hokein wrote:
> I can foresee we will use it in other places (e.g. our internal metric tool),
> I think it is worth to expose it. It is ok for now.
I had the same thought, but I wasn't sure we'll want exactly the same thing.
e.g. the breakdown-by-SymbolID is a somewhat specialized data structure, our
(private) mapreduce analysis might want to use mapreduce counters for this.
I'd rather just share the iterator for now, and only expose the simple
aggregation stuff once we know it's actually reusable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128930/new/
https://reviews.llvm.org/D128930
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
