Mordante added a comment.

Thanks @egorzhdan for working on this, I seem to have overlooked this item in 
the review queue.
SGMT, but it seems the libc++ CI hasn't been triggered with this change. Maybe 
change one file in libc++ to give the CI a spin?



================
Comment at: clang/docs/ClangCommandLineReference.rst:278
+
+This option enables various language and library features that are either 
experimental (also known as TSes), or have been standardized but are not stable 
yet. This option should not be used in production code, since neither ABI nor 
API stability are guaranteed.
+
----------------
I'm not happy with the word "should", I don't want to decide what users should 
or should not do. Several of these experimental features are perfectly usable. 
If you can rebuild your entire software stack ABI and API stability might be 
less of an issue. (The lack of polish of some features might be a reason not to 
use them.)


================
Comment at: clang/include/clang/Driver/Options.td:1167
+          "This option enables various language and library features that are 
either experimental (also known as TSes),"
+          " or have been standardized but are not stable yet. This option 
should not be used in production code, since "
+          "neither ABI nor API stability are guaranteed">,
----------------
Likewise regarding should.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121141/new/

https://reviews.llvm.org/D121141

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to