sunho added inline comments.

================
Comment at: clang/test/Interpreter/execute.cpp:22-23
 
+struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, 
m=0x%llx]\n", f, reinterpret_cast<unsigned long long>(m)); }} d;
+// CHECK: D[f=1.000000, m=0x0]
+
----------------
Hahnfeld wrote:
> I think it would be better to add new test cases instead of extending this 
> ever-growing file. And it might also be a good idea to split off some of the 
> previous additions into separate test cases that exercise specific parts of 
> the interpreter infrastructure (D126781 and D123674).
Got it. I will address your comment when relanding the patch after fixing ppc 
failure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128589/new/

https://reviews.llvm.org/D128589

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to