hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Nice!
================
Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:68
+
+struct NodeStats {
+ unsigned Total = 0;
----------------
I can foresee we will use it in other places (e.g. our internal metric tool), I
think it is worth to expose it. It is ok for now.
================
Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:70
+ unsigned Total = 0;
+ std::vector<std::pair<unsigned, SymbolID>> BySymbol;
+
----------------
By reading the code, I believe the `unsigned` and `SymbolID` here are swap
accidentally.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128930/new/
https://reviews.llvm.org/D128930
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
