[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2863615 , @ychen wrote: > That's just my conclusion based on @rjmccall's suggestion > (https://reviews.llvm.org/D100739#2717582) and my following responses. I guess you got the conclusion from this: > 2d. Use the cor

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

owenpan added a comment. Has this been tested against a large code base? It also needs an unqualified LGTM before it can be merged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-commits mail

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2863581 , @ChuanqiXu wrote: > In D97915#2862419 , @ychen wrote: > >>> It looks not hard to implement. And we don't need to refactor the CodeGen >>> part a lot. In this way, I think

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105135/new/ https://reviews.llvm.org/D105135 __

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham added inline comments. Comment at: clang/unittests/Serialization/ModuleCacheTest.cpp:125-126 + ASSERT_TRUE(Invocation2); + CompilerInstance Instance2(Instance.getPCHContainerOperations(), + &Instance.getModuleCache()); + Instance2.setDiagno

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 357127. Conanap added a comment. Removed inst aliases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/B

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2862419 , @ychen wrote: >> It looks not hard to implement. And we don't need to refactor the CodeGen >> part a lot. In this way, I think the main effort to support `::operator >> new(size_t, align_t)` would be in the

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG31d10ea10ee1: [AIX] Don't pass no-integrated-as by default (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105512/new/ https://reviews.llv

[clang] 31d10ea - [AIX] Don't pass no-integrated-as by default

Author: Jinsong Ji Date: 2021-07-08T02:50:17Z New Revision: 31d10ea10ee1c24e6c7d7c172e52960717d41817 URL: https://github.com/llvm/llvm-project/commit/31d10ea10ee1c24e6c7d7c172e52960717d41817 DIFF: https://github.com/llvm/llvm-project/commit/31d10ea10ee1c24e6c7d7c172e52960717d41817.diff LOG: [A

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

vsapsai added inline comments. Comment at: clang/unittests/Serialization/ModuleCacheTest.cpp:125-126 + ASSERT_TRUE(Invocation2); + CompilerInstance Instance2(Instance.getPCHContainerOperations(), + &Instance.getModuleCache()); + Instance2.setDiagnos

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105512/new/ https://reviews.llvm.org/D105512 _

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. I tried the following, but it doesn't work with modules, so it looks like a compiler solution is necessary. // in #define _LIBCPP_PRIVATE_HEADER_ALLOWED // in <__algorithm/find.h> #ifndef _LIBCPP_PRIVATE_HEADER_ALLOWED #error This is a libc++ detail header. Pl

[PATCH] D105601: opencl-c.h: reorder atomic operations

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, jfb, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This just reorders the atomics, it doesn't change anything except their layout in the header.

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 357100. airlied added a comment. I've dropped the __SPIR__ change in the base header until things are resolved for library SPIR users to disable extension defines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D

[PATCH] D103465: [OpaquePtr] Track pointee types in Clang

craig.topper added inline comments. Comment at: clang/lib/CodeGen/Address.h:31 + : Address(pointer, nullptr, alignment) {} + Address(llvm::Value *pointer, llvm::Type *PointeeType, CharUnits alignment) + : Pointer(pointer), PointeeType(PointeeType), Alignment(alignment)

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

jyknight added a comment. This commit seems to have broken libc++ in C++98 mode, as it appears to have depended upon the implicit-move extension. Reproduction is simple. Build this with `-stdlib=libc++ -std=c++98`: #include void foo (std::set *s) { s->insert(5); } (https://godbolt.

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied added inline comments. Comment at: clang/lib/Headers/opencl-c.h:7341 half8 __ovld fract(half8 x, __private half8 *iptr); half16 __ovld fract(half16 x, __private half16 *iptr); Anastasia wrote: > This one is not generic address space pointer though but I

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2863266 , @aaron.ballman wrote: > In D69764#2863213 , @steveire wrote: > >> @MyDeveloperDay Does anything prevent this being merged, instead of just >> rebased? > > Please see

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

This revision was automatically updated to reflect the committed changes. Closed by commit rG398bfa2eadbe: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete… (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

This revision was automatically updated to reflect the committed changes. mizvekov marked an inline comment as done. Closed by commit rG2c60d2261032: [clang] disable P2266 simpler implicit moves under -fms-compatibility (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D

[clang] 2c60d22 - [clang] disable P2266 simpler implicit moves under -fms-compatibility

Author: Matheus Izvekov Date: 2021-07-08T00:13:11+02:00 New Revision: 2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee URL: https://github.com/llvm/llvm-project/commit/2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee DIFF: https://github.com/llvm/llvm-project/commit/2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee.dif

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG966386514bec: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D103465: [OpaquePtr] Track pointee types in Clang

nikic added a comment. Maybe send a mail to cfe-dev to solicit some help with the opaque pointer migration on the clang side? Comment at: clang/lib/CodeGen/Address.h:29-30 public: Address(llvm::Value *pointer, CharUnits alignment) - : Pointer(pointer), Alignment(align

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2863213 , @steveire wrote: > @MyDeveloperDay Does anything prevent this being merged, instead of just > rebased? Please see my comments from https://reviews.llvm.org/D69764#2533538. CHANGES SINCE LAST ACTION

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105518/new/ https://reviews.llvm.org/D105518 _

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. @MyDeveloperDay Does anything prevent this being merged, instead of just rebased? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

tstellar created this revision. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The LLVM_ABI_REVISION variable is intended to be used for release candidates which introduce an ABI change to a

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:602 +if (!LangOpts.MSVCCompat) + Builder.defineMacro("__cpp_implicit_move", "202011L"); Builder.defineMacro("__cpp_size_t_suffix", "202011L

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

mizvekov updated this revision to Diff 357078. mizvekov added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105518/new/ https://reviews.llvm.org/D105518 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/l

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield updated this revision to Diff 357077. mbenfield added a comment. fix failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104887/new/ https://reviews.llvm.org/D104887 Files: clang/include/clang/AST/Expr.h clang/include/clang/B

[PATCH] D105414: Add x86 and x86_64 to the BareMetal toolchain

agvallejo added a reviewer: abidh. agvallejo added a comment. Herald added a subscriber: ki.stfu. It took me a while to get the gist of FileCheck, but it finally clicked. @abidh: Thanks for the pointer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D105414: Add x86 and x86_64 to the BareMetal toolchain

agvallejo updated this revision to Diff 357070. agvallejo added a comment. Fulfill merge requirements -Fixed clang-format complaint -Added CLI processing tests for i686 and x86_64 (freestanding+nostdlib only) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. This was discussed in llvm-dev mailing list, and originally we had a change that was closer to what GCC was reporting however there was no consensus on what was needed. The purpose of this change is to bring parity in terms of available options with GCC. @lebedev.

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/AST/Decl.cpp:2203 return nullptr; -if (Kind == TentativeDefinition) - LastTentative = I; +// Record the first TentativeDefin

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap.ll:135 +; CHECK: # %bb.0: +; CHECK-NEXT:twnei 3, 0 +; CHECK-NEXT:blr nemanjai wrote: > Where are the aliases `twnei` and `tdnei` coming from? You don't s

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao updated this revision to Diff 357053. hliao added a comment. Revert part of tests back and convert them into positive ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105135/new/ https://reviews.llvm.org/D105135 Files: clang/test/CodeGe

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

aaron.ballman added a comment. Thank you for working on this! Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-braces-around-statements-attributes.cpp:7-14 + if (b) [[likely]] { +// CHECK-FIXES-NOT: if (b) { {{[[][[]}}likely{{[]][]]}} { +return; + }

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 357052. Conanap marked 6 inline comments as done. Conanap added a comment. Rebased and changed aix test cases to pwr 7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

NoQ added a comment. Yes, I think this totally works now! Can you also add some tests? Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:85 +// Checks if RD has name in Names and is in std namespace +bool hasStdClassWithName(const CXXRecordDecl *RD, +

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

nemanjai added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap.ll:135 +; CHECK: # %bb.0: +; CHECK-NEXT:twnei 3, 0 +; CHECK-NEXT:blr Where are the aliases `twnei` and `tdnei` coming from? You don't seem to add them.

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoP.td:599 + Sched<[]>; +def SMBB32 : RVPBinary<0b100, 0b010, "smbb32">, + Sched<[]>; It looks like the 0.9.3 spec lists this as an alias of MULSR6

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:218-219 + + if (isStdOstreamOperatorCall(Call)) +return true; + NoQ wrote: > When you're doing `evalCall` you're responsible for modeling *all* aspects of > t

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357031. RedDocMD added a comment. Invalidating regions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h clang/

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

jyknight added a comment. This code doesn't handle multiple alternatives in a constraint. E.g. `"={eax}{ebx}"` or `"={eax}{ebx},m"`. See the GCC docs for the C-level syntax https://gcc.gnu.org/onlinedocs/gcc/Multi-Alternative.html#Multi-Alternative and LLVM IR docs for the IR syntax: https://llv

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

NeHuang resigned from this revision. NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-conversionfunc.c:2 +// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-unknown \ +// RUN: -emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN: %clang_cc

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

mizvekov added a comment. @aaron.ballman Yeah don't worry, having dinner, my hobby shift is starting soon though :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105518/new/ https://reviews.llvm.org/D105518 __

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2861178 , @ChuanqiXu wrote: > In D97915#2861036 , @ychen wrote: > >> In D97915#2860984 , @ChuanqiXu >> wrote: >> >>> In D97915#2860916

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

stephan.yichao.zhao added a comment. In D105378#2861914 , @morehouse wrote: > We may also want to consider creating a frontend flag like MSan's origin > tracking (`-fsanitize-memory-track-origins`). I will follow up this in a separate change. Reposito

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added a comment. Could LLDB find the linkage name on the declaration, look that name up in the symbol table, and find the DW_TAG_subprogram DIE for the symbol's start address? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://reviews.llvm.org/D105564 __

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71dc0f1c02cd: [dfsan][NFC] Add Origin Tracking into doc (authored by Jianzhou Zhao ). Repository: rG LLVM Github Monorepo

[clang] 71dc0f1 - [dfsan][NFC] Add Origin Tracking into doc

Author: Jianzhou Zhao Date: 2021-07-07T18:13:26Z New Revision: 71dc0f1c02cd00a431fc327b0ea86524fad28afe URL: https://github.com/llvm/llvm-project/commit/71dc0f1c02cd00a431fc327b0ea86524fad28afe DIFF: https://github.com/llvm/llvm-project/commit/71dc0f1c02cd00a431fc327b0ea86524fad28afe.diff LOG:

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

stephan.yichao.zhao updated this revision to Diff 357004. stephan.yichao.zhao marked an inline comment as done. stephan.yichao.zhao retitled this revision from " [dfsan][NFC] Add Origin Tracking into doc" to "[dfsan][NFC] Add Origin Tracking into doc". stephan.yichao.zhao added a comment. clang -

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/new/ https://reviews.llvm.org/D105447 ___

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've applied in 3c5721d77275d2a7bdaeeadd0b1c3864f1166110 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://rev

[clang] 3c5721d - Fix a failing assertion with -Wcast-align

Author: Queen Dela Cruz Date: 2021-07-07T14:00:31-04:00 New Revision: 3c5721d77275d2a7bdaeeadd0b1c3864f1166110 URL: https://github.com/llvm/llvm-project/commit/3c5721d77275d2a7bdaeeadd0b1c3864f1166110 DIFF: https://github.com/llvm/llvm-project/commit/3c5721d77275d2a7bdaeeadd0b1c3864f1166110.dif

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

aaron.ballman added a comment. Ping? Normally I wouldn't bother people so quickly, but this patch is addressing a major regression on trunk that had a revert request. We either need to get this landed ASAP or revert the original commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693 +if (!try_resolving_type) + return true; + aprantl wrote: > This block looks like it's more complicated than it needs to be. Could you > just say >

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added a comment. I think it would be best to split out the Clang change into a separately tested patch. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693 +if (!try_resolving_type) + return true; + This block looks like

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added a comment. I think it would be best to split out the Clang change into a separately tested patch. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1694 + // If the declared return type is "auto" we want the linkage name to go + // with the defintion. In ca

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik created this revision. shafik added reviewers: aprantl, teemperor, labath. Herald added a subscriber: arphaman. shafik requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Currently when we have a member function that has an auto return

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

qdelacru added a comment. Please use Queen Dela Cruz, qdela...@cisco.com. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D105551: [libTooling] Add support for implicit `this` to `buildAddressOf`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e32fa493a2: [libTooling] Add support for implicit `this` to `buildAddressOf`. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105551/n

[clang] d2e32fa - [libTooling] Add support for implicit `this` to `buildAddressOf`.

Author: Yitzhak Mandelbaum Date: 2021-07-07T17:35:04Z New Revision: d2e32fa493a272c21dee2c6cbf52e501f9ee3908 URL: https://github.com/llvm/llvm-project/commit/d2e32fa493a272c21dee2c6cbf52e501f9ee3908 DIFF: https://github.com/llvm/llvm-project/commit/d2e32fa493a272c21dee2c6cbf52e501f9ee3908.diff

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice, abhinavgaba. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. If the base is used in a map clause and later we have

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 356992. airlied added a comment. updated to full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D105526 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/opencl-c.h Index: clang/lib/Headers/op

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

MaskRay added a comment. In D102782#2862065 , @rsanthir.quic wrote: > @MaskRay Yes this would unblock applications. Regarding your concern, the > information from this implementation as well as GCC's should be used > conservatively as both are approxim

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356988. Conanap added a comment. Moved inst alias for 64bit to the 64 bit file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/Buil

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:50 BUILTIN(__builtin_ppc_compare_and_swaplp, "iLiD*Li*Li", "") +BUILTIN(__builtin_ppc_tdw, "vLLiLLiIi", "") +BUILTIN(__builtin_ppc_tw, "viiIi", "") NeHuang wrote: > definition h

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 356985. Conanap marked 15 inline comments as done. Conanap added a comment. Addressed comments, separated 64 bit C test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8340 } + // Bail out if we didn't make any correction progress on the checking + // TypoExpr TE, otherwise we risk running the loop forever. dgoldman wrote: >

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://reviews.llvm.org/D104742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

jansvoboda11 added a comment. In D103461#2841918 , @bmahjour wrote: > @jansvoboda11 This change is causing the following LIT tests to fail on AIX: > > Clang :: ClangScanDeps/headerwithdirname.cpp > Clang :: ClangScanDeps/headerwithdirnamefollowedbyinc

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. @MaskRay Yes this would unblock applications. Regarding your concern, the information from this implementation as well as GCC's should be used conservatively as both are approximate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added a comment. Extract the code out into a shared function, don't duplicate it otherwise we'll get confusing inconsistent defaults. Especially when there are proposals to change the defaults as currently there are some weird interactions where specifying seemingly-redundant flags chang

[PATCH] D105552: [analyzer][NFC] NoStoreFuncVisitor: Compact parameters for region pretty printing into a class

Szelethus added a comment. In D105552#2861924 , @vsavchenko wrote: > Sorry about being pretty harsh here. I do think that `NoStoreFuncVisitor` > needs refactoring and better abstractions, I just don't think that this is > the way to go. Nah, you're t

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

khchen created this revision. khchen added reviewers: jrtc27, asb, luismarques. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, nios

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp added a comment. @MaskRay Could you please look at the latest changeset, I have added your example as a separate test case for the x86 target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105142/new/ https://reviews.llvm.org/D105142 ___

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp updated this revision to Diff 356968. anirudhp added a comment. - Something went wrong with the previous time updating the diff. I'm not too sure, but I'm just doing it again, and this time the it looks a lot better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8340 } + // Bail out if we didn't make any correction progress on the checking + // TypoExpr TE, otherwise we risk running the loop forever. sammccall wrote: >

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp updated this revision to Diff 356961. anirudhp added a comment. - Disable constraint simplification when you already have a constraint of the form {...}. Constraint simplification is usually done character by character, with different targets having different implementations. - Furtherm

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, martong, steakhal, ASDenysPetrov. Szelethus added a project: clang. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, sunfish, rnkovacs, szepet, baloghadamsoftware, xazax.hun, wh

[PATCH] D105552: [analyzer][NFC] NoStoreFuncVisitor: Compact parameters for region pretty printing into a class

vsavchenko added a comment. Honestly, I don't really see how this is better. IMO `Printer` is something that prints, it should be everything that it does. It can accept different parameters tweaking how it prints in its constructor, but if it is a region printer, you should give it a region, an

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. We may also want to consider creating a frontend flag like MSan's origin tracking (`-fsanitize-memory-track-origins`). Comment at: clang/docs/DataFlowSanitizer.rst:214

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp added a comment. In D105142#2860885 , @MaskRay wrote: > This is great. > > unsigned long foo(unsigned long addr, unsigned long a0, > unsigned long a1, unsigned long a2, > unsigned long a3, unsigned long a

[PATCH] D105552: [analyzer][NFC] NoStoreFuncVisitor: Compact parameters for region pretty printing into a class

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, steakhal, martong, ASDenysPetrov. Szelethus added a project: clang. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity.

[PATCH] D105551: [libTooling] Add support for implicit `this` to `buildAddressOf`.

ymandel created this revision. ymandel added a reviewer: tdl-g. ymandel requested review of this revision. Herald added a project: clang. Changes `buildAddressOf` to return `this` when given an implicit `this` expression. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105551

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043 + // option to disable integrated-as explictly. + if (!TC.useIntegratedAs() && !TC.parseInlineAsmUsingAsmParser()) CmdArgs.push_back("-no-integrated-as"); shchenz wrote: > D

[PATCH] D105512: [AIX] Don't pass no-integrated-as by default

shchenz added a comment. I think it is ok to not passing `-no-integrated-as` to cc1 as the default value for backend for XCOFF is no integrated assembler. Can we make the logic be simpler here? Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043 + // option to disable int

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the fix, LGTM! Do you need help landing the change? If so, please let me know what name and email address you'd like me to use for patch attribution. CHANGES SINC

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

hokein added inline comments. Comment at: clang/test/SemaCXX/cxx11-crashes.cpp:117 + // The missing expression makes A undeduced. + static constexpr auto A = ; // expected-error {{expected expression}} + Foo::type B; // The type of B is also undeduced (wrapped in Elaborated

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

erichkeane added a comment. I agree with Aaron for the need of a test. At one point, we may wish to replace these calls with `getLangOpts().isCompatibleWithMSVC` or some similar inspection of `MSCompatibilityVersion`, but I acknowledge we can't do that until we figure out what the correct vers

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3c80dd8943a: [OPENMP]Remove const firstprivate allocation as a variable in a constant space. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] b3c80dd - [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

Author: Alexey Bataev Date: 2021-07-07T05:56:48-07:00 New Revision: b3c80dd8943a0d962bea1969b7a9e0147504d293 URL: https://github.com/llvm/llvm-project/commit/b3c80dd8943a0d962bea1969b7a9e0147504d293 DIFF: https://github.com/llvm/llvm-project/commit/b3c80dd8943a0d962bea1969b7a9e0147504d293.diff

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:7341 half8 __ovld fract(half8 x, __private half8 *iptr); half16 __ovld fract(half16 x, __private half16 *iptr); This one is not generic address space pointer though but I think this bit i

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added inline comments. Comment at: clang/test/SemaCXX/cxx11-crashes.cpp:117 + // The missing expression makes A undeduced. + static constexpr auto A = ; // expected-error {{expected expression}} + Foo::type B; // The type of B is also undeduced (wrapped in Elaborated

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 356925. adamcz added a comment. changed to marking field type as invalid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Sema/SemaDecl.cpp clang/t

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

aaron.ballman added a comment. In D105518#2861635 , @aaron.ballman wrote: > Thank you for working on this! I applied the patch locally and confirmed that > it solves the issue at hand. > > However, I'm not certain this is the right approach; what's the

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2860494 , @mizvekov wrote: >> I'd prefer to keep existing code working without requiring users to enable a >> flag, if at all possible (esp because I don't expect the flag to be needed >> forever). That said, I st

  1   2   >