shchenz added a comment.
I think it is ok to not passing `-no-integrated-as` to cc1 as the default value
for backend for XCOFF is no integrated assembler. Can we make the logic be
simpler here?
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043
+ // option to disable integrated-as explictly.
+ if (!TC.useIntegratedAs() && !TC.parseInlineAsmUsingAsmParser())
CmdArgs.push_back("-no-integrated-as");
----------------
Do we need a new virtual function `parseInlineAsmUsingAsmParser()` in the tool
chain file? Maybe we can use `isOSAIX()` and `Args.hasFlag(` here to change the
behaviour for AIX. inline assembly parser sounds like not a toolchain level
flag?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105512/new/
https://reviews.llvm.org/D105512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
