jsji added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5043
+ // option to disable integrated-as explictly.
+ if (!TC.useIntegratedAs() && !TC.parseInlineAsmUsingAsmParser())
CmdArgs.push_back("-no-integrated-as");
----------------
shchenz wrote:
> Do we need a new virtual function `parseInlineAsmUsingAsmParser()` in the
> tool chain file? Maybe we can use `isOSAIX()` and `Args.hasFlag(` here to
> change the behaviour for AIX. inline assembly parser sounds like not a
> toolchain level flag?
I think we should avoid adding os specific code here. The new abstraction
virtual function is designed to be usable by any target, just that aix is the
only one for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105512/new/
https://reviews.llvm.org/D105512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
