[PATCH] D89184: Support complex target features combinations

LiuChen3 added a comment. In D89184#2346453 , @pengfei wrote: > LGTM. But I suggest you waiting for 1 or 2 days to see if other reviewers > object. Sure. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

janosbenjaminantal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferScopedEnumsCheck.cpp:91 + llvm::SmallString<128> Buffer; + const StringRef ClassInsertion{"class "}; + aaron.ballman wrote: > janosbenjaminantal wrote: >

[PATCH] D89184: Support complex target features combinations

pengfei accepted this revision. pengfei added a comment. Herald added a subscriber: dexonsmith. LGTM. But I suggest you waiting for 1 or 2 days to see if other reviewers object. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 __

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums

janosbenjaminantal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-scoped-enums.cpp:165 + +enum class OpaqueScopedEnumWithFixedUnderlyingType : unsigned; aaron.ballman wrote: > njames93 wrote: > > janosbenja

[clang] de1016c - [driver][arm64] Set target CPU to A12 for compiler invocations that

Author: Alex Lorenz Date: 2020-10-21T23:35:27-07:00 New Revision: de1016ce5cdca2df51c00fbc5d3a750d5d72364a URL: https://github.com/llvm/llvm-project/commit/de1016ce5cdca2df51c00fbc5d3a750d5d72364a DIFF: https://github.com/llvm/llvm-project/commit/de1016ce5cdca2df51c00fbc5d3a750d5d72364a.diff L

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

This revision was automatically updated to reflect the committed changes. Closed by commit rGde1016ce5cdc: [driver][arm64] Set target CPU to A12 for compiler invocations that (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D82699?vs=299564&id=299879#toc Repository:

Re: [llvm-dev] Upcoming upgrade of LLVM buildbot

Thanks, Florian! I will look into this. Cheers Galina On Wed, Oct 21, 2020 at 5:30 AM Florian Hahn wrote: > > > On Oct 20, 2020, at 03:35, Galina Kistanova via llvm-dev < > llvm-...@lists.llvm.org> wrote: > > Hello everyone, > > We have reached the point when all the bots could be updated to a

[PATCH] D83088: Introduce CfgTraits abstraction

mehdi_amini added a comment. In D83088#2345540 , @nhaehnle wrote: > David, I don't think this is appropriate here. Let's take the discussion to > llvm-dev. Seems like David asked to revert in the meantime? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89914: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, this feels cleaner. Comment at: clang/include/clang/Basic/SourceManager.h:721 mutable FileID LastLineNoFileIDQuery; - mutable SrcMgr::ContentCache *LastLineNoConten

[clang] 5e2c9a0 - Fix test failure on Windows.

Author: Richard Smith Date: 2020-10-21T20:02:37-07:00 New Revision: 5e2c9a05b74c022dfb4780358b7f2b11e874993d URL: https://github.com/llvm/llvm-project/commit/5e2c9a05b74c022dfb4780358b7f2b11e874993d DIFF: https://github.com/llvm/llvm-project/commit/5e2c9a05b74c022dfb4780358b7f2b11e874993d.diff

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1684 bool MyInvalid = false; ComputeLineNumbers(Diag, Content, ContentCacheAlloc, *this, MyInvalid); if (MyInvalid) dexonsmith wrote: > shafik wrote: > > Is the `const_

[PATCH] D89922: SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC

dexonsmith updated this revision to Diff 299846. dexonsmith added a comment. Found a further simplification, removing a redundant call to `ContentCache::getBufferOrNone`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89922/new/ https://reviews.llvm.org/D89922 Files: clang/lib/Basic/

[PATCH] D89922: SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC

dexonsmith created this revision. dexonsmith added a reviewer: shafik. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Use `LineOffsetMapping:get` directly and remove/inline the helper `ComputeLineNumbers`, simplifying the callers. https://reviews.llvm.org/D899

[PATCH] D88631: [X86] Support customizing stack protector guard

xiangzhangllvm added a comment. TKS all review!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88631/new/ https://reviews.llvm.org/D88631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] 7c3fea7 - [X86] Support customizing stack protector guard

Author: Xiang1 Zhang Date: 2020-10-22T10:08:14+08:00 New Revision: 7c3fea7721e421de235917d9454d448f976500fc URL: https://github.com/llvm/llvm-project/commit/7c3fea7721e421de235917d9454d448f976500fc DIFF: https://github.com/llvm/llvm-project/commit/7c3fea7721e421de235917d9454d448f976500fc.diff

[PATCH] D88631: [X86] Support customizing stack protector guard

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c3fea7721e4: [X86] Support customizing stack protector guard (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

davidvancleve added a comment. +klimek: I added you from glancing at CODE_OWNERS.txt; are you a good reviewer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89920/new/ https://reviews.llvm.org/D89920 ___

[clang] 8156074 - Ensure that the "value" of an unnamed bit-field isn't taken into

Author: Richard Smith Date: 2020-10-21T18:51:55-07:00 New Revision: 81560743527e127ff8e47384db5dd60c7c40f153 URL: https://github.com/llvm/llvm-project/commit/81560743527e127ff8e47384db5dd60c7c40f153 DIFF: https://github.com/llvm/llvm-project/commit/81560743527e127ff8e47384db5dd60c7c40f153.diff

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

davidvancleve created this revision. davidvancleve added a reviewer: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. davidvancleve requested review of this revision. This change adds another export, `using TemplateArgumentMatcher = internal::Matcher;`, to the collecti

[clang] e04ba2b - Make APValue profiling a little more compact.

Author: Richard Smith Date: 2020-10-21T18:07:00-07:00 New Revision: e04ba2bc052f20fe745894b24b0f9b335db5abbc URL: https://github.com/llvm/llvm-project/commit/e04ba2bc052f20fe745894b24b0f9b335db5abbc DIFF: https://github.com/llvm/llvm-project/commit/e04ba2bc052f20fe745894b24b0f9b335db5abbc.diff

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

xyb created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. xyb requested review of this revision. For example, the above code: void main() { // clang-format off #define Sum(x, y) ((x) + (y)) Sum(1, 2); #undef Sum // clang-fo

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added a comment. ping. @jyknight @aaron.ballman @rjmccall any more thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 ___ cfe-commits mailing lis

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 299823. atmnpatel added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. reverse ping. Do you have an estimate when you update this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing lis

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. In D85474#2344823 , @compnerd wrote: > In D85474#2343393 , @MaskRay wrote: > >> In D85474#2343356 , @dexonsmith >> wrote: >> >>> In D85474#2343326 <

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

akyrtzi added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + Hi Anastasia, apologies for not catching this earlier, but libclang is intended to keep a stable

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

rjmccall added a comment. We do not actually support allocation failure for a lot of things around blocks. I don't think the copy-helper functions even have a way to propagate out a failure in copying a field. I have never seen any code in the wild that would handle `Block_copy` returning a n

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

void accepted this revision. void added a comment. This revision is now accepted and ready to land. Only a couple of nits, but I think this looks good. Comment at: llvm/docs/BitCodeFormat.rst:1072 +* code 69: ``byref`` +* code 70: ``mustprogress`` +* code 71: ``nossp``

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers added subscribers: jakubjelinek, marxin. nickdesaulniers added a comment. Started a thread with GCC folks (@marxin @jakubjelinek ) on this topic as well: https://lore.kernel.org/linux-toolchains/CAKwvOdnUB-SrPRXEF-oHpPvUfbuRL06Zd7LT9=jjqjs0vh2...@mail.gmail.com/T/#u Repository:

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 299814. tianshilei1992 added a comment. Tried to fix some cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[clang] e97e985 - [c++20] For P0732R2: permit class template argument deduction for non-type template parameters.

Author: Richard Smith Date: 2020-10-21T15:03:22-07:00 New Revision: e97e9851b227e98e39c27c4c8f5558e331cde8b4 URL: https://github.com/llvm/llvm-project/commit/e97e9851b227e98e39c27c4c8f5558e331cde8b4 DIFF: https://github.com/llvm/llvm-project/commit/e97e9851b227e98e39c27c4c8f5558e331cde8b4.diff

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers updated this revision to Diff 299813. nickdesaulniers added a comment. - handle additional case of ssp caller w/ nossp callee, update docs, add -Rpass-missed=inline test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ http

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

jdoerfert added a comment. can we add the reproducer to the tests please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 ___ cfe-commits mailing list cfe-commits

[PATCH] D89914: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

dexonsmith added a comment. Note that this was in response to Shafik's comment in https://reviews.llvm.org/D89554. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89914/new/ https://reviews.llvm.org/D89914 ___ cfe-commits mailing list cfe-comm

[PATCH] D89914: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

dexonsmith created this revision. dexonsmith added a reviewer: shafik. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Avoid some noisy `const_cast`s by making `ContentCache::SourceLineCache` and `SourceManager::LastLineNoContentCache` both mutable. https://rev

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

dexonsmith updated this revision to Diff 299811. dexonsmith added a comment. Renamed `getNumLines()` to `size()`, which is more natural given `begin()` and `end()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89913/new/ https://reviews.llvm.org/D89913 Files: clang/include/clang/Ba

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

dexonsmith created this revision. dexonsmith added a reviewer: shafik. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Put the guts of `ComputeLineNumbers` into `LineOffsetMapping::get` and `LineOffsetMapping::LineOffsetMapping`. As a drive-by, store the number

[PATCH] D89897: [AIX] Emit error for -G option on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4925 + if (RawTriple.isOSAIX()) +if (Arg *A = Args.getLastArg(options::OPT_G)) { + D.Diag(diag::err_drv_unsupported_opt_for_target) Either remove the braces

[clang-tools-extra] 1c1f794 - Always allow std::function to be copied.

Author: Felix Berger Date: 2020-10-21T17:20:35-04:00 New Revision: 1c1f794c2b645ba33a98f0359bc9d30bbef89920 URL: https://github.com/llvm/llvm-project/commit/1c1f794c2b645ba33a98f0359bc9d30bbef89920 DIFF: https://github.com/llvm/llvm-project/commit/1c1f794c2b645ba33a98f0359bc9d30bbef89920.diff

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1f794c2b64: Always allow std::function to be copied. (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/

[PATCH] D89897: [AIX] Emit error for -G option on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-err-options.c:1 +// RUN: %clang -target powerpc32-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \ +// RUN: FileCheck -check-prefix=CHECK32 %s Does this need a call to `not`? Re

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 299803. tianshilei1992 added a comment. Fixed an issue that when there is mapper, the variable in the generated wrapped task still uses the one in the encountering function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] caf30e7 - [c++20] For P0732R2: Give class NTTPs the proper type when examined with 'decltype'.

Author: Richard Smith Date: 2020-10-21T14:15:54-07:00 New Revision: caf30e7f03566f20c45e5d0895e71c4bff9056ef URL: https://github.com/llvm/llvm-project/commit/caf30e7f03566f20c45e5d0895e71c4bff9056ef DIFF: https://github.com/llvm/llvm-project/commit/caf30e7f03566f20c45e5d0895e71c4bff9056ef.diff

[PATCH] D89849: Add option 'exceptions' to pragma clang fp

mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3041 + if (AnnotValue->ExceptionsValue) +Actions.setExceptionMode(Tok.getLocation(), *AnnotValue->ExceptionsValue); ConsumeAnnotationToken(); sepavloff wrote: > mibintc wrote: > >

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/aix_alloca_align.c:2 +// RUN: %clang_cc1 -triple=powerpc-ibm-aix-xcoff -S -emit-llvm < %s | \ +// RUN: FileCheck -check-prefix 32BIT %s + Minor nit: Use double-hyphen for long option a

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1687 + return InlineResult::failure( + "non-stack-protected caller would inline stack-protected callee"); + nickdesaulniers wrote: > nickdesaulniers wrot

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1687 + return InlineResult::failure( + "non-stack-protected caller would inline stack-protected callee"); + nickdesaulniers wrote: > Is there a better wa

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4924 + if (RawTriple.isOSAIX()) +if (Arg *A = Args.getLastArg(options::OPT_G)) { jasonliu wrote: > Question: When do we query

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4a4ae97a7c: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https:

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1684 bool MyInvalid = false; ComputeLineNumbers(Diag, Content, ContentCacheAlloc, *this, MyInvalid); if (MyInvalid) shafik wrote: > Is the `const_cast` just for this li

[clang] cd4a4ae - [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

Author: Joseph Huber Date: 2020-10-21T17:01:36-04:00 New Revision: cd4a4ae97a7ccfa381e06936cd0981cb7d978ec1 URL: https://github.com/llvm/llvm-project/commit/cd4a4ae97a7ccfa381e06936cd0981cb7d978ec1 DIFF: https://github.com/llvm/llvm-project/commit/cd4a4ae97a7ccfa381e06936cd0981cb7d978ec1.diff

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Thanks! I've verified this fixes the test on AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904

[clang] eef2e67 - Simple fix to basic-block-sections to replace emit-obj with emit-llvm

Author: Sriraman Tallam Date: 2020-10-21T13:52:33-07:00 New Revision: eef2e67d2326e7d4027fddb29eefdb69371dc24a URL: https://github.com/llvm/llvm-project/commit/eef2e67d2326e7d4027fddb29eefdb69371dc24a DIFF: https://github.com/llvm/llvm-project/commit/eef2e67d2326e7d4027fddb29eefdb69371dc24a.dif

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: llvm/docs/LangRef.rst:1829 + +If a function with the ``nossp`` attribute calls a callee function that has +a stack protector function attribute, such as ``ssp``, ``sspreq`

[PATCH] D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}

MaskRay added a comment. In D53238#2345618 , @Yu wrote: > I accidentally come into this thread when searching for how to statically > link to libc++/libc++abi. I'm really curious if this patch will or will not > get merged. I'm really painful on using c+

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

nickdesaulniers updated this revision to Diff 299797. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - rebase, use stronger language about mutual exclusion, prefer assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, ZarkoCA. Herald added subscribers: cfe-commits, dexonsmith, kbarton, nemanjai. Herald added a project: clang. Xiangling_L requested review of this revision. On AIX, to support vector types, which shou

[PATCH] D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}

Yu added a comment. Herald added a subscriber: dang. I accidentally come into this thread when searching for how to statically link to libc++/libc++abi. I'm really curious if this patch will or will not get merged. I'm really painful on using c++17 on ancient environment which does not have lib

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx marked an inline comment as done. flx added a comment. Added a fake std function that still triggers the check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 __

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader marked an inline comment as not done. bader added a comment. Alternative approach with SYCL specific semantic attributes - https://reviews.llvm.org/D89909. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/ https://reviews.llvm.org/D80

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader created this revision. bader added reviewers: Anastasia, keryell, Naghasan, asavonic, Fznamznon. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, kerbowa, ebevhan, hiraditya, yaxunl, nhaehnle, jvesely, jholewinski. Herald added projects: clang, LLVM. bader requested review of

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx updated this revision to Diff 299794. flx added a comment. Add fake std function to ensure it is still matched. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 Files: clang-tools-extra/clang-tidy/perf

[clang] ba4768c - [c++20] For P0732R2 / P1907R1: Basic frontend support for class types as

Author: Richard Smith Date: 2020-10-21T13:21:41-07:00 New Revision: ba4768c966581658465f7366df9b0811f468a2d7 URL: https://github.com/llvm/llvm-project/commit/ba4768c966581658465f7366df9b0811f468a2d7 DIFF: https://github.com/llvm/llvm-project/commit/ba4768c966581658465f7366df9b0811f468a2d7.diff

[clang] 0c417d4 - Add more test coverage for APValue serialization / deserialization and

Author: Richard Smith Date: 2020-10-21T13:21:41-07:00 New Revision: 0c417d4bef1e78b0716c546101462f6d8962f358 URL: https://github.com/llvm/llvm-project/commit/0c417d4bef1e78b0716c546101462f6d8962f358 DIFF: https://github.com/llvm/llvm-project/commit/0c417d4bef1e78b0716c546101462f6d8962f358.diff

[PATCH] D89897: [AIX] Emit error for -G option on AIX

jasonliu added a comment. Could we add some rationale to the patch summary about why we would want to deliberately emitting an error for AIX? Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4924 + if (RawTriple.isOSAIX()) +if (Arg *A = Args.getLastArg(options::OPT_G))

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ille added a comment. One downside of that approach is performance. It's somewhat idiosyncratic, but I work on codebases that use blocks heavily in performance-sensitive paths. Typically, the blocks are never copied (they don't escape) and are expected to be inlined. Any implicit heap alloca

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. David, I don't think this is appropriate here. Let's take the discussion to llvm-dev. Comment at: mlir/include/mlir/IR/Dominance.h:49 +template <> +struct llvm::CfgTraitsFor { + using CfgTraits = mlir::CfgTraits; antiagainst wrote: >

[PATCH] D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS

Jonathan.Crowther updated this revision to Diff 299779. Jonathan.Crowther added a comment. Added a test for `-fno-short-enums` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89801/new/ https://reviews.llvm.org/D89801 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/zos

[clang] b3881d0 - [NFC] Fixes Doxygen copy-paste error.

Author: Mark de Wever Date: 2020-10-21T21:19:04+02:00 New Revision: b3881d01abcbc519032e0c942f90124f2bdba56a URL: https://github.com/llvm/llvm-project/commit/b3881d01abcbc519032e0c942f90124f2bdba56a DIFF: https://github.com/llvm/llvm-project/commit/b3881d01abcbc519032e0c942f90124f2bdba56a.diff

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED; -

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:59 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > > wrote: > > > > > > dblaikie added a comment. > > > > > > In D89500#2344234

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED;

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > wrote: > > > > dblaikie added a comment. > > > > In D89500#2344234 , @davezarzycki > > wrote: > > > > > I think I fixed it. Please

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

rjmccall added a comment. Of course, that wouldn't solve the general problem that the block might be getting used before its capture is fully initialized, but that's a general problem with uses within initializers in C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

rjmccall added a comment. It's not optimal, but an alternative would be to force the variable to the heap immediately rather than waiting for a potential block copy. The variable would actually be uninitialized during its "copy", so we'd need to give it a trivial copy helper. But once the var

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

[PATCH] D81072: [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools.

ddkilzer added a comment. Herald added a subscriber: steakhal. Thanks for implementing this! For posterity, I wanted to note a couple cases that this checker doesn't catch. 1. Under ARC, a more general case of assigning to an `__autoreleasing` variable. (Not sure why anyone would do this, but

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. (Accepted subject to previous comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 __

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 added a comment. In D89844#2345337 , @ye-luo wrote: > Getting this even when compiling without offload. You can use the reproducer > from the original bug report. I noticed one issue and I'm working on it now. Repository: rG LLVM Githu

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added a comment. There are a couple of cases where you're returning `EvalStmtResult` from a function with a `bool` return type, that I'd like to see fixed before this lands. All the other comments are directed towards producing more precise behavior when evaluating a function containing

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 updated this revision to Diff 299767. jhuber6 added a comment. Changing to just check if the target triple is of four known 64-bit architectures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904 Fil

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

ye-luo added a comment. Getting this even when compiling without offload. You can use the reproducer from the original bug report. clang++: /home/yeluo/opt/llvm-clang/llvm-project/llvm/include/llvm/ADT/APInt.h:1151: bool llvm::APInt::operator==(const llvm::APInt &) const: Assertion `BitWidth

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, daltenty. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. The changes made in D88594

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with an extra testing request (that should hopefully just work for you). Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:445 + int i = Orig(); +} -

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ille created this revision. ille added reviewers: jfb, rjmccall. Herald added a project: clang. ille requested review of this revision. This applies to situations where a `__block` variable's initializer references a block that potentially captures the variable itself. Clang special-cases this be

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED; -

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

dblaikie added a comment. In D89500#2344234 , @davezarzycki wrote: > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > Thanks - if that's unblocked you, gr

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante created this revision. Mordante added reviewers: aaron.ballman, rjmccall, rsmith. Mordante added a project: clang. Herald added a subscriber: dexonsmith. Mordante requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89899 Files: clang/incl

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein added a comment. friendly ping @rsmith :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87349/new/ https://reviews.llvm.org/D87349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. friendly ping @rsmith :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] cf11f01 - [NFC] Fix the definition of SuitableAlign

Author: Xiangling Liao Date: 2020-10-21T13:34:56-04:00 New Revision: cf11f017af32a797e301f56b163a989ad73630fa URL: https://github.com/llvm/llvm-project/commit/cf11f017af32a797e301f56b163a989ad73630fa DIFF: https://github.com/llvm/llvm-project/commit/cf11f017af32a797e301f56b163a989ad73630fa.diff

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, daltenty. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Xiangling_L requested review of this revision. 1. Emit error for -G driver option on AIX 2. A

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added a comment. In D89752#2344113 , @emankov wrote: > Thank you! > I've successfully applied your change in `Cuda.cpp` to the following clang > versions: `10.0.0`, `10.0.1`, `11.0.0`, and `12.0.0git`; and have created the > working patches (#206 >

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added a comment. In D63640#2339917 , @rsmith wrote: > In D63640#2331779 , @Tyker wrote: > >> but the "real" blocker is that the testing depends on D85144 >> for testing. >> w

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf34dd0c4e84: [clang] Improve Serialization/Imporing/Dumping of AP

[clang] cf34dd0 - [clang] Improve Serialization/Imporing/Dumping of APValues

Author: Tyker Date: 2020-10-21T19:03:13+02:00 New Revision: cf34dd0c4e84b69bb901f9cd4f3491852238ec44 URL: https://github.com/llvm/llvm-project/commit/cf34dd0c4e84b69bb901f9cd4f3491852238ec44 DIFF: https://github.com/llvm/llvm-project/commit/cf34dd0c4e84b69bb901f9cd4f3491852238ec44.diff LOG: [c

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344797 , @jhuber6 wrote: > In D89696#2344753 , @daltenty wrote: > >> In D89696#2344508 , @jhuber6 wrote: >> >>> @daltenty Do you think th

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Thank you all for you comments! Please find my replies below. I've picked 4 main points raised here. 1 - In D89799#2342677 , @rnk wrote: > This seems like pretty corner case functionality. Do we really need this > diagnostic

[clang] ba60de5 - Use -### in arm-float-abi.c test

Author: John Brawn Date: 2020-10-21T17:40:02+01:00 New Revision: ba60de5250ce1c4baa4a7bb7098ac67349f88a99 URL: https://github.com/llvm/llvm-project/commit/ba60de5250ce1c4baa4a7bb7098ac67349f88a99 DIFF: https://github.com/llvm/llvm-project/commit/ba60de5250ce1c4baa4a7bb7098ac67349f88a99.diff LO

  1   2   >