nickdesaulniers added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1687
+      return InlineResult::failure(
+          "non-stack-protected caller would inline stack-protected callee");
+
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > Is there a better way to emit an OptimizationRemark? Having this feedback 
> > in `-Rpass=inline` might be nice.
> See `llvm::setInlineRemark` for how these are set.
`InlineAdvisor::recordUnsuccessfulInliningImpl` already handles this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87956/new/

https://reviews.llvm.org/D87956

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to